Partha,
EXCELLENT commit with just one nit pick :) see inline.
java/code/webapp/WEB-INF/decorators/layout_c.jsp
| 5 +++
[snip filelist]
New commits:
commit 8c7a125761d570236aa67559e249ef336c3e83c6
Author: Partha Aji <p...@redhat.com>
Date: Fri Jun 19 18:37:46 2009 -0400
Fix for html:errors and html:messages to be consitently viewed in the UI
Basically cut out the duplicate code we used for html:message and
html:errors in every jsp
moved that logic to layout_c.jsp which is used by every jsp in our UI.
diff --git a/java/code/webapp/WEB-INF/decorators/layout_c.jsp
b/java/code/webapp/WEB-INF/decorators/layout_c.jsp
index f7e99f9..e4f8ad2 100644
--- a/java/code/webapp/WEB-INF/decorators/layout_c.jsp
+++ b/java/code/webapp/WEB-INF/decorators/layout_c.jsp
@@ -1,3 +1,4 @@
+<%@ taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-html"; prefix="html" %>
<%@ taglib uri="http://www.opensymphony.com/sitemesh/decorator";
prefix="decorator" %>
<%@ taglib uri="http://www.opensymphony.com/sitemesh/page"; prefix="page" %>
@@ -32,6 +33,10 @@
</td>
<td class="page-content">
+ <html:errors/>
+ <html:messages id="message" message="true">
+ <rhn:messages><c:out escapeXml="false"
value="${message}" /></rhn:messages>
+ </html:messages>
<decorator:body />
</td>
</tr>
Just a nit, can you not use tabs and make them line up with the
<decorator:body />.
[snip code removal bits]
jesus
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
