Re: [Spacewalk-devel] custom channel repos checksum

2009-07-15 Thread James Bowes
On Tue, Jul 14, 2009 at 12:14:49PM -0400, Pradeep Kilambi wrote: Hey Guys: So I'm mostly done with adding the sha256 checksum support for yum repo generation in taskomatic and its fully functional. Now, currently the way I have it working is, if the Channel or in child channel case (its

[Spacewalk-devel] [PATCH] Support inifinite available entitlements in TUI registration

2009-06-02 Thread James Bowes
From: James Bowes jbo...@redhat.com Date: Tue, 2 Jun 2009 10:40:51 -0400 Subject: [PATCH] Support infinite available entitlements in TUI registration getRemainingSubscriptions can return -1 if your account has an unlimited amount of entitlements for the channel you're trying to subscribe

[Spacewalk-devel] [PATCH] Send smbios data to remaining_subscriptions during registration

2009-05-28 Thread James Bowes
having a virtualization system level entitlement. -James From a73c56d2ff4bed16d35ca552caac0089e6e86c1c Mon Sep 17 00:00:00 2001 From: James Bowes jbo...@redhat.com Date: Thu, 28 May 2009 10:48:33 -0400 Subject: [PATCH] Send smbios data to remaining_subscriptions during registration For KVM or other

[Spacewalk-devel] [PATCH] Show all available eus channels during registration

2009-05-27 Thread James Bowes
: James Bowes jbo...@redhat.com Date: Wed, 27 May 2009 13:44:36 -0400 Subject: [PATCH] Show all available eus channels during registration There were two problems with the existing logic for getting applicable eus base channels during registration: - The rpm release version was compared exactly

[Spacewalk-devel] [PATCH] Recognize KVM/QEMU guests as virtual systems

2009-05-07 Thread James Bowes
for indications that the registering system is a KVM/QEMU guest. Right now this just sets the guest type as fully virt. It might be nice to add a third type for KVM/QEMU. -James From b57e391c38abd99292d6062b9d258dceeb6f6c32 Mon Sep 17 00:00:00 2001 From: James Bowes jbo...@redhat.com Date: Thu, 7 May 2009

Re: [Spacewalk-devel] removing remote branches

2009-04-27 Thread James Bowes
On Mon, Apr 27, 2009 at 09:51:06AM +0200, Miroslav Suchý wrote: Jesus M. Rodriguez wrote: Killed the following remote branches today: origin/thrift origin/iss origin/spacewalk-cobbler origin/origin/spacewalk-cobbler origin/multiorg origin/multiarch Here is what remains:

Re: [Spacewalk-devel] @version $Rev$

2009-04-24 Thread James Bowes
On Fri, Apr 24, 2009 at 11:49:50AM -0400, Jason Dobies wrote: My understanding is that the $revision$ (or $Rev$ or $Revision$ ... I've seen it a number of different ways) would be substituted on commit, but looking through the git site it's not. I ask because checkstyle enforces that we

Re: [Spacewalk-devel] commit messages proposal

2009-03-31 Thread James Bowes
On Tue, Mar 31, 2009 at 09:50:26AM +0200, Jan Pazdziora wrote: On Mon, Mar 30, 2009 at 10:37:12PM -0400, Jesus Rodriguez wrote: Thoughts? I suspect the lengths will cause folks to balk at this suggestion :) -1. I do not like restricting length of the first line of the commit message

[Spacewalk-devel] [PATCH] Teach tito to generate specfile changelog entries

2009-03-25 Thread James Bowes
If tito doesn't find a changelog entry in the specfile during a tag operation, he can now create one himself from the git logs. The entry line items are made from the subject and email of committer for all untagged commits of the package in question. If you don't like tito doing your work for

[Spacewalk-devel] [PATCH] Teach tito to let you use an editor on changelogs

2009-03-25 Thread James Bowes
An addendum to the previous patch; launch $EDITOR or vi to allow for modification to the changelog entry before commiting it. --- rel-eng/lib/spacewalk/releng/tagger.py | 39 --- 1 files changed, 25 insertions(+), 14 deletions(-) diff --git

[Spacewalk-devel] [PATCH] package-push: Avoid opening the system rpmdb

2009-03-22 Thread James Bowes
httpd and rpm both use the db4 library. When running code in httpd that uses rpmlib, the db4 so loaded by httpd will trump whatever may be loaded by rpm. If the versions linked against by the two code bases are different, any api/abi changes can cause breakage in the rpm code. Spacewalk imports

Re: [Spacewalk-devel] making log statment debug as it was intended to be

2009-03-18 Thread James Bowes
On Tue, Mar 17, 2009 at 11:48:37PM -0400, Jesus M. Rodriguez wrote: It avoids the creation of the debug string, over time this can get costly. We had a huge problem with this at my last job and we improved performance quite a bit by simply wrapping our debug logs in an if statement. the JIT

Re: [Spacewalk-devel] Code Review Tool

2009-03-13 Thread James Bowes
On Thu, Mar 12, 2009 at 03:31:53PM -0400, Jesus M. Rodriguez wrote: 2009/3/12 Michael Mraka michael.mr...@redhat.com: Pradeep Kilambi wrote: % Miroslav Suchý wrote: % Seeing as Jesus likes reviewing commit... I'm just wondering - do we % want to setup some Code Review tools? Will we use