Re: [Spacewalk-devel] [PATCH] RequestContext.buildPageLink: force parameter ordering

2013-09-13 Thread Grant Gainey
- Original Message - > Hi, > > I noticed that buildPageLink() uses a HashMap to keep track of query > string parameters. While this is perfectly okay from a web application > point of view, it makes testing a little more difficult and in > particular, RequestContextTest could break becau

[Spacewalk-devel] [PATCH] RequestContext.buildPageLink: force parameter ordering

2013-09-12 Thread Silvio Moioli
Hi, I noticed that buildPageLink() uses a HashMap to keep track of query string parameters. While this is perfectly okay from a web application point of view, it makes testing a little more difficult and in particular, RequestContextTest could break because it implicitly relies on key ordering. I