Re: [Spacewalk-devel] [PATCH 1/2] 705935 - add rhnSQL.commit() after process() to flush dangling transaction

2011-06-07 Thread Jan Pazdziora
On Fri, Jun 03, 2011 at 06:07:01AM +0200, Andreas Rogge wrote: Change to apacheHandler.py to make sure a transaction that might be open at the end of the request handling will be committed (or rolled back) --- backend/server/apacheHandler.py |2 ++ 1 files changed, 2 insertions(+), 0

Re: [Spacewalk-devel] [PATCH 1/2] 705935 - add rhnSQL.commit() after process() to flush dangling transaction

2011-06-07 Thread Jan Pazdziora
On Tue, Jun 07, 2011 at 01:29:33PM +0200, Andreas Rogge wrote: I don't think so. I guess the best way to go is: call the handler if all went well, commit Yes but do that within the handler, not in apacheHandler.py, which is the framework around the handlers. If the handler ended and did