Fedora Hosted Git Repositories - spacewalk.git/rss log, Partha Aji <> wrote:
% 250134:Added code to do a check on multibyte chars for max lenght in the
% validation...
%
% 250134:Added code to do a check on multibyte chars for max lenght in the
validation rhnvalidationhelper...
%
% • [DH] java/code/src/com/redhat/rhn/common/validator/StringConstraint.java
% • [DH] java/code/src/com/redhat/rhn/frontend/strings/jsp/
% StringResource_en_US.xml
%
% URL: http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h=
% 376e0035e09003a9918db3f1aa8e542bf639f605
+ private boolean lengthLessThan(String str, Number length) {
...
+ return str.getBytes("UTF8").length < length.intValue();
...
+ private boolean lengthGreaterThan(String str, Number length) {
...
+ return str.getBytes("UTF8").length >= length.intValue();
Why lengthLessThan have different semantic than lengthGreaterThan?
I mean < vs. >=. Should not lengthGreaterThan be lengthGreaterOrEqualThan?
And why the whole procedure code is duplicated and not simply
private boolean lengthGreaterOrEqualThan(String str, Number length) {
return ! (lengthLessThan(str, length));
}
?
--
Michael Mráka
Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
