David Miller a écrit :
From: BERTRAND_Joël [EMAIL PROTECTED]
Date: Mon, 23 Apr 2007 11:21:58 +0200
Is it possible to you to send your esp.c in attachment ? I use esp
driver with all patches you have sent to the mailing list.
Here are the current esp.c and esp.h files, as attachments.
From: BERTRAND_Joël [EMAIL PROTECTED]
Date: Tue, 24 Apr 2007 10:01:20 +0200
David Miller a écrit :
From: BERTRAND_Joël [EMAIL PROTECTED]
Date: Mon, 23 Apr 2007 11:21:58 +0200
Is it possible to you to send your esp.c in attachment ? I use esp
driver with all patches you have sent to
David Miller wrote:
But your patch doesn't seem right. The generic parport code should be
polling the status lines properly before calling down into the
-read() and -write() handlers of the driver.
The FEPS manual states that the BSY signal in the TCR register is
active low but that might just
Overall the driver looks really nice, thanks a lot!
some comments:
+#define esp_log_intr(f, a...) \
+do { if (esp_debug ESP_DEBUG_INTR) \
+ printk(f, ## a); \
+} while (0)
would be nice to have dev_printk here, but sbus still seems to
lack driver model integration.
+static
Oh, btw - there is a problem with the generic code beeing esp.ko -
we already have drivers/char/esp.c which buids into esp.ko for
ISA platforms, which have a bit of overlap with ESP-using platforms.
Maybe the driver should become esp_scsi.c/.ko or ncr_esp or
ncr53x9x?
-
To unsubscribe from this
On 4/22/07, David Miller [EMAIL PROTECTED] wrote:
Your email client adds newlines and other damage to your patches.
Hmm, I see :(
I used diff -u, but I should have used diff -up. Gmail took care of the
rest...
-p does not change that. (And if you ask me for a favorite flags
combination,
On Tue, Apr 24, 2007 at 01:22:35PM +0100, Christoph Hellwig wrote:
+static void esp_build_sync_msg(struct esp *esp, u8 period, u8 offset)
{
+ esp-msg_out[0] = EXTENDED_MESSAGE;
+ esp-msg_out[1] = 3;
+ esp-msg_out[2] = EXTENDED_SDTR;
+ esp-msg_out[3] = period;
+
On Tue, 2007-04-24 at 13:22 +0100, Christoph Hellwig wrote:
+static void esp_build_sync_msg(struct esp *esp, u8 period, u8
offset)
{
+ esp-msg_out[0] = EXTENDED_MESSAGE;
+ esp-msg_out[1] = 3;
+ esp-msg_out[2] = EXTENDED_SDTR;
+ esp-msg_out[3] = period;
+
