Re: 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-11 Thread David S. Miller
On Fri, 11 Feb 2005 02:38:38 -0800 William Lee Irwin III <[EMAIL PROTECTED]> wrote: > On Fri, Feb 11, 2005 at 12:36:48PM +0200, Meelis Roos wrote: > > Yes, the same compilation problem is also present in current 2.4. Patch > > is below, output from bk diffs -u and read into pine with ^R - does it

Re: 2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-11 Thread William Lee Irwin III
On Fri, Feb 11, 2005 at 12:36:48PM +0200, Meelis Roos wrote: > Yes, the same compilation problem is also present in current 2.4. Patch > is below, output from bk diffs -u and read into pine with ^R - does it > work this time? Dave, you seem to be in a flurry of sparc32 activity; did you want to

2.4 too - was [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-11 Thread Meelis Roos
Hi Melis, the same holds true for 2.4.29 @ line 124, 125, 126 in the system.h file. This ought to be the same problem, isn't it? I do not have a sparc32 system, but maybe you can check, Yes, the same compilation problem is also present in current 2.4. Patch is below, output from bk diffs -u and

Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-10 Thread David S. Miller
On Thu, 10 Feb 2005 21:05:29 -0600 Bob Breuer <[EMAIL PROTECTED]> wrote: > William Lee Irwin III wrote: > > > > #define nop() __asm__ __volatile__ ("nop"); > ^^^ > Looks like the nop macro needs to have it's semicolon taken away also. Good catch, I'

Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-10 Thread Bob Breuer
William Lee Irwin III wrote: #define nop() __asm__ __volatile__ ("nop"); ^^^ Looks like the nop macro needs to have it's semicolon taken away also. Bob - To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to

Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-10 Thread William Lee Irwin III
On Thu, 10 Feb 2005 09:19:28 +0200 (EET) Meelis Roos <[EMAIL PROTECTED]> wrote: >>> smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon >>> and cause compilation errors in single statement context, like >>> if-then-else on line 358 in include/linux/skbuff.h. This patch removes

Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-10 Thread William Lee Irwin III
On Thu, 10 Feb 2005 09:19:28 +0200 (EET) Meelis Roos <[EMAIL PROTECTED]> wrote: >> smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon >> and cause compilation errors in single statement context, like >> if-then-else on line 358 in include/linux/skbuff.h. This patch removes >

Re: [2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-10 Thread David S. Miller
On Thu, 10 Feb 2005 09:19:28 +0200 (EET) Meelis Roos <[EMAIL PROTECTED]> wrote: > smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon > and cause compilation errors in single statement context, like > if-then-else on line 358 in include/linux/skbuff.h. This patch removes > a

[2.6 PATCH] syntax errors by smp_{mb,rmb,wmb} on sparc32

2005-02-09 Thread Meelis Roos
smp_mb(), smp_rmp() and smp_wmb() definitions have a trailing semicolon and cause compilation errors in single statement context, like if-then-else on line 358 in include/linux/skbuff.h. This patch removes all three offending semicolons to make it compile. Signed-off-by: Meelis Roos <[EMAIL PRO