Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()

2008-02-01 Thread Andrew Morton
On Tue, 22 Jan 2008 15:13:58 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > @@ -566,10 +567,26 @@ static void mark_files_ro(struct super_b > { > struct file *f; > > +retry: > file_list_lock(); > list_for_each_entry(f, &sb->s_files, f_u.fu_list) { > - if (S_ISREG(f-

Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()

2008-01-22 Thread Christoph Hellwig
On Tue, Jan 22, 2008 at 03:13:58PM -0800, Dave Hansen wrote: > The emergency remount code forcibly removes FMODE_WRITE from > filps. The r/o bind mount code notices that this was done > without a proper mnt_drop_write() and properly gives a > warning. > > This patch does a mnt_drop_write() and al

Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()

2008-01-22 Thread Dave Hansen
On Tue, 2008-01-22 at 13:02 -0800, Andrew Morton wrote: > > On Tue, 22 Jan 2008 21:30:23 +0100 Mariusz Kozlowski <[EMAIL PROTECTED]> > > wrote: > > Hello, > > > > Issuing "sysrq-s sysrq-u" sequence causes these warnings on sparc64: > > > > [ cut here ] > > WARNING: at fs/

Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()

2008-01-22 Thread Dave Hansen
On Tue, 2008-01-22 at 13:02 -0800, Andrew Morton wrote: > > WARNING: at fs/file_table.c:49 __fput+0x1a8/0x1e0() > > Modules linked in: sg sr_mod cdrom > > Call Trace: > > [004c9ac8] __fput+0x1b0/0x1e0 > > [004c6978] filp_close+0x60/0x80 > > [004c6a18] sys_close+0x80/0xe0

Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()

2008-01-22 Thread Andrew Morton
> On Tue, 22 Jan 2008 21:30:23 +0100 Mariusz Kozlowski <[EMAIL PROTECTED]> > wrote: > Hello, > > Issuing "sysrq-s sysrq-u" sequence causes these warnings on sparc64: > > [ cut here ] > WARNING: at fs/file_table.c:49 __fput+0x1a8/0x1e0() > Modules linked in: sg sr_mod cdro

Re: 2.6.24-rc8-mm1: sparc64 warning at fs/file_table.c:49 __fput+0x1a8/0x1e0()

2008-01-22 Thread Mariusz Kozlowski
Hello, Issuing "sysrq-s sysrq-u" sequence causes these warnings on sparc64: [ cut here ] WARNING: at fs/file_table.c:49 __fput+0x1a8/0x1e0() Modules linked in: sg sr_mod cdrom Call Trace: [004c9ac8] __fput+0x1b0/0x1e0 [004c6978] filp_close+0x60/0x80 [000