Re: [spctools-discuss] Mascot2XML buffer overflow

2013-02-12 Thread Phil Charles
Hi again, Not sure why I didn't catch this before, but the nextmods variable is also vulnerable to the same overflow condition. A more complete fix is: *316:** *char nextpeptide[*1000*]; ... *324:** *char nextmods[*1000*]; ... *440: *int result = sscanf(nextline, %d %lf %lf %d %*1000*s %d

Re: [spctools-discuss] Mascot2XML buffer overflow

2013-01-16 Thread Luis Mendoza
Hi Phil, Many thanks for finding, fixing, and reporting this bug. We'll incorporate the fix into our next release. Cheers, --Luis On Wed, Jan 16, 2013 at 7:35 AM, Phil Charles estofi...@gmail.com wrote: Hi guys, I ran across a bug in Parsers/Algorithm2XML/Mascot2XML/MascotConverter.cxx