Re: [spi-devel-general] [PATCH] pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode

2008-09-11 Thread Ned Forrester
Ned Forrester wrote: > Daniel Ribeiro wrote: > In a past message, you showed the automatic declarations that went with > the above code: > > > struct spi_transfer t; > > struct spi_message m; > > While spi_message_init() zeros the memory in "m", you don't show any > code above, other than

Re: [spi-devel-general] [PATCH] pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode

2008-09-11 Thread Ned Forrester
Daniel Ribeiro wrote: > Em Qui, 2008-09-11 Ã s 10:41 -0700, David Brownell escreveu: > Yes, i guess i really should use spi_setup(). > My current code is: > > spi_message_init(&m); > t.len = 4; > t.tx_buf = (u8 *)data; > t.rx_buf = (u8 *)data; > t.bits_per_w

Re: [spi-devel-general] [PATCH] pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode

2008-09-11 Thread Daniel Ribeiro
Em Qui, 2008-09-11 às 10:41 -0700, David Brownell escreveu: > You could instead > > return spi_write_then_read(pcap.spi, data, 4, data, 4); Tried this already. data == 0x. Anyway, after the latest chipselect fixes, (deassert CS on pump_transfer() || giveback() instead of int_transfer_

[spi-devel-general] [patch 2.6.27-rc6+mm] pxa2xx_spi: minor cleanup

2008-09-11 Thread David Brownell
From: Guennadi Liakhovetski <[EMAIL PROTECTED]> Minor fixes: remove redundant local variable initialization, fix "can not" to what I _think_ is a preferred spelling, output IRQ number if requesting it failed. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> Signed-off-by: David Brownell <

Re: [spi-devel-general] [PATCH] spi: pxa2xx_spi introduce chip select gpio to simplify the common cases

2008-09-11 Thread David Brownell
On Thursday 11 September 2008, Ned Forrester wrote: > I'm puzzled. What is there about the pxa2xx_spi.c that would be > simplified by doing anything with respect to SSPFRM? The usage model ... callers must understand that option, evaluate whether it's even usable on their board, and then have an

[spi-devel-general] [patch 2.6.27-rc6] spi_s3c24xx: pin configuration updates

2008-09-11 Thread David Brownell
From: Ben Dooks <[EMAIL PROTECTED]> Add a pin configuration callback for the s3c24xx SPI driver, as there are several options depending on the channel and the chip in use. This is needed as the controller may not have been setup by the initial bootloader and the fact that the SPI controller gets

Re: [spi-devel-general] spi_s3c24xx: fix section mismatch and __devexit code

2008-09-11 Thread David Brownell
On Friday 08 August 2008, Ben Dooks wrote: > Fix the section mismatch warning generated by the iconrrect > naming of s3c24xx_spidrv which should be s3c24xx_spi_driver: > > WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4): Section mismatch > in reference from the variable s3c24xx_spidrv > to the (unkn

Re: [spi-devel-general] [PATCH] pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode

2008-09-11 Thread David Brownell
Catching up on old mail ... On Monday 18 August 2008, Daniel Ribeiro wrote: > As I already said, i am converting a working driver from ssp.c´s > ssp_read_word/ssp_write_word to pxa2xx_spi. The driver works just > fine with: > > gpio_set_value(cs, 0); > ssp_write_word(&ssp_dev, data); > ssp_read_w

Re: [spi-devel-general] [PATCH] spi: pxa2xx_spi introduce chip select gpio to simplify the common cases

2008-09-11 Thread Ned Forrester
David Brownell wrote: > On Tuesday 09 September 2008, Jonathan Cameron wrote: >>> - It's probably worth removing support for the SSFRM >>>mechanism and requiring gpio_cs or (at least as a >>>transitional scheme) the cs_control() thing. >> I disagree strongly with this. >> >> By all means i

Re: [spi-devel-general] [patch 2.6.27-rc6] pxa2xx_spi: dma bugfixes

2008-09-11 Thread David Brownell
On Wednesday 10 September 2008, Andrew Morton wrote: > help. > > Which of these: > > mpc52xx_psc_spi-remove-code-associated-with-config_ppc_merge.patch > spi-simplify-spi_write_then_read.patch Those two seem non-essential to me, but if you're merging many of those "remove-code"... patches you sh

Re: [spi-devel-general] [patch 2.6.27-rc6] spi_mpc83xx: reject invalid transfer sizes

2008-09-11 Thread Peter Korsgaard
> "Andrew" == Andrew Morton <[EMAIL PROTECTED]> writes: Andrew> Why? What user-visible problem (if any) does this fix? I slightly reworded the commit text in the update I sent last night (no code changes), but David apparently missed it: [PATCH] spi_mpc83xx: handle odd transfer sizes Erro