Re: [spi-devel-general] [patch 2.6.27-rc6] spi_s3c24xx: fix section warning

2008-09-12 Thread David Brownell
On Friday 12 September 2008, Andrew Morton wrote: > On Fri, 12 Sep 2008 09:44:13 -0700 > David Brownell <[EMAIL PROTECTED]> wrote: > > > From: Ben Dooks <[EMAIL PROTECTED]> > > > > Fix the section mismatch warning generated by the iconrrect > > naming of s3c24xx_spidrv which should be s3c24xx_spi

Re: [spi-devel-general] [patch 2.6.27-rc6] spi_s3c24xx: fix section warning

2008-09-12 Thread Andrew Morton
On Fri, 12 Sep 2008 09:44:13 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > From: Ben Dooks <[EMAIL PROTECTED]> > > Fix the section mismatch warning generated by the iconrrect > naming of s3c24xx_spidrv which should be s3c24xx_spi_driver: > > WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4): >

[spi-devel-general] [patch 2.6.27-rc6] spi_s3c24xx: fix section warning

2008-09-12 Thread David Brownell
From: Ben Dooks <[EMAIL PROTECTED]> Fix the section mismatch warning generated by the iconrrect naming of s3c24xx_spidrv which should be s3c24xx_spi_driver: WARNING: drivers/spi/spi_s3c24xx.o(.data+0x4): Section mismatch in reference from the variable s3c24xx_spidrv to the (unknown reference)

Re: [spi-devel-general] [PATCH] spi: pxa2xx_spi introduce chip select gpio to simplify the common cases

2008-09-12 Thread Jonathan Cameron
David Brownell wrote: > On Thursday 11 September 2008, Ned Forrester wrote: > >> I'm puzzled. What is there about the pxa2xx_spi.c that would be >> simplified by doing anything with respect to SSPFRM? > > The usage model ... callers must understand that option, > evaluate whether it's even usabl

Re: [spi-devel-general] [PATCH] pxa2xx_spi: Fix chip_info defaults and documentation.

2008-09-12 Thread David Brownell
From: Vernon Sauder <[EMAIL PROTECTED]> Make the chip info structure data optional by providing reasonable defaults. Improve corresponding documentation, and highlight the drawback of not providing explicit chipselect control. DMA can determine appropriate dma_burst_size and thresholds automatic