Re: [spi-devel-general] [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-27 Thread Stephen Rothwell
Hi David, Stefan, On Sat, 27 Dec 2008 11:32:25 -0800 David Brownell wrote: > > Also: > > > +static struct of_platform_driver spi_ppc4xx_of_driver = { > > +   .owner = THIS_MODULE, > > +   .name = DRIVER_NAME, > > I'd hope the PPC folk eliminate this duplication soonish. > Those fields a

Re: [spi-devel-general] [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-27 Thread David Brownell
Also: > +static struct of_platform_driver spi_ppc4xx_of_driver = { > +   .owner = THIS_MODULE, > +   .name = DRIVER_NAME, I'd hope the PPC folk eliminate this duplication soonish. Those fields are obvious duplicates of the driver model fields... > +   .match_table = spi_ppc4xx_of_ma

Re: [spi-devel-general] [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-27 Thread David Brownell
On Tuesday 25 November 2008, Stefan Roese wrote: > Changes in v5: > - Don't call setupxfer() from setup() so that the baudrate etc > won't get changed while another transfer is active, as suggested > by David Brownell. Better, but this still doesn't seem quite right: > +static int spi_ppc4xx

[spi-devel-general] [SPAM] Merry Christmas 'N Happy New Year!

2008-12-27 Thread Brian
Brian just mailed an electronic Christmas greeting card. You can click the following link to see your ecard: http://freedecember.com/?ID=8e815b7a9ceac1 Regards, Webmaster -- __