Re: [spi-devel-general] [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero

2009-12-17 Thread Anton Vorontsov
On Wed, Dec 16, 2009 at 05:10:08PM +0100, Uwe Kleine-König wrote: platform_get_irq returns -ENXIO on failure, so !irq was probably always true. Better use (int)irq = 0. Note that a return value of zero is still handled as error even though this could mean irq0. This is a followup to

[spi-devel-general] [git pull] 2nd batch of SPI changes

2009-12-17 Thread Grant Likely
Hi Linus, This is later than I'd like it to be, and I hope it gets to you before you cut -rc1. There was some slack between Andrew and I on handing off SPI maintainership. Patches I had picked up in the last batch conflicted with his stack and we decided it was best if I just take the remainder

Re: [spi-devel-general] [PATCH] spi: xilinx_spi: Fix up I/O routine wrapping bogosity.

2009-12-17 Thread Grant Likely
On Tue, Dec 15, 2009 at 10:01 PM, Paul Mundt let...@linux-sh.org wrote: xilinx_spi presently makes some fairly questionable assumptions about I/O routines, and attempts to assign ioread32/iowrite32 and friends directly to its own internal function pointers. On many platforms these I/O routines

Re: [spi-devel-general] [git pull] 2nd batch of SPI changes

2009-12-17 Thread Grant Likely
On Thu, Dec 17, 2009 at 5:45 PM, jassi brar jassisinghb...@gmail.com wrote: On Fri, Dec 18, 2009 at 1:40 AM, Grant Likely grant.lik...@secretlab.ca wrote: Jassi Brar (1):      spi: Add s3c64xx SPI Controller driver IIRC, I didn't get any final ack of acceptance from you or any other