Re: [spi-devel-general] [RFC][PATCH] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread Feng Tang
On Thu, 25 Feb 2010 12:47:13 +0800 David Brownell wrote: > On Tuesday 29 December 2009, Erwin Authried wrote: > > I think there's no need for a MAX3100 **and** a MAX3110 driver, > > this is just confusing. The MAX3110 driver is identical to the > > MAX3100 from the software view, it is simply a M

Re: [spi-devel-general] [RFC][PATCH v3] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread Feng Tang
On Thu, 25 Feb 2010 12:43:14 +0800 David Brownell wrote: > On Tuesday 23 February 2010, Feng Tang wrote: > > > > +config SERIAL_MAX3110 > > +   tristate "SPI UART driver for Max3110" > > +   select SERIAL_CORE > > +   select SERIAL_CORE_CONSOLE > > Shouldn't that depend on SPI_MASTE

Re: [spi-devel-general] [RFC][PATCH] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread David Brownell
On Tuesday 29 December 2009, Erwin Authried wrote: > I think there's no need for a MAX3100 **and** a MAX3110 driver, this is > just confusing. The MAX3110 driver is identical to the MAX3100 from the > software view, it is simply a MAX3100 with transceivers added to the > chip. If there's any improv

Re: [spi-devel-general] [RFC][PATCH v3] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread David Brownell
On Tuesday 23 February 2010, Feng Tang wrote: > > +config SERIAL_MAX3110 > +   tristate "SPI UART driver for Max3110" > +   select SERIAL_CORE > +   select SERIAL_CORE_CONSOLE Shouldn't that depend on SPI_MASTER? As it stands, you're permitting it to build on systems that you *know*

Re: [spi-devel-general] [RFC][PATCH v3] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread Feng Tang
On Thu, 25 Feb 2010 07:18:32 +0800 Andrew Morton wrote: > > ... > > > > +static int max3110_main_thread(void *_max) > > +{ > > + struct uart_max3110 *max = _max; > > + wait_queue_head_t *wq = &max->wq; > > + int ret = 0; > > + struct circ_buf *xmit = &max->con_xmit; > > + > > + init_wai

Re: [spi-devel-general] [RFC][PATCH v3] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread Andrew Morton
On Wed, 24 Feb 2010 13:11:30 +0800 Feng Tang wrote: > Hi All, > > Here is a driver for Maxim 3110 SPI-UART device, please help to review. > > It has been validated with Designware SPI controller (drivers/spi: dw_spi.c & > dw_spi_pci.c). It supports polling and IRQ mode, supports batch read, and

Re: [spi-devel-general] [PATCH 1/2] spi/mmc_spi: SPI bus locking API, using mutex

2010-02-24 Thread Grant Likely
On Wed, Feb 17, 2010 at 2:41 PM, Mike Frysinger wrote: > On Wed, Feb 17, 2010 at 16:07, Grant Likely wrote: >> Also, even if I agreed with the premise that a cookie is needed for >> deciding who can use the bus when locked, it is still a good idea to >> use a different API when working with a lock

Re: [spi-devel-general] [PATCH 1/2 V2] spi/mmc_spi: SPI bus locking API, using mutex

2010-02-24 Thread Grant Likely
Hey Ernst. Good patch, thank you. The merge window is going to open any moment now, and this patch hasn't had any linux-next exposure, so I'm not going to pick it up for 2.6.34. Instead, I'll wait until after the merge window closes and add it to my next branch so that it gets lots of exposure b

Re: [spi-devel-general] [RFC][PATCH v3] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread Grant Likely
On Wed, Feb 24, 2010 at 3:44 AM, Alan Cox wrote: > On Wed, 24 Feb 2010 13:11:30 +0800 > Feng Tang wrote: > >> Hi All, >> >> Here is a driver for Maxim 3110 SPI-UART device, please help to review. >> >> It has been validated with Designware SPI controller (drivers/spi: dw_spi.c & >> dw_spi_pci.c).

Re: [spi-devel-general] [RFC][PATCH v3] serial: spi: add spi-uart driver for Maxim 3110

2010-02-24 Thread Alan Cox
On Wed, 24 Feb 2010 13:11:30 +0800 Feng Tang wrote: > Hi All, > > Here is a driver for Maxim 3110 SPI-UART device, please help to review. > > It has been validated with Designware SPI controller (drivers/spi: dw_spi.c & > dw_spi_pci.c). It supports polling and IRQ mode, supports batch read, and