RE: [PATCH v3 3/7] eSPI: add eSPI controller support

2010-10-08 Thread Hu Mingkai-B21284
-Original Message- From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] Sent: Friday, October 01, 2010 7:22 PM To: Hu Mingkai-B21284 Cc: linuxppc-...@ozlabs.org; spi-devel-general@lists.sourceforge.net; linux- m...@lists.infradead.org; Gala Kumar-B11780 Subject: Re: [PATCH v3

RE: [PATCH v3 2/7] spi/mpc8xxx: refactor the common code for SPI/eSPI controller

2010-10-08 Thread Hu Mingkai-B21284
-Original Message- From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] Sent: Friday, October 01, 2010 7:22 PM To: Hu Mingkai-B21284 Cc: linuxppc-...@ozlabs.org; spi-devel-general@lists.sourceforge.net; linux- m...@lists.infradead.org; Gala Kumar-B11780; Zang Roy-R61911 Subject:

Re: [PATCH v3 6/7] mtd: m25p80: add a read function to read page by page

2010-10-08 Thread Kumar Gala
On Oct 7, 2010, at 9:15 PM, Hu Mingkai-B21284 wrote: Yes, I agree with David on this. If large transfers don't work, then it is the SPI master driver that is buggy. By the way, does this fix your problem? https://patchwork.kernel.org/patch/184752/ It shouldn't. AFAIK, eSPI is

[PATCH 7/6] spi/imx: Support different fifo sizes

2010-10-08 Thread Uwe Kleine-König
From: David Jander da...@protonic.nl The i.MX51 ECSPI has a fifo size of 64 entries instead of 8 entries as found on the other cspi bus devices. Cc: Jason Wang jason77.w...@gmail.com Signed-off-by: David Jander da...@protonic.nl Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by:

Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver.

2010-10-08 Thread Jonathan Cameron
*bump* For anyone from spi side of things. Quick summary of question (hence top post :) Is it ever wrong to over specify elements of a transfer? We have a driver that (for historical reasons) specifies that a particular transfer is 8 bit. .bits_per_word = 8, This causes issues with the

Re: [PATCH 7/6] spi/imx: Support different fifo sizes

2010-10-08 Thread Grant Likely
On Fri, Oct 08, 2010 at 11:24:01AM +0200, Uwe Kleine-König wrote: From: David Jander da...@protonic.nl The i.MX51 ECSPI has a fifo size of 64 entries instead of 8 entries as found on the other cspi bus devices. Cc: Jason Wang jason77.w...@gmail.com Signed-off-by: David Jander

Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver.

2010-10-08 Thread Grant Likely
On Fri, Oct 08, 2010 at 12:22:28PM +0100, Jonathan Cameron wrote: *bump* For anyone from spi side of things. Quick summary of question (hence top post :) Is it ever wrong to over specify elements of a transfer? We have a driver that (for historical reasons) specifies that a particular

Re: [PATCH 22/24] spi: change to new flag variable

2010-10-08 Thread Grant Likely
On Fri, Sep 24, 2010 at 12:17:32PM -0700, matt mooney wrote: Replace EXTRA_CFLAGS with ccflags-y. Signed-off-by: matt mooney m...@muteddisk.com Applied, thanks. g. --- drivers/spi/Makefile |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/spi/Makefile

Re: [MeeGo-Dev][PATCH v2] Topcliff: Update PCH_SPI driver to 2.6.35

2010-10-08 Thread Grant Likely
On Thu, Sep 16, 2010 at 04:32:56PM +0900, Masayuki Ohtak wrote: Hi Grant, We have modified whole of your indications. Thanks, Ohtake (OKISemi) Hi Ohtake. There are still a bunch of minor issues with this driver, but I've picked it up anyway and additional cleanups can be done in-tree now

[PATCH] spi/topcliff: cleanups for style and conciseness

2010-10-08 Thread Grant Likely
This patch makes multiple cleanups to the new topcliff pch spi driver including, but not limited to, - removing superfluous brackets around variables - open coding functions that are only used once - removing unnecessary line breaks - removing unused functions - simplifying the interrupt