Re: [Uclinux-dist-devel] [PATCH 00/28] Blackfin SPI updates for 2.6.36

On Mon, Oct 18, 2010 at 12:37 AM, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:34, Mike Frysinger wrote: >> On Mon, Oct 18, 2010 at 02:28, Grant Likely wrote: >>> I *might* pick these up for .36, but it is very late for picking up >>> stuff that hasn't had any linux-next exposure yet. >> >>

Re: [Uclinux-dist-devel] [PATCH 00/28] Blackfin SPI updates for 2.6.36

On Mon, Oct 18, 2010 at 02:34, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:28, Grant Likely wrote: >> On Sun, Oct 17, 2010 at 06:59:13PM -0400, Mike Frysinger wrote: >>> Quite a bit here, but these patches have been around for a while.  The >>> reason they haven't been pushed up before was t

[PATCH 29/28] spi/bfin_spi: namespace local structs

Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 119 +++-- 1 files changed, 61 insertions(+), 58 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index d17ab37..ab483a0 100644 --- a/drivers/spi/spi_bfin5xx.c ++

Re: [Uclinux-dist-devel] [PATCH 11/28] Blackfin SPI: convert struct names to something more logical

On Mon, Oct 18, 2010 at 02:28:23AM -0400, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:20, Grant Likely wrote: > > On Mon, Oct 18, 2010 at 02:10:17AM -0400, Mike Frysinger wrote: > >> On Mon, Oct 18, 2010 at 02:02, Grant Likely wrote: > >> > On Sun, Oct 17, 2010 at 06:59:24PM -0400, Mike Frys

Re: [Uclinux-dist-devel] [PATCH 00/28] Blackfin SPI updates for 2.6.36

On Mon, Oct 18, 2010 at 02:34, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:28, Grant Likely wrote: >> I *might* pick these up for .36, but it is very late for picking up >> stuff that hasn't had any linux-next exposure yet. > > these issues have been around for so long that missing another 2

Re: [Uclinux-dist-devel] [PATCH 00/28] Blackfin SPI updates for 2.6.36

On Mon, Oct 18, 2010 at 02:28, Grant Likely wrote: > On Sun, Oct 17, 2010 at 06:59:13PM -0400, Mike Frysinger wrote: >> Quite a bit here, but these patches have been around for a while.  The >> reason they haven't been pushed up before was that some of the first >> changes introduced known bugs the

Re: [Uclinux-dist-devel] [PATCH 11/28] Blackfin SPI: convert struct names to something more logical

On Mon, Oct 18, 2010 at 02:20, Grant Likely wrote: > On Mon, Oct 18, 2010 at 02:10:17AM -0400, Mike Frysinger wrote: >> On Mon, Oct 18, 2010 at 02:02, Grant Likely wrote: >> > On Sun, Oct 17, 2010 at 06:59:24PM -0400, Mike Frysinger wrote: >> >> -struct driver_data { >> >> +struct master_data { >>

Re: [PATCH 00/28] Blackfin SPI updates for 2.6.36

On Sun, Oct 17, 2010 at 06:59:13PM -0400, Mike Frysinger wrote: > Quite a bit here, but these patches have been around for a while. The > reason they haven't been pushed up before was that some of the first > changes introduced known bugs themselves and needed some manual fixing. > > Also, while

Re: [Uclinux-dist-devel] [PATCH 28/28] Blackfin SPI: init early

On Mon, Oct 18, 2010 at 02:14:28AM -0400, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:12, Grant Likely wrote: > > On Sun, Oct 17, 2010 at 06:59:41PM -0400, Mike Frysinger wrote: > >> From: Michael Hennerich > >> > >> Some systems using this bus sometimes have very basic devices on them > >>

Re: [Uclinux-dist-devel] [PATCH 11/28] Blackfin SPI: convert struct names to something more logical

On Mon, Oct 18, 2010 at 02:10:17AM -0400, Mike Frysinger wrote: > On Mon, Oct 18, 2010 at 02:02, Grant Likely wrote: > > On Sun, Oct 17, 2010 at 06:59:24PM -0400, Mike Frysinger wrote: > >> -struct driver_data { > >> +struct master_data { > > > > Or better yet, to protect against global collisions,

Re: [Uclinux-dist-devel] [PATCH 28/28] Blackfin SPI: init early

On Mon, Oct 18, 2010 at 02:12, Grant Likely wrote: > On Sun, Oct 17, 2010 at 06:59:41PM -0400, Mike Frysinger wrote: >> From: Michael Hennerich >> >> Some systems using this bus sometimes have very basic devices on them >> such as regulators.  So we need to be loaded even earlier in case the >> de

Re: [Uclinux-dist-devel] [PATCH 14/28] Blackfin: SPI: expand SPI bitmasks

On Mon, Oct 18, 2010 at 02:04, Grant Likely wrote: > On Sun, Oct 17, 2010 at 06:59:27PM -0400, Mike Frysinger wrote: >> Expand the BIT_CTL defines to use the naming convention of the hardware, >> and expand the masks to cover all documented bits. >> >> Signed-off-by: Mike Frysinger >> --- >>  arch

Re: [PATCH 28/28] Blackfin SPI: init early

On Sun, Oct 17, 2010 at 06:59:41PM -0400, Mike Frysinger wrote: > From: Michael Hennerich > > Some systems using this bus sometimes have very basic devices on them > such as regulators. So we need to be loaded even earlier in case the > devices are used before userspace is loaded. Therefore reg

Re: [Uclinux-dist-devel] [PATCH 11/28] Blackfin SPI: convert struct names to something more logical

On Mon, Oct 18, 2010 at 02:02, Grant Likely wrote: > On Sun, Oct 17, 2010 at 06:59:24PM -0400, Mike Frysinger wrote: >> -struct driver_data { >> +struct master_data { > > Or better yet, to protect against global collisions, bfin5xx_master perhaps? i'd rather not. there is too much "bfin5xx" stuff

Re: [PATCH 14/28] Blackfin: SPI: expand SPI bitmasks

On Sun, Oct 17, 2010 at 06:59:27PM -0400, Mike Frysinger wrote: > Expand the BIT_CTL defines to use the naming convention of the hardware, > and expand the masks to cover all documented bits. > > Signed-off-by: Mike Frysinger > --- > arch/blackfin/include/asm/bfin5xx_spi.h | 11 +++ >

Re: [PATCH 11/28] Blackfin SPI: convert struct names to something more logical

On Sun, Oct 17, 2010 at 06:59:24PM -0400, Mike Frysinger wrote: > The current structure names are a bit confusing as to what they represent, > so use better names. > > Reported-by: David Brownell > Signed-off-by: Mike Frysinger > --- > drivers/spi/spi_bfin5xx.c | 100 ++

[PATCH 28/28] Blackfin SPI: init early

From: Michael Hennerich Some systems using this bus sometimes have very basic devices on them such as regulators. So we need to be loaded even earlier in case the devices are used before userspace is loaded. Therefore register in subsys_initcall(). Signed-off-by: Michael Hennerich Signed-off-

[PATCH 26/28] Blackfin SPI: warn when CS is driven by hardware (CPHA=0)

From: Barry Song When the hardware is controlling the CS, there are some SPI options we are unable to support. So issue a warning in the hopes that the user will change to a SPI mode where we can support things sanely. Signed-off-by: Barry Song Signed-off-by: Mike Frysinger --- drivers/spi/s

[PATCH 21/28] Blackfin SPI: combine duplicate SPI_CTL read/write logic

While combining things, also switch to the proper SPI bit define names. This lets us punt the rarely used SPI defines. Signed-off-by: Mike Frysinger --- arch/blackfin/include/asm/bfin5xx_spi.h | 68 --- drivers/spi/spi_bfin5xx.c | 40

[PATCH 27/28] Blackfin SPI: check per-transfer bits_per_word

From: Bob Liu Currently, if the bits_per_word when doing a transfer is not 8bits, we always treat it as 16bits when we should actually be returning an error. Signed-off-by: Bob Liu Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |7 ++- 1 files changed, 6 insertions(+), 1

[PATCH 25/28] Blackfin SPI: cs should be always low when a new transfer begins

From: Rob Maris Signed-off-by: Rob Maris Signed-off-by: Barry Song Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 550aaf7..7882afc 100644 --- a/d

[PATCH 23/28] Blackfin SPI: reject unsupported SPI modes

Who knows what people will try! Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 18b313a..a91e556 100644 --- a/drivers/spi/spi_bfin5xx.c +++ b/driver

[PATCH 24/28] Blackfin SPI: fix typo in comment

From: Rob Maris Signed-off-by: Rob Maris Signed-off-by: Barry Song Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index a91e556..550aaf7 100644 --- a/dr

[PATCH 20/28] Blackfin SPI: reset ctl_reg bits when setup is run again on a device

During runtime, the spi setup function may be called multiple times on the same device in order to reconfigure some settings on the fly. When this happens, we need to reset the ctl_reg bits so that changing the mode works as expected. Reported-by: Andy Getzendanner Signed-off-by: Mike Frysinger

[PATCH 22/28] Blackfin SPI: use dma_disable_irq_nosync() in irq handler

From: Barry Song Using disable_irq() on the IRQ whose handler we are currently executing in can easily lead to a hang. So use the nosync variant here. Signed-off-by: Barry Song Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletion

[PATCH 19/28] Blackfin SPI: push all size checks into the transfer function

This reduces duplication between the setup/transfer functions and keeps values cached during setup from overriding values changed on a transfer basis (like bits_per_word). Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 57 +++-- 1 files ch

[PATCH 18/28] Blackfin SPI: use nosync when disabling the IRQ from the IRQ handler

From: Yi Li Using disable_irq() on the IRQ whose handler we are currently executing in can easily lead to a hang. So use the nosync variant here. Signed-off-by: Yi Li Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 15/28] Blackfin SPI: redo GPIO CS handling

From: Barry Song The common SPI layers take care of detecting CS conflicts and preventing two devices from claiming the same CS. This causes problems for the GPIO CS support we currently have as we are using CS0 to mean "GPIO CS". But if we have multiple devices using a GPIO CS, the common SPI

[PATCH 17/28] Blackfin SPI: sync hardware state before reprogramming everything

From: Barry Song Sometimes under load, the Blackfin core is able to send SPI register updates out before the controller is actually disabled. So when we go to reprogram the entire state (to switch to a different slave), make sure we sync after disabling the controller. Signed-off-by: Barry Song

[PATCH 09/28] Blackfin SPI: convert queue run state to true/false

No point in creating our own version of true/false defines when there is already a standard stdbool available to us. Reported-by: David Brownell Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 18 -- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a

[PATCH 16/28] Blackfin SPI: save/restore state when suspending/resuming

From: Barry Song We can't rely on the SPI_CTL/SPI_FLG registers retaining their state when suspending, so save/restore their entire values. Signed-off-by: Barry Song Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 17 + 1 files changed, 13 insertions(+), 4 dele

[PATCH 14/28] Blackfin: SPI: expand SPI bitmasks

Expand the BIT_CTL defines to use the naming convention of the hardware, and expand the masks to cover all documented bits. Signed-off-by: Mike Frysinger --- arch/blackfin/include/asm/bfin5xx_spi.h | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/blackfin/i

[PATCH 13/28] Blackfin SPI: use the SPI namespaced bit names

This lets us push the short SPI MMR bit names out of the global namespace. Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 09

[PATCH 11/28] Blackfin SPI: convert struct names to something more logical

The current structure names are a bit confusing as to what they represent, so use better names. Reported-by: David Brownell Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 100 ++-- 1 files changed, 50 insertions(+), 50 deletions(-) diff -

[PATCH 12/28] Blackfin SPI: drop extra memory we don't need

The driver that we based ours on uses a little extra memory behind the normal driver state, but we don't. So drop this useless bit of memory. Reported-by: David Brownell Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) d

[PATCH 10/28] Blackfin SPI: convert read/write/duplex funcs to a dedicated ops structure

Rather than having to look up the same 3 sets of functions at the same time, just use an ops structure so we only need to set one pointer. Reported-by: David Brownell Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 58 1 files changed

[PATCH 07/28] Blackfin SPI: punt useless null read/write funcs

The chip ops should always be initialized, so having null fallback functions are useless. Reported-by: David Brownell Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c | 47 1 files changed, 5 insertions(+), 42 deletions(-) diff --git a/

[PATCH 04/28] Blackfin SPI: utilize the SPI interrupt in PIO mode

From: Yi Li The current behavior in PIO mode is to poll the SPI status registers which can obviously lead to higher latencies when doing a lot of SPI traffic. There is a SPI interrupt which can be used instead to signal individual completion of transactions. Signed-off-by: Yi Li Signed-off-by:

[PATCH 01/28] Blackfin SPI: fix resources leakage

From: Daniel Mack Re-order setup() a bit so we don't leak memory/dma/gpio resources upon errors. Also make sure we don't call kfree() twice on the same object. Signed-off-by: Daniel Mack Signed-off-by: Bryan Wu Signed-off-by: Yi Li Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.

[PATCH 08/28] Blackfin SPI: fix up some unused/misleading comments

Reported-by: David Brownell Signed-off-by: Mike Frysinger --- drivers/spi/spi_bfin5xx.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c index 5e07f49..045c82a 100644 --- a/drivers/spi/spi_bfin5xx.c +++ b/driver

[PATCH 03/28] Blackfin SPI: force sane master-mode state at boot

From: Wolfgang Muees We should make sure the SPI controller is in a sane state in case the boot loader left it in a crappy state. Such as DMA pending which causes interrupts to fire on us. When setting a sane initial state, do not default to slave mode. If we do, then the SPI peripheral may im

[PATCH 06/28] Blackfin SPI: drop custom cs_change_per_word support

As David points out, the cs_change_per_word option isn't standard, nor is anyone actually using it. So punt all of the dead code considering it makes up ~10% of the code size. Reported-by: David Brownell Signed-off-by: Mike Frysinger --- arch/blackfin/include/asm/bfin5xx_spi.h |1 - driver

[PATCH 05/28] Blackfin SPI: fix CS handling

From: Barry Song The CS helper functions were toggling both the Flag Enable and the Flag Value bits, but the Flag Value bit is ignored if the corresponding Flag Enable bit is cleared. So under high speed transactions, the CS sometimes would not toggle properly. Since it makes no sense to toggle

[PATCH 00/28] Blackfin SPI updates for 2.6.36

Quite a bit here, but these patches have been around for a while. The reason they haven't been pushed up before was that some of the first changes introduced known bugs themselves and needed some manual fixing. Also, while some files touch Blackfin headers in arch/blackfin/, I'd like to keep them

[PATCH 02/28] Blackfin SPI: work around anomaly 05000119

From: Sonic Zhang Anomaly 05000119 states that the DMA_RUN bit with peripherals isn't reliable. However, the way the driver is currently written (DMA IRQ callback), we don't need the polling in the first place, so drop it. Signed-off-by: Sonic Zhang Signed-off-by: Mike Frysinger --- drivers/

[SPAM] Votre complementaire sante offerte pendant 2 mois

-- Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platfo

Re: [PATCH v4 5/5] mtd: m25p80: add support to parse the partitions by OF node

On Sat, 2010-10-16 at 19:05 -0600, Grant Likely wrote: > On Sat, Oct 16, 2010 at 1:17 PM, Artem Bityutskiy wrote: > > On Tue, 2010-10-12 at 18:18 +0800, Mingkai Hu wrote: > >> Signed-off-by: Mingkai Hu > >> Acked-by: Grant Likely > >> --- > >> v4: > >> - Updated to latest kernel base(Linux 2.6.