Re: [PATCH 3/3] SPI: spi_sh_msiof: fix wrong address calculation, which leads to an Oops

2011-01-21 Thread Paul Mundt
On Fri, Jan 21, 2011 at 09:27:43AM -0700, Grant Likely wrote: > On Fri, Jan 21, 2011 at 04:56:47PM +0100, Guennadi Liakhovetski wrote: > > NULL + != NULL, but reading from that address > > is usually not a very good idea and often leads to problems, like kernel > > Oopses in this case, easily rep

From United Kingdom(Read)

2011-01-21 Thread Jones de Lloyd
Beech Jones de Lloyd Solicitors The Old Bank, 56 Shrewsbury Road, Prenton, Wirral, CH43 2HY Hello, I work with Beech Jones de Lloyd Solicitors in the United Kingdom. I got your contact through Public Sector Information. There is a possibility that you may be related to my late client a nation

Re: [PATCH] Renaming 'struct flash_platform_data' into 'struct spi_flash_platform_data' in include/linux/spi/flash.h

2011-01-21 Thread Grant Likely
On Tue, Nov 23, 2010 at 10:55:08AM +0100, Alexis RODET wrote: > Hi baruch, > > I hope this time every thing is OK. Hi Alexis, Patch doesn't apply. Looks like it's whitespace damaged (tabs converted to spaces). Did you try to cut & paste it? git send-email is a more reliable way to post patche

Re: [PATCH 1/3] SPI: spi_sh_msiof: cosmetic clean-up

2011-01-21 Thread Grant Likely
On Fri, Jan 21, 2011 at 06:10:50PM +0100, Guennadi Liakhovetski wrote: > On Fri, 21 Jan 2011, Grant Likely wrote: > > > On Fri, Jan 21, 2011 at 04:56:37PM +0100, Guennadi Liakhovetski wrote: > > > 1. sort headers alphabetically > > > 2. use fixed-size types u8, u16, u32 for register values and tra

Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

2011-01-21 Thread Grant Likely
On Tue, Jan 11, 2011 at 06:38:35PM +0900, Tomoya MORINAGA wrote: > Hi Grant, > > On Friday, January 07, 2011 6:22 PM, Milton Miller wrote: > > follow mfd_add_devices into drivers/mfd/mfd-core.c > I have also seen mfd-core.c. > However, I couldn't clear my question. > > Q1. It seems platform_devic

Re: [PATCH 1/3] SPI: spi_sh_msiof: cosmetic clean-up

2011-01-21 Thread Guennadi Liakhovetski
On Fri, 21 Jan 2011, Grant Likely wrote: > On Fri, Jan 21, 2011 at 04:56:37PM +0100, Guennadi Liakhovetski wrote: > > 1. sort headers alphabetically > > 2. use fixed-size types u8, u16, u32 for register values and transferred > > data > > 3. simplify some arithmetic operations > > 4. remove leadi

Re: [PATCH 2/3] SPI: spi_sh_msiof: consolidate data in 8-bit mode into 32-bit words

2011-01-21 Thread Grant Likely
On Fri, Jan 21, 2011 at 04:56:42PM +0100, Guennadi Liakhovetski wrote: > Instead of sending data 8 bits at a time in 8-bit SPI mode, swap bytes > and send and receive them 32 bits at a time. Tested with an SD-card, > with which this patch reduced the number of interrupts by 50%, when > reading 5MiB

Re: [PATCH 1/3] SPI: spi_sh_msiof: cosmetic clean-up

2011-01-21 Thread Grant Likely
On Fri, Jan 21, 2011 at 04:56:37PM +0100, Guennadi Liakhovetski wrote: > 1. sort headers alphabetically > 2. use fixed-size types u8, u16, u32 for register values and transferred data > 3. simplify some arithmetic operations > 4. remove leading spaces in front of labels There's actually good reaso

Re: [PATCH 3/3] SPI: spi_sh_msiof: fix wrong address calculation, which leads to an Oops

2011-01-21 Thread Grant Likely
On Fri, Jan 21, 2011 at 04:56:47PM +0100, Guennadi Liakhovetski wrote: > NULL + != NULL, but reading from that address > is usually not a very good idea and often leads to problems, like kernel > Oopses in this case, easily reproducible by writing to an SD-card, used in > SPI mode. > > Signed-of

[PATCH 3/3] SPI: spi_sh_msiof: fix wrong address calculation, which leads to an Oops

2011-01-21 Thread Guennadi Liakhovetski
NULL + != NULL, but reading from that address is usually not a very good idea and often leads to problems, like kernel Oopses in this case, easily reproducible by writing to an SD-card, used in SPI mode. Signed-off-by: Guennadi Liakhovetski --- drivers/spi/spi_sh_msiof.c |6 -- 1 files

[PATCH 2/3] SPI: spi_sh_msiof: consolidate data in 8-bit mode into 32-bit words

2011-01-21 Thread Guennadi Liakhovetski
Instead of sending data 8 bits at a time in 8-bit SPI mode, swap bytes and send and receive them 32 bits at a time. Tested with an SD-card, with which this patch reduced the number of interrupts by 50%, when reading 5MiB of data (there are also small service packets, the number of interrupts, produ

[PATCH 1/3] SPI: spi_sh_msiof: cosmetic clean-up

2011-01-21 Thread Guennadi Liakhovetski
1. sort headers alphabetically 2. use fixed-size types u8, u16, u32 for register values and transferred data 3. simplify some arithmetic operations 4. remove leading spaces in front of labels Signed-off-by: Guennadi Liakhovetski --- drivers/spi/spi_sh_msiof.c | 78 ++---

Re: [PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-21 Thread Jonas Bonn
Hi, > > >> +#ifdef CONFIG_OF > >> +static struct of_device_id oc_tiny_spi_match[] = { > >> + { > >> + .compatible = "opencores,oc_tiny_spi", > > > > If this is a soft core, then there should be a version number of some > > sort on the compatible value. Also, please use dash '-' instead

[PATCH v5 6/6] OMAP: runtime: McSPI driver runtime conversion

2011-01-21 Thread Govindraj.R
McSPI runtime conversion. Changes involves: 1) remove clock framework apis to use runtime framework apis. 2) context restore from runtime resume which is a callback for get_sync. 3) Remove SYSCONFIG(sysc) register handling (a) Remove context save and restore of sysc reg and remove soft rese

[PATCH v5 1/6] OMAP2420: hwmod data: Add McSPI

2011-01-21 Thread Govindraj.R
From: Charulatha V Update the omap2420 hwmod data with the McSPI info. Add a device attribute structure which will be used for passing number of chipselects from hwmod data. Add revision macros to be passed from rev field from hwmod. Signed-off-by: Charulatha V Signed-off-by: Govindraj.R Acked

[PATCH v5 4/6] OMAP4: hwmod data: Add McSPI

2011-01-21 Thread Govindraj.R
From: Benoit Cousson Update omap4 hwmod file with McSPI info. Signed-off-by: Benoit Cousson Signed-off-by: Charulatha V Signed-off-by: Govindraj.R Acked-by: Grant Likely --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 267 1 files changed, 267 insertions(+), 0

[PATCH v5 5/6] OMAP: devices: Modify McSPI device to adapt to hwmod framework

2011-01-21 Thread Govindraj.R
From: Charulatha V Cleans up all base address definitions for omap_mcspi and adapts the device registration and driver to hwmod framework. Changes involves: 1) Removing all base address macro defines. 2) Using omap-device layer to register device and utilizing data from hwmod data file for bas

[PATCH v5 3/6] OMAP3: hwmod data: Add McSPI

2011-01-21 Thread Govindraj.R
From: Charulatha V Update omap3 hwmod data file with McSPI info. Signed-off-by: Charulatha V Signed-off-by: Govindraj.R Acked-by: Grant Likely --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 280 1 files changed, 280 insertions(+), 0 deletions(-) diff --git a/

[PATCH v5 0/6] OMAP: McSPI: Hwmod adaptation + runtime conversion

2011-01-21 Thread Govindraj.R
Changes invloves: 1) Addition of hwmod data for omap2/3/4. 2) McSPI driver hwmod adaptation with cleanup of base address macros and using omap-device API's. 3) Runtime Conversion of McSPI driver. Changes from v4: --- 1) 4430 hwmod file alignment based on Benoit's co

[PATCH v5 2/6] OMAP2430: hwmod data: Add McSPI

2011-01-21 Thread Govindraj.R
From: Charulatha V Update the 2430 hwmod data file with McSPI info. Signed-off-by: Charulatha V Signed-off-by: Govindraj.R Acked-by: Grant Likely --- arch/arm/mach-omap2/omap_hwmod_2430_data.c | 219 1 files changed, 219 insertions(+), 0 deletions(-) diff --git