Uwe Kleine-König writes:
> On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > Shawn Guo writes:
> > > spi_imx_devtype_data has already been driver private data. There is
> > > really no need to make a copy in spi_imx_data. Instead, a reference
> > > pointer works per
On Sun, Jul 10, 2011 at 01:16:40AM +0800, Shawn Guo wrote:
> It copies gpio number passed via platform data embedded pointer into
> driver private data, so that we do not need to refer to this embedded
> pointer passed by platform data after probe function exits.
>
> Signed-off-by: Shawn Guo
> Cc
On Sun, Jul 10, 2011 at 01:16:38AM +0800, Shawn Guo wrote:
> The only difference between SPI_IMX_VER_0_7 and SPI_IMX_VER_0_4 is
> .config function. The patch uses cpu_is_mx35 (to be removed) as the
> temporary solution to consolidate functions spi_imx0_4_config and
> spi_imx0_7_config into mx31_co
On Sun, Jul 10, 2011 at 01:16:36AM +0800, Shawn Guo wrote:
> SPI_IMX_VER_0_0 covers i.mx21 and i.mx27. It makes more sense to
> use mx21 rather than mx27 to name SPI_IMX_VER_0_0 function and
> macro, since i.mx21 comes out ealier than i.mx27.
>
> Signed-off-by: Shawn Guo
> Cc: Uwe Kleine-König
Hi,
Shawn Guo writes:
> spi_imx_devtype_data has already been driver private data. There is
> really no need to make a copy in spi_imx_data. Instead, a reference
> pointer works perfectly fine.
>
You obviously overlooked, that the copy is done on purpose to keep
only the data that is actually n
Hi,
Shawn Guo writes:
> On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > Shawn Guo writes:
> > > spi_imx_devtype_data has already been driver private data. There is
> > > really no need to make a copy in spi_imx_data. Instead, a reference
> > > pointer works perfe
On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> Hi,
>
> Shawn Guo writes:
> > spi_imx_devtype_data has already been driver private data. There is
> > really no need to make a copy in spi_imx_data. Instead, a reference
> > pointer works perfectly fine.
> >
> You obviously overl
On Mon, Jul 11, 2011 at 09:15:34AM +0200, Lothar Waßmann wrote:
> Hi,
>
> Shawn Guo writes:
> > spi_imx_devtype_data has already been driver private data. There is
> > really no need to make a copy in spi_imx_data. Instead, a reference
> > pointer works perfectly fine.
> >
> You obviously overl
