Re: [PATCH 3/5] SPI: Add helper macro for spi_driver boilerplate

2011-11-23 Thread Lars-Peter Clausen
On 11/24/2011 01:13 AM, Ben Dooks wrote: > On Wed, Nov 16, 2011 at 10:12:54AM -0700, Grant Likely wrote: >> On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen wrote: >>> This patch introduces the module_spi_driver macro which is a convenience >>> macro >>> for SPI driver modules similar to modul

Re: [PATCH] SPI: fix build with CONFIG_SPI_FSL_ESPI=m

2011-11-23 Thread Kumar Gala
On Aug 23, 2011, at 3:49 AM, Jiri Slaby wrote: > On 08/23/2011 09:59 AM, Jiri Slaby wrote: >> When spi_fsl_espi is chosen to be built as a module, there is a build >> error because we test only CONFIG_SPI_FSL_ESPI in declaration of >> struct mpc8xxx_spi in drivers/spi/spi_fsl_lib.h. >> >> We nee

Re: [PATCH] spi: nuc900: Include linux/module.h

2011-11-23 Thread Paul Gortmaker
[[PATCH] spi: nuc900: Include linux/module.h] On 24/11/2011 (Thu 11:10) Axel Lin wrote: > Include linux/module.h to fix below build error: Looks fine to me ; I'll assume that this is going upstream via the nuc900 maintainer since the module split up is old news at this point in time. Thanks, Pa

[PATCH] spi: nuc900: Include linux/module.h

2011-11-23 Thread Axel Lin
Include linux/module.h to fix below build error: CC drivers/spi/spi-nuc900.o drivers/spi/spi-nuc900.c:484: error: 'THIS_MODULE' undeclared here (not in a function) drivers/spi/spi-nuc900.c:489: error: expected declaration specifiers or '...' before string constant drivers/spi/spi-nuc900.c

Re: [PATCH 3/5] SPI: Add helper macro for spi_driver boilerplate

2011-11-23 Thread Ben Dooks
On Wed, Nov 16, 2011 at 10:12:54AM -0700, Grant Likely wrote: > On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen wrote: > > This patch introduces the module_spi_driver macro which is a convenience > > macro > > for SPI driver modules similar to module_platform_driver. It is intended to > > be

Re: [PATCH spi-next] spi: add Broadcom BCM63xx SPI controller driver

2011-11-23 Thread Florian Fainelli
Hi Shubhrajyoti Le mardi 22 novembre 2011 09:26:07, Shubhrajyoti Datta a écrit : > Hi Florian, > > On Tue, Nov 22, 2011 at 1:46 AM, Florian Fainelli wrote: [snip] > > + bs->irq = irq; > > + bs->clk = clk; > > + bs->fifo_size = pdata->fifo_size; > > + > > + ret = request