Guenter Roeck wrote:
>
> Suspend and resume functions call spi_master_get() without matching
> spi_master_put(). The extra references are unnecessary and cause
> subsequent
> module unload attempts to fail. Drop the calls.
>
> Signed-off-by: Guenter Roeck
Acked-by: Kukjin Kim
(Cc'ed Mark Brow
On Wed, 2012-08-22 at 12:04 -0400, Matt Porter wrote:
> for querying of these types of limitations. Right now, the
> mmc driver implicitly knows that EDMA needs this restriction
> but it's something that should be queried before calling
> prep_slave().
that's something we need to add; exporting cha
Removes use of the DaVinci EDMA private DMA API and replaces
it with use of the DMA engine API.
Signed-off-by: Matt Porter
---
drivers/spi/spi-davinci.c | 292 -
1 file changed, 130 insertions(+), 162 deletions(-)
diff --git a/drivers/spi/spi-davinci
Removes use of the DaVinci EDMA private DMA API and replaces
it with use of the DMA engine API.
Signed-off-by: Matt Porter
---
drivers/mmc/host/davinci_mmc.c | 271
1 file changed, 82 insertions(+), 189 deletions(-)
diff --git a/drivers/mmc/host/davinci
Add a DMA engine driver for the TI EDMA controller. This driver
is implemented as a wrapper around the existing DaVinci private
DMA implementation. This approach allows for incremental conversion
of each peripheral driver to the DMA engine API. The EDMA driver
supports slave transfers but does not
Changes since v1:
- Add virt-dma support. Better error checks
and simplified descriptor handling.
- Fix support for multiple EDMA controllers
Tested on AM18x EVM with WL12xx on MMC1
Changes since v2:
- Set default Kconfig state to off
- Fix white
If the I2C bus master driver does not support the required functionality,
the driver returns -ENODEV. This causes a silent probe failure without error
message. Since the device has to be explicitly instantiated, and the user
should know the correct bus, this event really reflects an error condition
Dear Chris Ball,
> Hi,
>
> On Wed, Aug 22 2012, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut
> > Cc: Chris Ball
> > Cc: Shawn Guo
> > Cc: Mark Brown
> > Cc: Fabio Estevam
> > ---
> >
> > drivers/spi/spi-mxs.c |4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > dif
Hi,
On Wed, Aug 22 2012, Marek Vasut wrote:
> Signed-off-by: Marek Vasut
> Cc: Chris Ball
> Cc: Shawn Guo
> Cc: Mark Brown
> Cc: Fabio Estevam
> ---
> drivers/spi/spi-mxs.c |4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-
Signed-off-by: Marek Vasut
Cc: Chris Ball
Cc: Shawn Guo
Cc: Mark Brown
Cc: Fabio Estevam
---
drivers/spi/spi-mxs.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 331f600..c965cc6 100644
--- a/drivers/spi/spi-mxs.c
Add "clock-frequency" property, which allows configuring the SPI block's
base speed.
Signed-off-by: Marek Vasut
Cc: Chris Ball
Cc: Shawn Guo
Cc: Mark Brown
---
Documentation/devicetree/bindings/spi/mxs-spi.txt |4
drivers/spi/spi-mxs.c | 21 +
On Wed, Aug 22, 2012 at 07:32:30PM +0100, Mark Brown wrote:
> On Sat, Aug 18, 2012 at 09:06:27AM -0700, Guenter Roeck wrote:
> > This driver adds support for NXP SC18IS602/603 I2C to SPI bus bridge.
> >
> > Signed-off-by: Guenter Roeck
>
> Applied, thanks. One small thing:
>
> > +static int sc
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Op 21-08-12 20:43, Matt Porter schreef:
> Removes use of the DaVinci EDMA private DMA API and replaces it with use
> of the DMA engine API.
>
> Signed-off-by: Matt Porter
Runtime tested on hawkboard with 3.6.0-rc2 with rootfs on SD and running
bonni
On Wed, Aug 22, 2012 at 3:49 PM, Roland Stigge wrote:
> This patch adds device tree support to the spi-pl022 driver.
>
> Based on the initial patch by Alexandre Pereira da Silva
>
>
> Signed-off-by: Roland Stigge
> Acked-by: Alexandre Pereira da Silva
Reviewed-by: Linus Walleij
Yours,
Linu
On 22/08/12 20:59, Mark Brown wrote:
>> + if (of_machine_is_compatible("lantiq,ase"))
>> > + master->num_chipselect = 3;
>> > + else
>> > + master->num_chipselect = 6;
> This is very suspicious - why is this being done based on the machine
> rather than based
On Wed, Aug 22, 2012 at 3:49 PM, Roland Stigge wrote:
> Several SPI controller drivers have defined differently named properties for
> the number of chip selects. Now adding "num-cs" as a reference name for new
> bindings.
>
> Signed-off-by: Roland Stigge
Reviewed-by: Linus Walleij
Yours,
Li
On Wed, Aug 22, 2012 at 3:49 PM, Roland Stigge wrote:
> This patch adds the ability for the driver to control the chip select
> directly.
> This enables independence from cs_control callbacks. Configurable via
> platform_data, to be extended as DT in the following patch.
>
> Based on the initia
On Wed, Aug 22, 2012 at 12:37:18PM +, Hebbar, Gururaja wrote:
> On Wed, Aug 22, 2012 at 00:13:07, Porter, Matt wrote:
> > Add a DMA engine driver for the TI EDMA controller. This driver
> > is implemented as a wrapper around the existing DaVinci private
> > DMA implementation. This approach all
On Wed, Aug 22, 2012 at 10:29 PM, Mark Brown
wrote:
> On Wed, Aug 22, 2012 at 11:35:11AM +0530, Shubhrajyoti D wrote:
>> This patch does the following
>>
>> Calls the pm_runtime_* functions directly.
>> Remove the MOD_REG_BIT macro usage thereby removiing un-needed branch.
>> At remove dont use th
On Sunday, August 19, 2012 1:44 AM, Julia Lawall wrote:
> From: Julia Lawall
>
> Initialize return variable before exiting on an error path.
> Signed-off-by: Julia Lawall
>
> ---
> drivers/spi/spi-ep93xx.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-ep93xx.c b/
On Wed, Aug 22, 2012 at 09:09:26AM +0530, Vinod Koul wrote:
> On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote:
> > Add a DMA engine driver for the TI EDMA controller. This driver
> > is implemented as a wrapper around the existing DaVinci private
> > DMA implementation. This approach allows fo
On Wed, Aug 22, 2012 at 09:15:22AM +0530, Vinod Koul wrote:
> On Tue, 2012-08-21 at 14:43 -0400, Matt Porter wrote:
> > Removes use of the DaVinci EDMA private DMA API and replaces
> > it with use of the DMA engine API.
> >
> > Signed-off-by: Matt Porter
> > ---
>
> > + struct dma_slav
This patch adds device tree support to the spi-pl022 driver.
Based on the initial patch by Alexandre Pereira da Silva
Signed-off-by: Roland Stigge
Acked-by: Alexandre Pereira da Silva
---
Documentation/devicetree/bindings/spi/spi_pl022.txt | 15 +++
drivers/spi/spi-pl022.c
This patch adds the ability for the driver to control the chip select directly.
This enables independence from cs_control callbacks. Configurable via
platform_data, to be extended as DT in the following patch.
Based on the initial patch by Alexandre Pereira da Silva
Signed-off-by: Roland Stigge
Several SPI controller drivers have defined differently named properties for
the number of chip selects. Now adding "num-cs" as a reference name for new
bindings.
Signed-off-by: Roland Stigge
---
Documentation/devicetree/bindings/spi/spi-bus.txt |3 +++
1 file changed, 3 insertions(+)
---
On Wed, Aug 22, 2012 at 00:13:07, Porter, Matt wrote:
> Add a DMA engine driver for the TI EDMA controller. This driver
> is implemented as a wrapper around the existing DaVinci private
> DMA implementation. This approach allows for incremental conversion
> of each peripheral driver to the DMA engi
From: Julia Lawall
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when !=
On Tue, Aug 21, 2012 at 6:01 PM, Roland Stigge wrote:
> This patch adds device tree support to the spi-pl022 driver.
(...)
> --- linux-2.6.orig/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ linux-2.6/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -6,7 +6,22 @@ Required prop
On Tue, Aug 21, 2012 at 6:00 PM, Roland Stigge wrote:
> This patch adds the ability for the driver to control the chip select
> directly.
> This enables independence from cs_control callbacks. Configurable via
> platform_data, to be extended as DT in the following patch.
>
> Based on the initia
Julia Lawall wrote:
>
> From: Julia Lawall
>
> Initialize return variable before exiting on an error path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
On Wed, Aug 22, 2012 at 11:16 AM, Viresh Kumar wrote:
> On 19 August 2012 03:56, Linus Walleij wrote:
>> On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar
>> Isn't this one of those things that *have* to be #ifdef CONFIG_OF?
>>
>> Next iteration, remember to add Mark Brown on To: because je's taking
On 19 August 2012 03:56, Linus Walleij wrote:
> On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar
> wrote:
>
> > spi_register_master() calls of_register_spi_devices() to register spi
> devices.
> > This routine expects master->dev.of_node to be a valid pointer. This is
> > responsibility of master d
32 matches
Mail list logo