[PATCH] spi/pl022: Fix chipselects pointer computation

2012-09-03 Thread Roland Stigge
The new chip select handling via GPIO introduced a pointer computation bug: (int *) pl022 + sizeof(struct pl022) doesn't point to the data immediately after the actual struct pl022 (as was intended) but to a multiple of bytes after it because of the (int *) type. Replacing the kludgy poi

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-03 Thread Linus Walleij
On Sun, Sep 2, 2012 at 3:12 PM, shiraz hashim wrote: > Hi Linus, >> Yes that is why the allocation looks like this: >> >> + master = spi_alloc_master(dev, sizeof(struct pl022) + sizeof(int) * >> + platform_info->num_chipselect); >> > > The allocation is such

Re: [PATCH] spi/pl022: Fix chipselects pointer computation

2012-09-03 Thread Linus Walleij
On Mon, Sep 3, 2012 at 10:14 AM, Roland Stigge wrote: > The new chip select handling via GPIO introduced a pointer computation bug: > > (int *) pl022 + sizeof(struct pl022) > > doesn't point to the data immediately after the actual struct pl022 (as was > intended) but to a multiple of byt

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-03 Thread Linus Walleij
On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack wrote: > On 05.08.2012 21:12, Linus Walleij wrote: >> On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack wrote: >> Acked-by: Linus Walleij >>> >>> Ok, thanks. Mark, did the patches reach you this time? I think they >>> should go thru the SPI tree. >> >>

[PATCH] spidev_test.c: extend the spidev_test tool to read a command file

2012-09-03 Thread Jan Luebbe
Currently, spidev_test.c always sends hardcoded data to the device. By fetching this data from a file given as a parameter, one can test real devices. Signed-off-by: Jan Luebbe --- Documentation/spi/spidev_test.c | 73 +++ 1 file changed, 58 insertions(+), 1

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti D
Currently in omap2_mcspi_txrx_dma has the rx and the rx support interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call functions. While at it also remove the braces in the if statements which has only one line. Also fix ["foo * bar" to "foo

[PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti D
Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call the functions. While at it remove the braces in the if statements which has only one line. Also fix ["foo * bar" to "foo *b

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-03 Thread Shubhrajyoti
On Monday 03 September 2012 07:32 PM, Shubhrajyoti D wrote: > Currently in omap2_mcspi_txrx_dma has the rx I meant tx here will resend. please ignore this patch > and the rx support > interleaved. Make the rx related code in omap2_mcspi_rx_dma > and the tx related code omap2_mcspi_tx_dma and call

[SPAM] Is Your Wedge Obsolete?

2012-09-03 Thread Andy North
Do you want to play golf better? Is your wedge obsolete? We are so convinced that our F2 Wedge will allow you to play the best golf ever, that we guarantee it. **View the attached brochure to get more info on this radical wedge** I am convinced you can not shank this F2 wedge. This wedge will m

[PATCH] Revert "spi/doc: spi_master_put must be followed up by kfree"

2012-09-03 Thread Guenter Roeck
Actually, spi_master_put() after spi_alloc_master() must _not_ be followed by kfree(). The memory is already freed with the call to spi_master_put() through spi_master_class, which registers a release function. Calling both spi_master_put() and kfree() results in often nasty (and delayed) crashes e

[PATCH 4/4] mxs/spi: Rework the mxs_ssp_timeout to be more readable

2012-09-03 Thread Marek Vasut
Rework the mxs_ssp_timeout() function to make it a bit more readable and hopefully less error prone. Also, have only one successful exit from the function and one failing exit instead of two. Finally, discard the udelay() from this function altogether, as this tightloop is quick enough it's pointl

[PATCH 3/4] mxs/spi: Decrement the DMA/PIO border

2012-09-03 Thread Marek Vasut
This driver checks the length of transfer to be made and based on this information, either chooses to transfer data via DMA or PIO. Decrement this border further to gain better performace eg. during SPI flash writes. Empiric measurement shows that this gives extra 3kB/s write speed with a M25P80 f

[PATCH 0/4] mxs/spi: Fixes and improvements

2012-09-03 Thread Marek Vasut
I humbly present fixes for further issues found in the SPI driver for i.MX23/i.MX28. The first patch rectifies the handling of DMA chaining in the driver, hopefully this time it's correct. Sadly, documentation on this matter is missing. The further patches are mostly code improvements, cleanups a

[PATCH 1/4] mxs/spi: Fix issues when doing long continuous transfer

2012-09-03 Thread Marek Vasut
When doing long continuous transfer, eg. from SPI flash via /dev/mtd, the driver dies. This is caused by a bug in the DMA chaining. Rework the DMA transfer code so that this issue does not happen any longer. This involves proper allocation of correct amount of sg-list members. Also, this means pro

[PATCH 2/4] mxs/spi: Increment the transfer length only if transfer succeeded

2012-09-03 Thread Marek Vasut
The transfer function incremented (struct spi_message)->actual_length unconditionally, even if the transfer failed. Rectify this by incrementing this only if transfer succeeded. Signed-off-by: Marek Vasut Cc: Chris Ball Cc: Fabio Estevam Cc: Grant Likely Cc: Mark Brown Cc: Shawn Guo --- dri

Ne ratez pas la rentrée beauté : Une sélection jusqu'à -50 pourcent

2012-09-03 Thread Yves Rocher par Duano
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTE5MjM4JmM9NDgzNjEyJmQ9MjAxMi0wOS0wNCAwNjoyMDowMSZlPTEmaD0xOTIzNyZmPTE5MjM4Jmc9MTkyMzg= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT0xMyZiPTE5MjM4JmM9NDgzNjEyJm