[PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks

2012-10-03 Thread Florian Fainelli
The PM callbacks implemented by the spi-bcm63xx driver don't call spi_master_{resume,suspend}, fix that. Signed-off-by: Florian Fainelli flor...@openwrt.org --- drivers/spi/spi-bcm63xx.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-bcm63xx.c

[PATCH 1/3] spi/bcm63xx: remove driver version

2012-10-03 Thread Florian Fainelli
As Grant Likely reported, this does not make any sense in a mainline kernel remove that driver version string. Reported-by: Grant Likely grant.lik...@secretlab.ca Signed-off-by: Florian Fainelli flor...@openwrt.org --- drivers/spi/spi-bcm63xx.c |5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer()

2012-10-03 Thread Florian Fainelli
Calling bcm63xx_spi_check_transfer() with a NULL argument does not do anything useful that the core spi code is not doing already, remove this superfluous call. Signed-off-by: Florian Fainelli flor...@openwrt.org --- drivers/spi/spi-bcm63xx.c |7 --- 1 file changed, 7 deletions(-) diff

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-10-03 Thread Ulf Hansson
Hi Mark and Grant, Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe [PATCH 2/3] Revert spi/pl022: enable

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote: Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-10-03 Thread Ulf Hansson
Hi Mark, I will do a resend and include some explanation for the reverts in the cover-letter. Kind regards Ulf Hansson On 3 October 2012 15:55, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote: Heard from Linus Walleij that you

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 04:28:34PM +0200, Ulf Hansson wrote: I will do a resend and include some explanation for the reverts in the cover-letter. It'd be good if the explanation could be in the commit logs so that people reading history can understand things.

re: spi-gpio: allow operation without CS signal

2012-10-03 Thread Dan Carpenter
Hello Michael Buesch, The patch bfb9bcdbda9a: spi-gpio: allow operation without CS signal from Apr 2, 2009, leads to the following Clang warning: drivers/spi/spi-gpio.c:229:9: warning: comparison of constant 18446744073709551615 with expression of type 'unsigned int' is always true