Re: [PATCH] spi: tegra114: add spi driver

2013-02-21 Thread Peter De Schrijver
On Wed, Feb 20, 2013 at 06:25:13PM +0100, Stephen Warren wrote: > On 02/20/2013 06:26 AM, Laxman Dewangan wrote: > > On Wednesday 20 February 2013 06:41 PM, Mark Brown wrote: > >> * PGP Signed by an unknown key > >> > >> On Wed, Feb 20, 2013 at 05:59:03PM +0530, Laxman Dewangan wrote: > > +

Re: [PATCH V2] spi: tegra114: add spi driver

2013-02-21 Thread Stephen Warren
On 02/21/2013 12:10 AM, Laxman Dewangan wrote: > Add SPI driver for NVIDIA's Tegra114 SPI controller. This controller > is different than the older SoCs SPI controller in internal design as > well as register interface. Looks good. Just a couple of nits mentioned below, then, Reviewed-by: Stephen

[PATCH -next] spi: fix return value check in ce4100_spi_probe()

2013-02-21 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function platform_device_register_full() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/spi/spi-pxa2xx-pci.c | 4 ++-- 1 file changed, 2 insertion