Re: [PATCH] arm: mvebu: Add SPI flash on Armada XP-GP board

2013-02-05 Thread Andrew Lunn
> And don't forget to compile the SPI flash driver, CONFIG_MTD_M25P80=y Hi Ezequiel Maybe it makes sense to provide a patch to mvebu_defconfig to add CONFIG_MTD_M25P80=y ? Andrew -- Free Next-Gen Firewall Hardw

Re: [PATCH 0/2] ARM: mvebu: Add support for SPI controller in Armada 370/XP

2013-02-04 Thread Andrew Lunn
On Mon, Feb 04, 2013 at 01:51:20PM -0300, Ezequiel Garcia wrote: > Hi, > > This patchset adds support for the SPI controller > available in Armada 370 and Armada XP SoC. Hi Ezequiel Do any of the boards we have with mainline support have any devices on the SPI busses? Its hard to test otherwise.

Re: [PATCH] ARM: Kirkwood: Add SPI_CHPA and SPI_CPOL support to spi-orion

2012-12-10 Thread Andrew Lunn
Hi Jason I tested your patch to add SPI_CHPA and SPI_CPOL on a QNAP box which has SPI NAND. No problems seen. Tested-by: Andrew Lunn Andrew -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-06 Thread Andrew Lunn
On Fri, Jul 06, 2012 at 08:08:23PM +, Arnd Bergmann wrote: > On Thursday 05 July 2012, Andrew Lunn wrote: > > > I think the latter one needs to be > > > > > > +static int __initdata gpio1_irqs[4] = { > > > + IRQ_DOVE_HI

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
> Something completely different I just noticed in the original patch: > > > @@ -90,6 +74,27 @@ static void pmu_irq_handler(unsigned int irq, struct > > irq_desc *desc) > > } > > } > > > > +static int __initdata gpio0_irqs[4] = { > > + IRQ_DOVE_GPIO_0_7, > > + IRQ_DOVE_GPIO_8_15,

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
On Thu, Jul 05, 2012 at 04:14:50PM +0200, Sebastian Hesselbarth wrote: > On 07/05/2012 03:08 PM, Andrew Lunn wrote: > >The issue is knowing what IRQ number to use for the secondary > >interrupts. > > > >Orion use generic chip interrupts, both for the main interrupts

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
On Thu, Jul 05, 2012 at 02:58:01PM +0200, Thomas Petazzoni wrote: > Hello, > > Le Thu, 5 Jul 2012 11:48:24 +0200, > Andrew Lunn a ??crit : > > > The biggest problem i had, is the interaction between generic chip > > interrupts and irqdomain. There has been work to int

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
> > +Required properties > > +- compatible : Should be "marvell,orion-intc". > > +- #interrupt-cells: Specifies the number of cells needed to encode an > > + interrupt source. Supported value is <1>. > > +- interrupt-controller : Declare this node to be an interrupt controller. > > +- reg : Inter

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
Hi Thomas > Yes. I am not sure yet how to describe those in the DT, or even if it > is actually useful to describe them. Wouldn't it be simpler to just > leave to the user of the GPIO to use a GPIO that's appropriate for its > usage, i.e not use a GPO when input is needed? We assume the hardware

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
> I've looked at the datasheet for the 88F6281, and the GPIO registers > look fairly similar with Armada 370/XP, except that: > > * On 88F6281, there are two GPIO banks, while on Armada 370/XP it's a >continuous range of registers that control the GPIOs. But it can be >assimilated as one

Re: [PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-05 Thread Andrew Lunn
On Thu, Jul 05, 2012 at 11:02:51AM +0200, Thomas Petazzoni wrote: > Hello Andrew, > > Le Tue, 3 Jul 2012 16:22:34 +0200, > Andrew Lunn a ??crit : > > > Both IRQ and GPIO controllers can now be represented in DT. The IRQ > > controllers are setup first, an

Re: [PATCH v2 07/12] I2C: MV64XXX: Add Device Tree support

2012-07-04 Thread Andrew Lunn
On Wed, Jul 04, 2012 at 09:49:33PM +0200, Florian Fainelli wrote: > Hello Andrew, > > On Tuesday 03 July 2012 18:58:39 Andrew Lunn wrote: > > On Tue, Jul 03, 2012 at 05:59:13PM +0200, Florian Fainelli wrote: > > > Hello Andrew, > > > > > > On Tuesd

Re: [PATCH v2 08/12] Kirkwood: Add basic device tree support for QNAP TS219.

2012-07-03 Thread Andrew Lunn
On Tue, Jul 03, 2012 at 05:47:57PM +0200, Florian Fainelli wrote: > Hi Andrew, > > On Tuesday 03 July 2012 16:22:41 Andrew Lunn wrote: > > The two different variants of QNAP TS devices, varying by SoC, put the > > GPIO keys on different GPIO lines. Hence we need two d

Re: [PATCH v2 12/12] Crypto: CESA: Add support for DT based instantiation.

2012-07-03 Thread Andrew Lunn
On Tue, Jul 03, 2012 at 05:50:02PM +0200, Florian Fainelli wrote: > Hello Andrew, > > On Tuesday 03 July 2012 16:22:45 Andrew Lunn wrote: > > Based on work by Michael Waller and Jason Cooper. > > > > Added support for getting the interrupt number from DT. > >

Re: [PATCH v2 07/12] I2C: MV64XXX: Add Device Tree support

2012-07-03 Thread Andrew Lunn
On Tue, Jul 03, 2012 at 05:59:13PM +0200, Florian Fainelli wrote: > Hello Andrew, > > On Tuesday 03 July 2012 16:22:40 Andrew Lunn wrote: > > Extends the driver to get properties from device tree. Also extend the > > kirkwood DT support to supply the needed properties. &

Re: [PATCH v2 11/12] ARM: Kirkwood: Use DT to configure SATA device.

2012-07-03 Thread Andrew Lunn
On Tue, Jul 03, 2012 at 10:52:17AM -0400, Josh Coombs wrote: > On Tue, Jul 3, 2012 at 10:22 AM, Andrew Lunn wrote: > > Convert boards using DT, but the old way of configuring SATA to now > > use properties in there DT file. > > Andrew, should I be updating my GoFlex patch s

[PATCH v2 12/12] Crypto: CESA: Add support for DT based instantiation.

2012-07-03 Thread Andrew Lunn
Based on work by Michael Waller and Jason Cooper. Added support for getting the interrupt number from DT. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/crypto/mv_cesa.txt | 18 drivers/crypto/mv_cesa.c | 31 +--- 2

[PATCH v2 10/12] ATA: sata_mv: Add device tree support

2012-07-03 Thread Andrew Lunn
Add support for instantiating this driver from device tree, and add the necassary DT information to the kirkwood.dtsi file. This is based on previous work by Michael Walle and Jason Cooper. Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/ata/marvell.txt | 16 arch

[PATCH v2 11/12] ARM: Kirkwood: Use DT to configure SATA device.

2012-07-03 Thread Andrew Lunn
Convert boards using DT, but the old way of configuring SATA to now use properties in there DT file. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood-dns320.dts|5 + arch/arm/boot/dts/kirkwood-dns325.dts|5 + arch/arm/boot/dts/kirkwood-dreamplug.dts |5

[PATCH v2 09/12] ARM: Kirkwood: DTify the watchdog timer.

2012-07-03 Thread Andrew Lunn
Add device tree support to the Orion watchdog timer, and enable its use in the kirkwood devices using device tree. Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/watchdog/marvel.txt | 14 ++ arch/arm/boot/dts/kirkwood.dtsi |6

[PATCH v2 08/12] Kirkwood: Add basic device tree support for QNAP TS219.

2012-07-03 Thread Andrew Lunn
The two different variants of QNAP TS devices, varying by SoC, put the GPIO keys on different GPIO lines. Hence we need two different DT board descriptions, which share the same board-ts219.c file. Signed-off-by: Andrew Lunn Acked-by: Jason Cooper --- arch/arm/boot/dts/kirkwood-ts219-6281.dts

[PATCH v2 07/12] I2C: MV64XXX: Add Device Tree support

2012-07-03 Thread Andrew Lunn
Extends the driver to get properties from device tree. Also extend the kirkwood DT support to supply the needed properties. Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/i2c/mrvl-i2c.txt | 32 - arch/arm/boot/dts/kirkwood.dtsi| 13

[PATCH v2 06/12] ARM: kirkwood: use devicetree for SPI on dreamplug

2012-07-03 Thread Andrew Lunn
From: Michael Walle Use the device tree for the SPI driver and partition layout. Signed-off-by: Michael Walle Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood-dreamplug.dts | 29 + arch/arm/mach-kirkwood/board-dreamplug.c | 41

[PATCH v2 05/12] ARM: kirkwood: use devicetree for orion-spi

2012-07-03 Thread Andrew Lunn
From: Michael Walle Populate the devices with auxdata to set the device names which are used by clkdev to lookup the clocks. Signed-off-by: Michael Walle Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood.dtsi |9 + arch/arm/mach-kirkwood/board-dt.c |8 +++- 2

[PATCH v2 04/12] spi-orion: add device tree binding

2012-07-03 Thread Andrew Lunn
From: Michael Walle Signed-off-by: Michael Walle Signed-off-by: Andrew Lunn Acked-by: Jason Cooper --- Documentation/devicetree/bindings/spi/spi-orion.txt |5 + drivers/spi/spi-orion.c |9 + 2 files changed, 14 insertions(+) create mode 100644

[PATCH v2 03/12] spi-orion: remove uneeded spi_info

2012-07-03 Thread Andrew Lunn
From: Michael Walle This was formerly used to store the tclk value. This is now discovered using the clk API, rather than pass it as platform data. Signed-off-by: Michael Walle Acked-by: Jason Cooper Signed-off-by: Andrew Lunn --- drivers/spi/spi-orion.c |5 - 1 file changed, 5

[PATCH v2 01/12] ARM: Orion: DT support for IRQ and GPIO Controllers

2012-07-03 Thread Andrew Lunn
Both IRQ and GPIO controllers can now be represented in DT. The IRQ controllers are setup first, and then the GPIO controllers. Interrupts for GPIO lines are placed directly after the main interrupts in the interrupt space. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/arm/mrvl

[PATCH v2 00/12] IRQ, GPIO SPI, I2C, etc DTC support

2012-07-03 Thread Andrew Lunn
rqdomain support. The GPIO interrupts are also handled using an IRQ generic chip, thus a similar layering is made. This applies to both DT and none DT IRQ and GPIO controllers. White space problem as pointed out by Michael Walle have been corrected. Andrew Lunn (8): ARM: Orion: DT support for

[PATCH v2 02/12] SPI: Refactor spi-orion to use SPI framework queue.

2012-07-03 Thread Andrew Lunn
Replace the deprecated master->transfer with transfer_one_message() and allow the SPI subsystem handle all the queuing of messages. Signed-off-by: Andrew Lunn Acked-by: Linus Walleij --- drivers/spi/spi-orion.c | 209 ++- 1 file changed,

Re: [PATCH 7/9] I2C: MV64XXX: Add Device Tree support

2012-06-26 Thread Andrew Lunn
On Tue, Jun 26, 2012 at 03:03:56PM +0100, Ben Dooks wrote: > On 10/06/12 11:31, Andrew Lunn wrote: > >Extends the driver to get properties from device tree. Also extend the > >kirkwood DT support to supply the needed properties. > > > >Signed-off-by: Andrew Lun

Re: [PATCH 1/9] ARM: Kirkwood: Add interrupt controller support for DT boards

2012-06-14 Thread Andrew Lunn
On Thu, Jun 14, 2012 at 08:12:34AM +, Arnd Bergmann wrote: > On Sunday 10 June 2012, Andrew Lunn wrote: > > +static int __init kirkwood_add_irq_domain(struct device_node *np, > > + struct device_node > &

Re: [PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-14 Thread Andrew Lunn
On Wed, Jun 13, 2012 at 09:10:30PM +, Arnd Bergmann wrote: > On Sunday 10 June 2012, Andrew Lunn wrote: > > @@ -26,6 +26,11 @@ static struct of_device_id kirkwood_dt_match_table[] > > __initdata = { > > { } > > }; > > > > +struct of_dev_auxda

Re: [PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-12 Thread Andrew Lunn
> > + spi@10600 { > > + compatible = "marvell,orion-spi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + cell-index = <0>; > > + reg = <0x10600 0x28>; > > + status = "di

[PATCH 0/9] Kirkwood DT support For IRQ, SPI, I2C, GPIO

2012-06-11 Thread Andrew Lunn
onger needs. Andrew Lunn (5): ARM: Kirkwood: Add interrupt controller support for DT boards SPI: Refactor spi-orion to use SPI framework queue. I2C: MV64XXX: Add Device Tree support ARM: Kirkwood: Add DT support for GPIO controllers Kirkwood: Add basic device tree support for QNAP TS219. Mi

[PATCH 3/9] spi-orion: remove uneeded spi_info

2012-06-11 Thread Andrew Lunn
From: Michael Walle This was formerly used to store the tclk value. This is now discovered using the clk API, rather than pass it as platform data. Signed-off-by: Michael Walle Acked-by: Jason Cooper Signed-off-by: Andrew Lunn --- drivers/spi/spi-orion.c |5 - 1 file changed, 5

[PATCH 1/9] ARM: Kirkwood: Add interrupt controller support for DT boards

2012-06-11 Thread Andrew Lunn
Signed-off-by: Andrew Lunn --- .../devicetree/bindings/arm/mrvl/intc.txt | 20 ++ arch/arm/boot/dts/kirkwood.dtsi|9 arch/arm/mach-kirkwood/board-dt.c | 22 +++- 3 files changed, 50 insertions(+), 1

[PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-11 Thread Andrew Lunn
From: Michael Walle Populate the devices with auxdata to set the device names which are used by clkdev to lookup the clocks. Signed-off-by: Michael Walle Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood.dtsi |9 + arch/arm/mach-kirkwood/board-dt.c |8 +++- 2

[PATCH 2/9] SPI: Refactor spi-orion to use SPI framework queue.

2012-06-11 Thread Andrew Lunn
Replace the deprecated master->transfer with transfer_one_message() and allow the SPI subsystem handle all the queuing of messages. Signed-off-by: Andrew Lunn Acked-by: Linus Walleij --- drivers/spi/spi-orion.c | 209 ++- 1 file changed,

[PATCH 6/9] ARM: kirkwood: use devicetree for SPI on dreamplug

2012-06-11 Thread Andrew Lunn
From: Michael Walle Use the device tree for the SPI driver and partition layout. Signed-off-by: Michael Walle Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood-dreamplug.dts | 29 + arch/arm/mach-kirkwood/board-dreamplug.c | 41

[PATCH 7/9] I2C: MV64XXX: Add Device Tree support

2012-06-11 Thread Andrew Lunn
Extends the driver to get properties from device tree. Also extend the kirkwood DT support to supply the needed properties. Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/i2c/mrvl-i2c.txt | 35 +- arch/arm/boot/dts/kirkwood.dtsi| 13

[PATCH 4/9] spi-orion: add device tree binding

2012-06-11 Thread Andrew Lunn
From: Michael Walle Signed-off-by: Michael Walle Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/spi/spi-orion.txt |5 + drivers/spi/spi-orion.c |9 + 2 files changed, 14 insertions(+) create mode 100644 Documentation

[PATCH 9/9] Kirkwood: Add basic device tree support for QNAP TS219.

2012-06-11 Thread Andrew Lunn
The two different variants of QNAP TS devices, varying by SoC, put the GPIO keys on different GPIO lines. Hence we need two different DT board descriptions, which share the same board-ts219.c file. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/kirkwood-ts219-6281.dts | 21 +++ arch/arm

[PATCH 8/9] ARM: Kirkwood: Add DT support for GPIO controllers

2012-06-11 Thread Andrew Lunn
The GPIO controllers can now be described in DT. Origionally GPIO controllers were instantiated during IRQ setup. The origional none-DT code has been split out, and is only called if no DT GPIO controllers are found. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/gpio/mrvl-gpio.txt

Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated

2012-05-15 Thread Andrew Lunn
On Thu, May 10, 2012 at 09:24:55PM -0600, Grant Likely wrote: > On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij > wrote: > > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D wrote: > > > > > Currently the prepare/unprepare transfer are called unconditionally. > > > The assumption is that every

[PATCH] SPI: Refactor spi-orion to use SPI framework queue.

2012-05-09 Thread Andrew Lunn
Replace the deprecated master->transfer with transfer_one_message() and allow the SPI subsystem handle all the queuing of messages. Signed-off-by: Andrew Lunn --- Note: This patch depends on clk-next and clk-next-orion held by Mike Turquette and soon to be pushed upstream. So it may make se