On 26/06/12 15:10, Andrew Lunn wrote:
> On Tue, Jun 26, 2012 at 03:03:56PM +0100, Ben Dooks wrote:
>> On 10/06/12 11:31, Andrew Lunn wrote:
>>> Extends the driver to get properties from device tree. Also extend the
>>> kirkwood DT support to supply the needed proper
n + 1)
> + 10 *(frequency-m + 1) * 2
> +
> +Examples:
I'd really rather see this calculated at run-time, given some
systems can quite easily change their clocks.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethi
rs-Peter Clausen
>
> Acked-by: Grant Likely
I'm begining to think we need to make some of these driver and device
bits more generic... there seems to be so much similar but not quite
the same code.
--
Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/
it.
>
> This patch series moves the remaining users to the spi-gpio driver and
> then finally removes the driver.
>
> Compile tested only as I don't have access to the hardware.
I've not really got much in the way of access either, however the
series looks sane to me.
remove.
>
> Signed-off-by: Axel Lin
Acked-by: Ben Dooks
> ---
> drivers/spi/tle62x0.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/tle62x0.c b/drivers/spi/tle62x0.c
> index a393895..32a4087 100644
> --- a/drivers/spi/tle62x
On 20/12/10 03:50, Marc Reilly wrote:
> These patches add i2c support for the mc13xxx-core driver. This v3 improves
> the v2
> (http://lists.arm.linux.org.uk/lurker/message/20101215.214755.b6bae366.en.html)
> by splitting
> the driver up into core, spi and i2c files so that it can support one
>
Ben Gamari wrote:
> Bcc:
> Subject: GPIO chip select support in omap2_mcspi driver
>
> Hey,
>
> Recently I have been looking to use a BeagleBoard to drive several
> serial ADCs and DACs in a data acquisition and analysis setup. Unfortunately,
> the
> BeagleBoard is severely limited by the numbe
rename the module (instead of adding a rename of the .c file
to this patch). We expect most users are loading this via udev and thus
there should be no change to the userland configuration.
Signed-off-by: Ben Dooks
Signed-off-by: Simtec Linux Team
---
Index: b/drivers/spi/Makefile
I have a driver, drivers/spi/spi_s3c24xx.c in this case that I have
written an FIQ handler for which requires some assembly code. My attempts
at trying to change it so that I can build a single module with both the
C and ASM code linked together have not yet been a success.
The original makefile b
Andrew Morton wrote:
> On Thu, 13 Aug 2009 11:06:02 +0100
> Ben Dooks wrote:
>
>> Fix spello in the SPI documentation and fix the behaviour and bugs
>> in the spi_s3c24xx driver.
>>
>
> Do you think that any of these are needed in 2.6.31, or earlier?
The fo
Change the spi_s3c24xx driver to use dev_pm_ops to avoid the
following warning during probe:
Platform driver 's3c2410-spi' needs updating - please use dev_pm_ops
Signed-off-by: Ben Dooks
---
drivers/spi/spi_s3c24xx.c | 22 +-
1 file changed, 13 insertions(+), 9
The driver includes where it should be including
and also includes and without using anything
from these.
Signed-off-by; Ben Dooks
---
drivers/spi/spi_s3c24xx.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Index: b/drivers/spi/spi_s3c24xx.c
problem where we where directly setting up
registers in the setup call which meant we might overwrite the state of
an extant transfer.,
Signed-off-by: Ben Dooks
---
drivers/spi/spi_s3c24xx.c | 126 --
1 file changed, 89 insertions(+), 37 deletions
Since the changes to the bitbang driver, there is the possibility we
will be called with either the speed_hz or bpw values zero. We take
these to mean that the default values (8 bits per word, or maximum
bus speed).
Signed-off-by: Ben Dooks
---
Index: b/drivers/spi/spi_s3c24xx.c
Fix spelling of automatically in Documentation/spi/spi-summary.
Signed-off-by: Ben Dooks
---
Documentation/spi/spi-summary |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/Documentation/spi/spi-summary
===
--- a
requested one.
Signed-off-by: Ben Dooks
---
drivers/spi/spi_s3c24xx.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
Index: b/drivers/spi/spi_s3c24xx.c
===
--- a/drivers/spi/spi_s3c24xx.c 2009-07-14 13:56
Fix spello in the SPI documentation and fix the behaviour and bugs
in the spi_s3c24xx driver.
--
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integr
Change the use of (res->end - res->start) to use resource_size() to
get the size of the resource.
Signed-off-by: Ben Dooks
---
drivers/spi/spi_s3c24xx.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: b/drivers/spi/spi_s3c
On Tue, Aug 04, 2009 at 06:48:14PM +0530, arjun rath wrote:
> Hi all,
>
> I am working on XR20M1172 which is a two channel SPI uart with 64 byte
> FIFO.Currently i am working on S3C2450 Processor
> where it has given HSPI instead of SPI.And there is no link between spi.c
> file and hspi.c.And one
requested one.
Signed-off-by: Ben Dooks
---
drivers/spi/spi_s3c24xx.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
Index: b/drivers/spi/spi_s3c24xx.c
===
--- a/drivers/spi/spi_s3c24xx.c 2009-07-14 13:56
problem where we where directly setting up
registers in the setup call which meant we might overwrite the state of
an extant transfer.,
Signed-off-by: Ben Dooks
---
drivers/spi/spi_s3c24xx.c | 126 --
1 file changed, 89 insertions(+), 37 deletions
Some bugfixes and warning squashing for the SPI documentation
and the spi_s3c24xx driver.
--
Ben Dooks, Simtec Electronics
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify
Change the spi_s3c24xx driver to use dev_pm_ops to avoid the
following warning during probe:
Platform driver 's3c2410-spi' needs updating - please use dev_pm_ops
Signed-off-by: Ben Dooks
---
---
drivers/spi/spi_s3c24xx.c | 22 +-
1 file changed, 13 insert
The driver includes where it should be including
and also includes and without using anything
from these.
Signed-off-by; Ben Dooks
---
drivers/spi/spi_s3c24xx.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
Index: b/drivers/spi/spi_s3c24xx.c
Fix spelling of automatically in Documentation/spi/spi-summary.
Signed-off-by: Ben Dooks
---
Documentation/spi/spi-summary |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/Documentation/spi/spi-summary
===
--- a
Since the changes to the bitbang driver, there is the possibility we
will be called with either the speed_hz or bpw values zero. We take
these to mean that the default values (8 bits per word, or maximum
bus speed).
Signed-off-by: Ben Dooks
---
Index: b/drivers/spi/spi_s3c24xx.c
On Wed, Jan 07, 2009 at 12:56:19PM +, b...@fluff.org.uk wrote:
> A number of drivers in drivers/gpio return -ENODEV when confronted
> with missing setup parameters such as the platform data. However,
> returning -ENODEV causes the driver layer to silently ignore the
> driver as it assumes the p
the driver.
Signed-off-by: Ben Dooks
Index: linux.git3/drivers/gpio/max7301.c
===
--- linux.git3.orig/drivers/gpio/max7301.c 2008-10-22 09:50:45.0
+0100
+++ linux.git3/drivers/gpio/max7301.c 2009-01-07 12:37:46.0
On Mon, Oct 20, 2008 at 08:56:41AM -0700, Andrei Rylin wrote:
> Haavard,
> thanks for clarification about cs_change.
> I have another (hopefully last) question about atmel_spi driver.
> atmel_spi driver DMA-maps the buffers pointed to by spi_transfer.
> What are alignment and size requirements for
On Sun, Oct 19, 2008 at 09:24:36PM -0700, David Brownell wrote:
> From: David Brownell <[EMAIL PROTECTED]>
>
> Generalize the old at91rm9200 "bootstrap" bitbanging SPI master driver
> as "spi_gpio", so it works with arbitrary GPIOs and can be configured
> through platform_data. Such SPI masters s
SPI driver updates for 2.6.28.
Sorry, this is the third set, the previous one
missed a minor change to drivers/spi/spi_s3c24xx.c
that causes the patch to mis-compile.
--
Ben ([EMAIL PROTECTED], http://www.fluff.org/)
'a smiley only costs 4 bytes'
-
Change the spi_s3c2410 driver to use the generic gpio calls that
are now available.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-quilt1/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.27-quilt1.orig/drive
slave mode but the GPIO function
registers do not.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc1-quilt1/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.27-rc1-quilt1.orig/drivers/spi/spi_s3c24xx.c 2008-08-04
The spidev_to_sg() call in spi_s3c24xx_gpio.c was using the
wrong method to convert the spi device into the private data
for the driver. Fix this by using spi_master_get_devdata.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc7-quilt1/drivers/spi/spi_s3c24xx_
The spi master driver must have num_chipselect set to
allow the bus to initialise. Pass this through the
platform data.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc7-quilt2/arch/arm/mach-s3c2410/include/mach/spi-
The correct set of S3C24XX SPI driver updates.
--
Ben ([EMAIL PROTECTED], http://www.fluff.org/)
'a smiley only costs 4 bytes'
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coole
On Fri, Oct 10, 2008 at 11:03:44AM +0100, Ben Dooks wrote:
> SPI updates for S3C24XX SPI drivers
Sorry about that, this is the series that went to linux-arm-kernel.
--
Ben
Q: What's a light-year?
A: One-third less calories than a regu
Add LCD frame buffer support for AT2440EVB board.
Signed-off-by: Ramax Lo <[EMAIL PROTECTED]>
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
diff --git a/arch/arm/mach-s3c2440/mach-at2440evb.c
b/arch/arm/mach-s3c2440/mach-at2440evb.c
index aab014f..595fec5 100644
--- a/arch/arm/mach-
A common ADC driver to allow the hwmon and touchscreen
drivers to share the ADC block.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc9-s3c64xx-2/arch/arm/plat-s3c24xx/Kconfig
===
--- linux-2.6.27-rc9-s3c
Add Kconfig entries to allow more GPIO space to
be specified depending on the machine(s) selected.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.26-rc9-quilt2/arch/arm/mach-s3c2440/Kconfig
===
--- linux-2.6.
Change the spi_s3c2410 driver to use the generic gpio calls that
are now available.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc7-quilt2/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.27-rc7-quilt2.orig/d
Fix the name of the driver, as well as the fact we are not
passing the number of chipselects to the driver.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc7-quilt2/arch/arm/mach-s3c2412/mach-jive.c
===
---
The spi master driver must have num_chipselect set to
allow the bus to initialise. Pass this through the
platform data.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc7-quilt2/arch/arm/mach-s3c2410/include/mach/spi-
The spidev_to_sg() call in spi_s3c24xx_gpio.c was using the
wrong method to convert the spi device into the private data
for the driver. Fix this by using spi_master_get_devdata.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc7-quilt1/drivers/spi/spi_s3c24xx_
SPI updates for S3C24XX SPI drivers
--
Ben ([EMAIL PROTECTED], http://www.fluff.org/)
'a smiley only costs 4 bytes'
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux ba
Add a set of default pin configuration routines for
setting up the SPI gpio configuration when using the
hardware SPI driver.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc6-quilt4/arch/arm/plat-s3c24xx/K
Add SD/MMC support for AT2440EVB board.
Signed-off-by: Ramax Lo <[EMAIL PROTECTED]>
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
diff --git a/arch/arm/mach-s3c2440/mach-at2440evb.c
b/arch/arm/mach-s3c2440/mach-at2440evb.c
index f5e3c7f..ce18bc3 100644
--- a/arch/arm/mach-
slave mode but the GPIO function
registers do not.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc1-quilt1/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.27-rc1-quilt1.orig/drivers/spi/spi_s3c24xx.c 2008-08-04
Do not use __raw_readl on straight pointers. Change the
code to using 'u32 *' as we are only accessing kernel
RAM using phys_to_virt() to find where it is.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc6-quilt3/arch/arm/m
Ensure we __force the __iomem attribute off when we use
our minimal __raw_writel() implementation.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc6-quilt3/arch/arm/plat-s3c/include/plat/uncompress.h
===
---
Add GPIO support to the SM501 on the Simtec Anubis,
and then add the necessary updates for allowing the
two gpio I2C busses to be used.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.26-rc8-quilt3/arch/arm/mach-s3c2440/mach-an
On Fri, Sep 12, 2008 at 04:54:08PM -0700, David Brownell wrote:
> On Friday 12 September 2008, Andrew Morton wrote:
> > On Fri, 12 Sep 2008 09:44:13 -0700
> > David Brownell <[EMAIL PROTECTED]> wrote:
> >
> > > From: Ben Dooks <[EMAIL PROTECTED]>
>
, the exit function should be marked __devexit
in case the platform device is capable of being removed.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc2-quilt1/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.
slave mode but the GPIO function
registers do not.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.27-rc1-quilt1/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.27-rc1-quilt1.orig/drivers/spi/spi_s3c24xx.c 2008-08-04
On Thu, Jul 31, 2008 at 01:14:42AM -0700, David Brownell wrote:
> On Tuesday 29 July 2008, Ben Dooks wrote:
>
> > @@ -412,6 +428,26 @@ static int s3c24xx_spi_suspend(struct pl
> > {
> > struct s3c24xx_spi *hw = platform_get_drvdata(pdev);
> >
> > + /
Fix the bug in the spi_s3c24xx driver where it does
not reset the registers of the hardware when resuming
from suspend (this block has been reset over suspend).
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.26-quilt5/drivers/spi/spi_s3c
driven, there is the likelyhood that the
chip will be driving against the SPI slave device (not all SPI
devices tristate their MISO line when their chipselect is inactive)
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.26-quilt5/drivers/spi/spi_s3c
On Sun, Jul 27, 2008 at 07:44:34PM -0700, Andrew Morton wrote:
> On Sun, 27 Jul 2008 15:40:04 -0700 David Brownell <[EMAIL PROTECTED]> wrote:
>
> > From: Ben Dooks <[EMAIL PROTECTED]>
> >
> > The original "Pass the bus number we expect the S3C24XX SPI
On Thu, Jul 24, 2008 at 09:41:25AM +0200, Hans J. Koch wrote:
> On Wed, Jul 23, 2008 at 08:19:18PM +0100, Ben Dooks wrote:
> > On Wed, Jul 23, 2008 at 06:00:29PM +0100, Jonathan Cameron wrote:
> > > Dear All,
> > >
> > > The need for an industrialio s
On Thu, Jul 24, 2008 at 11:44:36AM +0200, Eric Piel wrote:
> Henrique de Moraes Holschuh schreef:
>> On Wed, 23 Jul 2008, Jonathan Cameron wrote:
>>> The subsystem is now in a functional state with a small set of drivers:
>>>
>>> Max1363 (supports numerous Maxim i2c ADC's) (tested with max1363 and
On Wed, Jul 23, 2008 at 06:00:29PM +0100, Jonathan Cameron wrote:
> Dear All,
>
> The need for an industrialio subsystem was discussed in
> http://lkml.org/lkml/2008/5/20/135
The name is really bad, this sounds like something for doing large
scale industrial process control.
> Firstly thanks to
On Wed, Jul 23, 2008 at 06:00:29PM +0100, Jonathan Cameron wrote:
> Dear All,
>
> The need for an industrialio subsystem was discussed in
> http://lkml.org/lkml/2008/5/20/135
>
> Firstly thanks to all the people who have contributed to the discussion
> of this in the past.
>
> In brief the inten
Are the s3c24xx patches in [1] going to be merged soon?
[1]
http://sourceforge.net/mailarchive/forum.php?thread_name=20080626095903.388812551%40fluff.org.uk&forum_name=spi-devel-general
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
--
Unite the MODULE_ALIAS() declaration with the rest of
the MODULE_* definitions.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.25-quilt3/drivers/spi/spi_s3c24xx.c
===
--- linux-2.6.25-quilt3.orig/drive
git commit 50f426b55d919dd017af35bb6a08753d1f262920
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.25-quilt3/include/asm-arm/arch-s3c2410/spi.h
===
--- linux-2.6.25-quilt3.orig/include/asm-arm/arch-s3c2410/spi.h 2008-04-18
11
These two patches are fixes for the s3c24xx spi
driver, the first one seems to have been lost in
the noise, the second is a module alias fix for
the driver.
The patches are suitable for inclusion as soon as
possible.
--
Ben ([EMAIL PROTECTED], http://www.fluff.org/)
'a smiley only costs 4 byt
git commit 50f426b55d919dd017af35bb6a08753d1f262920
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.25-quilt3/include/asm-arm/arch-s3c2410/spi.h
===
--- linux-2.6.25-quilt3.orig/include/asm-arm/arch-s3c2410/spi.h 2008-04-18
11
On Tue, May 27, 2008 at 07:00:56PM +0100, Jonathan Cameron wrote:
>
> >
> > The two drivers i've seen so far use the input subsystem to report
> > their data to the user. I'm working on an driver for the SMB380 which
> > can be both i2c and spi.
> Yes, the ST accel I'm using (LIS3L02DQ) is like th
On Wed, May 21, 2008 at 09:49:42AM -0400, Dmitry Torokhov wrote:
> On Tue, May 20, 2008 at 01:28:17PM +0200, Jean Delvare wrote:
> > Hi Jonathan,
> >
> > On Tue, 20 May 2008 11:04:01 +0100, Jonathan Cameron wrote:
> > > This email is basically a request for opinions on how and where such
> > > se
Pass the bus number we expect the S3C24XX SPI driver to attach
to via the platform data.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.25-rc8-spi/include/asm-arm/arch-s3c2410/spi.h
===
--- linux-2.6.25-rc8-sp
The SPI core now expects num_chipselect to be set correctly as
due to added checks on the chip being selected before an
transfer is allowed. This patch adds a num_cs field to the
platform data which needs to be set correctly before adding
the SPI platform device.
Signed-off-by: Ben Dooks <[EM
These are fixes for the spi_s3c24xx driver, which
could be possibly applied before the 2.6.25 release.
--
Ben ([EMAIL PROTECTED], http://www.fluff.org/)
'a smiley only costs 4 bytes'
-
This SF.net email is sponsored by th
The s3c24xx_spi_txrx() function should initialise the completion
each time before using it, otherwise we end up with the possibility
of returning success before the interrupt handler has processed
all the data.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.24-quilt16/drive
On Mon, Jan 21, 2008 at 11:41:06PM -0800, David Brownell wrote:
> The two S3C SPI master drivers got merged without much review, so
> I just noticed that they're doing something that the SPI core code
> is responsible for, rather than any adapter driver: they try to
> register SPI devices.
>
> Th
Allow passing a bus number through the platform
data for the S3C2410 SPI GPIO driver
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
diff -urpN -X linux-2.6.24-rc3-spigpio1/Documentation/dontdiff
linux-2.6.24-rc3-spigpio1/include/asm-arm/arch-s3c2410/spi-gpio.h
linux-2.6.24-rc3-spigpio2/i
If we specify an GPIO which cannot be used for the
purpose, then assume that the GPIO is not to be used
and do not try and configure it. This can be the case
where the SPI bus is TX only.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
diff -urpN -X linux-2.6.24-rc3/Documentation/dontdiff
Fix the include files moved around during the
s3c24xx arch moves.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
diff -urpN -X linux-2.6.22-git16-moves1/Documentation/dontdiff
linux-2.6.22-git16-moves1/drivers/spi/spi_s3c24xx.c
linux-2.6.22-git16-moves1-fixups-split-moves2-fixup/drive
Add support for the Infineon TLE62x0 series of low-side driver
chips, such as the TLE6220 or TLE6230.
Signed-off-by: Ben Dooks <[EMAIL PROTECTED]>
Index: linux-2.6.22-rc4-simtec/include/linux/spi/tle62x0.h
===
--- /dev/null
78 matches
Mail list logo