flag.
Add SPI_CS_HIGH to the allowed modes.
Signed-off-by: Daniel Ribeiro
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drivers/spi/pxa2xx_spi.c
@@ -1482,7 +1482,7 @@
drv_data->ssp = ssp;
/* the spi->mode bits understood by this driver: */
- master->mode_bits = SPI_CPOL
setup() may fail before ctldata is set, causing a kernel panic on
cleanup().
Signed-off-by: Daniel Ribeiro
diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
index 885194a..2801307 100644
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drivers/spi/pxa2xx_spi.c
@@ -1373,6 +1373,9 @@ static
Commit a7bb3909b3293d503211d7f6af8ed62c1644b686 introduces chipselect
GPIO, and configures the CS polarity using SPI_CS_HIGH spi->mode flag,
but the SPI_CS_HIGH is not allowed by setup().
Signed-off-by: Daniel Ribeiro
diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
in
startup, but this is enough to get everything working
again.
Correct typo on pxa2xx-spi.c cs_deassert.
Signed-off-by: Daniel Ribeiro
diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
index 79d7341..1a00b41 100644
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drivers/spi/pxa2xx_spi
to deprecate cs_control?
--
Daniel Ribeiro
--
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu
If DMA is enabled, any spi_sync call after suspend/resume would block forever,
because DRCMR is lost on suspend. This patch restores DRCMR to the same values
set by probe.
Signed-off-by: Daniel Ribeiro
---
drivers/spi/pxa2xx_spi.c |7 +++
1 files changed, 7 insertions(+), 0 deletions
. So i think that
we really need to restore DRCMR on resume.
> Hopefully Dave, or someone else knowledgeable will speak up. Otherwise,
> go ahead with submitting the patch. And thanks for tracking this down.
Thank you for mentoring this! :)
I will submit the patch tomorrow morni
it has the same symptoms, i think it may be a different problem.
I discarded his fix proposal at the first debug run, because my SSP
registers are exactly what i expected on resume(), and exactly the same
as they were on suspend().
--
Daniel Ribeiro
--
DRCMR_RX=0084
RESUME DRCMR_TX= DRCMR_RX=
Should i cook a patch to store DRCMR on suspend and restore on resume?
Or is the proper fix something else?
--
Daniel Ribeiro
--
Apps built with the Adobe(R) F
il, but i think its worth to
inform you that with pm_test set to "core" i can suspend/resume just
fine. Its only when PXA is really put to sleep that pxa2xx-spi
misbehaves.
--
Daniel Ribeiro
--
Apps built with t
.26, I think.
>
Please, look carefully. I had a lot of work to get these debug messages
without the framebuffer, and with the kernel frozen. ;)
r...@a780:~# uname -a
Linux a780 2.6.29-rc5-ezx200902180753 #77 PREEMPT Wed Mar 11 07:20:29
BRT 2009 armv5tel unknown
--
get: W 1c00
pump_transfersA SSCR0=0010008f SSCR1=00380740 SSTO=0064 SSPSP=
SSSR=f024
pump_transfersB SSCR0=0010008f SSCR1=00380740 SSTO=0064 SSPSP=
SSSR=f024
>From my limited knowledge on this, it looks like there is no SSP
perip
re descriptive on "address the DMA"? Im not familiar on
what is the issue here.
I will take care of byte swapping for the next patch.
--
Daniel Ribeiro
-
This SF.Net email is sponsored by the Moblin Your Move Dev
this. Thanks!!
> - And the ADC sysfs support isn't supporting hwmon models.
>(Neither does the twl4030 ADC support, but that's not been
>submitted for mainline yet either...)
I will look into this after i finish the irq stuff.
This is a lot of stuff, thanks for the rev
>
> It's also worth removing the reverse dependencies ("select X")
> from Kconfig; they don't work very well for the things which
> those dependencies rely on.
Above comments are integrated on the attached patch.
--
Daniel Ribeiro
--- Begin Message ---
The PC
framework, along with
> a hwmon driver with its attributes being exported by sysfs.
The ADC is also used by the touchscreen driver, and later will be used
for accessory detection (usb otg, charger, EMU (audio and uart on usb
port)).
Currentl
m);
return spi_sync(pcap.spi, &m);
I noted that if i dont set .delay_usecs it gets a default huge value,
same with .speed_hz, it dont use spi_board_info->max_speed_hz as
default. Would calling spi_setup() on my driver init solve this? Or is
this yet another issue?
ore deasserting CS on PIO mode,
> 8/18/08
> pxa2xx_spi with SFRM, 8/7/08
I tested the patch regarding the CS problems, and it works fine.
Thanks Ned.
--
Daniel Ribeiro
-
This SF.Net email is sponsored by the Moblin Your
this transfer before changing
the chipselect status, then starting the next transfer
*or*completing*this*spi_message*"
I will be happy to submit a patch to change this if you think the
delay on DONE_STATE is acceptable.
--
Daniel Ribeiro
---
while(read_SSSR(reg) & SSSR_BSY) ;
Any of the above 3 blocking loops on the first line of
int_transfer_complete() fixes the problem. :)
(yes, TNF works too, because threshold = 1. ;) )
And finally, note that ssp_rx_stall() doesnt reads/discards any _data_
from the port as you cl
0123456
pcap_read: reg_num:3 value:00123456
Since the udelay(300) call works, and it doesnt touch the ssp registers,
it looks like int_transfer_complete is being called before it should.
--
Daniel Ribeiro
-
This SF.Net em
As it seems gmail web interface will not allow me to send an inline
patch. Here is
an attached version. Sorry.
--
Daniel Ribeiro
pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode
Signed-off-by: Daniel Ribeiro <[EMAIL PROTECTED]>
diff --git a/drivers/spi/pxa2xx_spi.c b/drive
.
--
Daniel Ribeiro
-- patch --
pxa2xx_spi: wait_rx_stall before deasserting CS on PIO mode
Signed-off-by: Daniel Ribeiro <[EMAIL PROTECTED]>
diff --git a/drivers/spi/pxa2xx_spi.c b/drivers/spi/pxa2xx_spi.c
index 0c452c4..4a9c34e 100644
--- a/drivers/spi/pxa2xx_spi.c
+++ b/drive
23 matches
Mail list logo
