Re: [PATCH] spi: spi-omap2-mcspi.c: fix coding style

2013-01-24 Thread Jarkko Nikula
r style 'spring cleanup'. I'm personally somewhere take as it or do nothing. If style is not terribly wrong I personally favor smaller style fixes when those lines are changing anyway. In case maintainer takes this you could add: Reviewed-by: Jarkko Nikula -- Jarkko ---

Re: [PATCH 3/3] spi: spi-omap2-mcspi.c: Toggle CS after each word

2013-01-23 Thread Jarkko Nikula
Hi On Wed, 23 Jan 2013 19:08:49 +0100 Matthias Brugger wrote: > @@ -1020,7 +1038,7 @@ static void omap2_mcspi_work(struct omap2_mcspi *mcspi, > struct spi_message *m) > } > > static int omap2_mcspi_transfer_one_message(struct spi_master *master, > -

Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-09-20 Thread Jarkko Nikula
ects, before calling any of the > probe functions of SPI devices? (Initializing the controller driver at > subsys_initcall is one way to accomplish this.) > As the N900 framebuffer still appears to be broken would it make sense to queue above change as a workaround for 3.5 and 3.6? Aaro: For

[PATCH-v2.6.39] spi/omap_mcspi: Fix broken last word xfer

2011-03-21 Thread Jarkko Nikula
"c >= 'pointer increment size'". This ensures that the last word is transmitted in above case and still allow to break the loop and prevent variable c underflow in cases where word size != 'pointer increment size'. Signed-off-by: Jarkko Nikula Cc: Michael Jones --- I