On Thu, Dec 06, 2012 at 06:53:11PM -0500, Jason Cooper wrote:
> On Thu, Dec 06, 2012 at 04:49:17PM -0700, Jason Gunthorpe wrote:
> > Jason: Do you have any of these possibly affected boards with a SPI
> > flash to test linux-next? dove, dreamplug, ts219 and lsxl
>
> Yep,
On Thu, Dec 06, 2012 at 11:23:05PM +, Grant Likely wrote:
> > This will likely switch all current users from using 'whatever the
> > firmware left behind' to 'whatever the kernel default is' - which will
> > surely break something here and there??
>
> Hmmm. Hard to say. Just the fact that exi
On Thu, Dec 06, 2012 at 02:25:21PM +, Grant Likely wrote:
> On Wed, 21 Nov 2012 12:23:35 -0700, Jason Gunthorpe
> wrote:
> > Support these transfer modes from the SPI layer by setting
> > the appropriate register bits before doing the transfer.
> >
> >
On Wed, Nov 21, 2012 at 02:35:52PM -0500, Jason Cooper wrote:
> > /* we support only mode 0, and no options */
> > - master->mode_bits = 0;
> > + master->mode_bits = SPI_CPHA | SPI_CPOL;
>
> The comment no longer seems valid. ;-) Also, you are unconditionally
> enabling these modes. Do
Support these transfer modes from the SPI layer by setting
the appropriate register bits before doing the transfer.
This was tested on the Marvell kirkwood SOC that uses this driver.
Reviewed-by: Jason Gunthorpe
Signed-off-by: Rolf Manderscheid
---
drivers/spi/spi-orion.c | 25
