Re: [RFC 23/42] drivers/spi: don't check resource with devm_ioremap_resource

2013-05-10 Thread Jingoo Han
-sfr_start' assignment as below: 1272 sdd-sfr_start = mem_res-start; Best regards, Jingoo Han irq = platform_get_irq(pdev, 0); if (irq 0) { dev_warn(pdev-dev, Failed to get IRQ: %d\n, irq); @@ -1318,6 +1312,7 @@ static int s3c64xx_spi_probe(struct

[PATCH 01/15] spi: altera: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-altera.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c index a537f8d..81b9adb 100644 --- a/drivers/spi/spi-altera.c +++ b/drivers/spi/spi-altera.c @@ -285,7 +285,6

[PATCH 02/15] spi: ath79: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-ath79.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index e504b76..6f6d455 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c @@ -287,7 +287,6

[PATCH 03/15] spi: au1550: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-au1550.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-au1550.c b/drivers/spi/spi-au1550.c index 44dd34b..39560f4 100644 --- a/drivers/spi/spi-au1550.c +++ b/drivers/spi/spi-au1550.c @@ -987,8 +987,6

[PATCH 04/15] spi: bcm63xx: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-bcm63xx.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c index a4ec5f4..099d083 100644 --- a/drivers/spi/spi-bcm63xx.c +++ b/drivers/spi/spi-bcm63xx.c @@ -469,7 +469,6

[PATCH 05/15] spi: bfin5xx: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-bfin5xx.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c index 317f564..68ca444 100644 --- a/drivers/spi/spi-bfin5xx.c +++ b/drivers/spi/spi-bfin5xx.c @@ -1418,9 +1418,6

[PATCH 06/15] spi: bfin-sport: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-bfin-sport.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-bfin-sport.c b/drivers/spi/spi-bfin-sport.c index 39b0d17..6d04c80 100644 --- a/drivers/spi/spi-bfin-sport.c +++ b/drivers/spi/spi-bfin-sport.c

[PATCH 07/15] spi: clps711x: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-clps711x.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-clps711x.c b/drivers/spi/spi-clps711x.c index a11cbf0..6859a02 100644 --- a/drivers/spi/spi-clps711x.c +++ b/drivers/spi/spi-clps711x.c @@ -254,7

[PATCH 08/15] spi: coldfire-qspi: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-coldfire-qspi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c index 7b5cc9e..3f17660 100644 --- a/drivers/spi/spi-coldfire-qspi.c +++ b/drivers/spi/spi

[PATCH 09/15] spi: dw-mmio: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-dw-mmio.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index 4a6d5c9..4aa8be8 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -111,8 +111,6

[PATCH 10/15] spi: ep93xx: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-ep93xx.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index d7bac60..8d4f2a6 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -1132,7 +1132,6

[PATCH 11/15] spi: spi-gpio: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-gpio.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c index 0021fc4..9672c7b 100644 --- a/drivers/spi/spi-gpio.c +++ b/drivers/spi/spi-gpio.c @@ -514,8 +514,6 @@ static int

[PATCH 12/15] spi: imx: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-imx.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 0befeeb..f4d7cac 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -902,7 +902,6 @@ out_gpio_free

[PATCH 13/15] spi: oc-tiny: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-oc-tiny.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-oc-tiny.c b/drivers/spi/spi-oc-tiny.c index e60a776..58deb79 100644 --- a/drivers/spi/spi-oc-tiny.c +++ b/drivers/spi/spi-oc-tiny.c @@ -368,7 +368,6

[PATCH 14/15] spi: pxa2xx: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-pxa2xx.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index f5d84d6..5a7fa2c 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1299,9 +1299,6

[PATCH 15/15] spi: s3c64xx: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-s3c64xx.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 5000586..5f3759d 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1399,7 +1399,6

Re: [PATCH 01/15] spi: altera: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
On Friday, May 03, 2013 4:08 PM, Grant Likelywrote: On Fri, May 3, 2013 at 7:48 AM, Jingoo Han jg1@samsung.com wrote: The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure

[PATCH V2] spi: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Jingoo Han
-by: Jingoo Han jg1@samsung.com --- Changes since v1: - squashed all patches into a single patch drivers/spi/spi-altera.c|2 -- drivers/spi/spi-ath79.c |2 -- drivers/spi/spi-au1550.c|2 -- drivers/spi/spi-bcm63xx.c |3 --- drivers/spi/spi-bfin-sport.c

[PATCH] spi/s3c64xx: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-21 Thread Jingoo Han
: 's3c64xx_spi_suspend' defined but not used [-Wunused-function] drivers/spi/spi-s3c64xx.c:1381:12: warning: 's3c64xx_spi_resume' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-s3c64xx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions

[PATCH] spi: s3c64xx: fix checkpatch warnings and error

2013-01-30 Thread Jingoo Han
Fix checkpatch warnings and error as below: ERROR: foo * bar should be foo *bar WARNING: please, no space before tabs WARNING: quoted string split across lines WARNING: msleep 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt Signed-off-by: Jingoo Han jg1

[PATCH v2] spi: s3c64xx: Use devm_clk_get() and devm_request_irq()

2013-01-09 Thread Jingoo Han
Use devm_clk_get() and devm_request_irq() rather than clk_get() and request_irq() to make cleanup paths more simple. Signed-off-by: Jingoo Han jg1@samsung.com --- Changes since v1: - modified the commit message drivers/spi/spi-s3c64xx.c | 41 +++-- 1

[PATCH] spi: s3c64xx: Use devm_clk_get() and devm_request_irq()

2013-01-08 Thread Jingoo Han
The devm_ functions allocate memory that is released when a driver detaches. This patch uses devm_clk_get() and devm_request_irq() for these functions. These make the code smaller and a bit simpler. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/spi/spi-s3c64xx.c | 41