Re: [PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-24 Thread Jonas Bonn
Hi Thomas, > > Versioning of OpenCores cores is not sorted yet. In order to avoid > > clashing with the versioning/naming scheme that's decided on, please > > just use a neutral version number for now (especially as your core is so > > new). e.g. "opencores,tiny-spi-0" > > > > Thanks. I will up

Re: [PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-21 Thread Jonas Bonn
Hi, > > >> +#ifdef CONFIG_OF > >> +static struct of_device_id oc_tiny_spi_match[] = { > >> + { > >> + .compatible = "opencores,oc_tiny_spi", > > > > If this is a soft core, then there should be a version number of some > > sort on the compatible value. Also, please use dash '-' instead