On Wed, Jul 18, 2012 at 12:09:54AM +0200, Marek Vasut wrote:
> > On Mon, Jul 16, 2012 at 02:09:47PM +0200, Marek Vasut wrote:
> > Always CC maintainers, and in this case me as well (I'm collecting SPI
> > patches for this release since Grant's mostly offline).
> Ah, I wasn't aware you're the SPI
On Mon, Jul 16, 2012 at 02:09:47PM +0200, Marek Vasut wrote:
> This patchset adds SPI master support for Freescale i.MX233/i.MX28.
> This is rebased on top of next-20120713. Please consider applying,
> bugs shall now be squashed during the previous two review rounds.
Always CC maintainers, and in
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote:
> The set_level callback in the controller data, which is used to configure
> the slave select line, cannot be supported when migrating the driver to
> device tree based discovery. Since all the platforms currently use gpio
> as the sl
On Thu, Jul 05, 2012 at 09:45:40AM +0200, Uwe Kleine-K?nig wrote:
> On Thu, Feb 09, 2012 at 10:21:45PM +0100, Uwe Kleine-K?nig wrote:
> > The chip select line was configured as output with the initial value
> > being active explicitly. It was later deasserted during
> > spi_bitbang_setup() without
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index f4e2341
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drive
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index f4e2341..b7aeb5d 100644
--- a
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 12 -
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote:
> With the addition of platform specific driver data in the spi-s3c64xx
> driver, the device name of spi controllers are changed. Accordingly,
> update the device name of spi clocks instances.
This should've been squashed into the pat
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote:
> + s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1);
Shouldn't we just set the name in the struct platform_device rather than
requiring the machine to pass it through by hand?
---
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
> +- gpios: The gpio specifier for clock, mosi and miso interface lines (in no
> + particular order). The format of the gpio specifier depends on the gpio
> + controller.
This seems odd... This isn't a bitbanging controller, and s
On Sun, Apr 01, 2012 at 04:41:37PM +1000, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
To repeat what I've said on
system is updated so that it is
enabled for these users, this is likely to have no impact on practical
systems as probably at least one of these devices will be active and
cause AMBA to hold the supply on anyway.
Signed-off-by: Mark Brown
---
Updated to add the always_on constraint for db8500-p
uld be minimal since currently there are no mainline
systems which actually provide a vcore regulator so none need updating.
Signed-off-by: Mark Brown
---
RFC because there's some disagreement about this.
drivers/amba/bus.c | 42 +-
driver
nit is moved to before regmap init.
Reviewed-by: Mark Brown
though like I said it'd be good to get the rmw trace into regmap - if
it's useful to you here similar trace is probably going to be useful to
other users.
--
Commit 054ebc (spi: Compatibility with direction which is used in samsung
DMA operation) does not build as one hunk adds a brace to the first branch
of an if statement without adding at least the correspoding close. Remove
the unwanted brace.
Signed-off-by: Mark Brown
---
drivers/spi/spi
On Sun, Mar 11, 2012 at 12:50:18PM +0100, Wolfram Sang wrote:
> free, if this is desired. I think the regmap approach should have been tried
> before we go custom. sound/soc/codecs/ad193x.c might give an impression how
> regmap spi/i2c in one driver could look like.
There's a bunch of other examp
than __devinit so this usage isn't legal. Change the
annotation to __devinit to handle this.
Signed-off-by: Mark Brown
---
drivers/spi/spi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 909e303..0c833a9 100644
--- a/dr
Convert the s3c64xx driver to using the new message queue factored out of
the pl022 driver by Linus Walleij, saving us a nice block of code and
getting the benefits of improvements implemented in the core.
Signed-off-by: Mark Brown
---
Only lightly tested thus far. Linus, it'd be really
On Wed, Feb 01, 2012 at 04:52:14PM +0100, Frederic LAMBERT wrote:
> Yes, that seems simple said like that.
> It was thus more simple for me, at that time, to modify a specific driver
> for a specific port (Nios2), than to modify a core used by every one.
> Question of time, and confidence in my ow
On Wed, Feb 01, 2012 at 04:29:25PM +0100, Frederic LAMBERT wrote:
> > > To sumarize, I have a same code that works for the 3 architecture, the
> > > single difference being in the device name:
> > > /sys/proc/spi/drivers/at25/spi0.0/eeprom for Nios2
> > > dataBase.dat on Linux
> > > /dev/sdb on t
On Wed, Feb 01, 2012 at 03:53:00PM +0100, Frederic LAMBERT wrote:
> I wrote a piece of code that uses this nvSRAM as a persistent storage.
> This runs in a softcore embedded in an FPGA, in an equipment.
> The PC version of this application uses a simple file to emulate this
> behavior.
> The simul
On Wed, Feb 01, 2012 at 03:25:33PM +0100, Frederic LAMBERT wrote:
> > > Because this bus number is used to create the device name on
> > > /sys/bus/spi/..., name that the user app must know to work with.
> > Why must the user application know this? What is missing to allow the
> > application to
On Wed, Feb 01, 2012 at 03:01:53PM +0100, Frederic LAMBERT wrote:
Don't top post!
> Because this bus number is used to create the device name on
> /sys/bus/spi/..., name that the user app must know to work with.
Why must the user application know this? What is missing to allow the
application t
On Tue, Jan 31, 2012 at 04:54:06PM +0100, Tobias Klauser wrote:
> From: Frederic Lambert
>
> Until now we let the code in spi.c assign us the bus number if the platform
> device didn't specify its id. This patch adds the possibility to explicitely
> specify the bus number via device tree.
Why wo
On Thu, Jan 26, 2012 at 03:48:59PM +0100, Linus Walleij wrote:
> On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown wrote:
> > It really feels like we should be pulling this into the core - lots of
> > drivers use a workqueue to drive data through the system and they're all
>
On Tue, Jan 24, 2012 at 10:14:32PM +0100, Linus Walleij wrote:
> From: Chris Blair
>
> This switches the PL022 worker to a kthread in order to get
> hold of a mechanism to control the message pump priority. On
> low-latency systems elevating the message kthread to realtime
> priority give a real
On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote:
> On 01/21/2012 02:24 PM, Mark Brown wrote:
> > - int ret;
> > + int ret, irq;
> > + char clk_name[16];
> clk_name seems to be unused, otherwise looks good.
That's git cherry-pick being to
On Sat, Jan 21, 2012 at 07:27:23AM -0700, Grant Likely wrote:
> Pushed out to git://git.secretlab.ca/git/linux-2.6.git spi/merge.
> I'll ask Linus to pull in a couple of days after it has hit
> linux-next.
Thanks. Obviously it'd be nice to get it into 3.3 but I don't see a
huge rush and it did m
On Sat, Jan 21, 2012 at 02:41:59PM +0100, Bill Gatliff wrote:
> What about using autosuspend instead? If a client is doing a lot of
> closely-spaced SPI transactions on a relatively flat device tree,
> might the resulting runtime suspend/resume overhead between each
> transaction become noticeabl
In preparation for the addition of runtime PM ops.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index d56066b..56dbdf1 100644
--- a
Enable and disable the clocks to the SPI controller using runtime PM. This
serves the dual purpose of reducing power consumption a little and letting
the core know when the device is idle.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
Acked-by: Heiko Stuebner
---
drivers/spi/spi-s3c64xx.c
at present and this code is much simpler.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 57 +++-
1 files changed, 55 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
in
have got
dropped on the floor somewhere along the line.
Mark Brown (3):
spi/s3c64xx: Log error interrupts
spi/s3c64xx: Convert to dev_pm_ops
spi/s3c64xx: Implement runtime PM support
drivers/spi/spi-s3c64xx.c | 115
1 files changed
On Fri, Jan 20, 2012 at 06:55:35PM +1100, Marc Reilly wrote:
> On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote:
> > On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote:
> > > I've never looked at regmap deeply but can't it be done with regmap or
On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote:
> I've never looked at regmap deeply but can't it be done with regmap or is it
> just a bad idea ?
Glancing quickly at the existing code it should map on reasonably well,
though a new format definition may be required for the 25 bit s
On Mon, Dec 05, 2011 at 10:41:21PM +0100, Linus Walleij wrote:
> Just wanted to mention that I had this discussion with Magnus Damm
> about how they do this in shmobile: in there their central runtime PM
> policy in arch/arm/mach-shmobile/pm_runtime.c adds in the
> pm_clk_notifier from drivers/bas
Enable and disable the clocks to the SPI controller using runtime PM. This
serves the dual purpose of reducing power consumption a little and letting
the core know when the device is idle.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 39 +++
1
at present and this code is much simpler.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 56 +++-
1 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
in
In preparation for the addition of runtime PM ops.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 9b16406..d0c70f2 100644
--- a
Enable and disable the clocks to the SPI controller using runtime PM. This
serves the dual purpose of reducing power consumption a little and letting
the core know when the device is idle.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 39 +++
1
In preparation for the addition of runtime PM ops.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 9b16406..fef1c90 100644
--- a
at present and this code is much simpler.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 56 +++-
1 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index dcf7e10..9b16406 1006
at present and this code is much simpler.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 57 +++-
1 files changed, 55 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index dcf7e10..8172173 1006
On Thu, Jun 30, 2011 at 08:40:40PM +0300, Igor Grinberg wrote:
> On 06/30/11 19:13, Stanislav Brabec wrote:
> > Igor Grinberg wrote:
> >> I thought we've finished discussing the regulator issue...
> > The discussion ended without a fix (at least for spitz).
> Well, the discussion was mainly abou
On Thu, Jun 30, 2011 at 06:25:51PM +0300, Igor Grinberg wrote:
> On 06/30/11 17:45, Stanislav Brabec wrote:
> > from this thread. Without it, ADS7846 does not work on spitz (ADS7846
> > does not have any dedicated regulator there). I want to
> > add .needs_regulator bool to ads7846.c and send the
On Mon, May 30, 2011 at 12:57:57PM +0200, Antonio Ospite wrote:
> It is cleaner and more uniform indeed, but it does not solve the problem
> I am seeing, the issue is still there when pdata is NULL, we are at the
> same point as before (the current code checks for (pdata &&
> pdata->field)), and w
On Mon, May 30, 2011 at 11:07:49AM +0200, Antonio Ospite wrote:
> On Mon, 23 May 2011 17:10:23 +0200
> > +#define STRUCT_FIELD(s, f) ((s) && (s)->f ? (s)->f : NULL )
> Any opinion on this macro? See its use below. It is meant to deal with
> driver specific struct fields, which can have arbitrary
On Wed, May 18, 2011 at 07:23:20PM +0200, Antonio Ospite wrote:
> So you mean something like the following:
> mmc_regulator_set_power(...)
> {
Yes.
> 2. Add a proper function with all the needed parameters to abstract
> the actual var names, this would be something like:
> mmc_regul
On Wed, May 11, 2011 at 10:53:37PM +0200, Antonio Ospite wrote:
> OK, avoiding some duplication will be good, I agree.
> I am resending a v4 with the equivalent code:
>
> if (host->vcc) {
> int ret;
>
> if (power_mode == MMC_POWER_OFF)
> v
On Wed, May 11, 2011 at 12:39:39PM +0200, Antonio Ospite wrote:
> Add support for powering up SD cards driven by regulators.
> This makes the mmc_spi driver work also with the Motorola A910 phone.
>
> Signed-off-by: Antonio Ospite
Reviwed-by: Mark Brown
but
> + swi
Currently the simple SPI I/O operations all take pointers to u8 * buffers
to operate on. This creates needless type compatibility issues and the
underlying spi_transfer structure uses void pointers anyway so convert the
API over to take void pointers too.
Signed-off-by: Mark Brown
---
drivers
On Thu, Apr 21, 2011 at 02:27:53PM +0200, Antonio Ospite wrote:
> +#ifdef CONFIG_REGULATOR
> + host->vcc = regulator_get(mmc_dev(host->mmc), "vmmc");
> +
> + if (IS_ERR(host->vcc)) {
> + host->vcc = NULL;
> + } else {
> + host->mmc->ocr_avail = mmc_regulator_get
On Mon, Feb 14, 2011 at 11:21:34AM +0100, Philippe R?tornaz wrote:
> AFAIK the audio part of the mc13783 has still not been merged.
No, it hasn't. Sacha posted something ages ago but it had a lot of
problems and I've not seen any subsequent spins.
---
On Thu, Feb 03, 2011 at 03:04:32PM +, Alan Cox wrote:
> Mark Brown wrote:
> > I've got the same question here as I had with Russ' patch: it looks like
> > there's some overlap with the SSP ports used for audio (it's just a
> > generic programmable
On Wed, Feb 02, 2011 at 10:40:54PM +, Alan Cox wrote:
> And this is the unified one that handles all the devices, but I gather
> may need some fixing/test work on Medfield.
I've got the same question here as I had with Russ' patch: it looks like
there's some overlap with the SSP ports used fo
On Wed, Feb 02, 2011 at 01:01:52PM -0800, Russ Gorby wrote:
> SPI master controller driver for the Intel MID platform Medfield
> This driver uses the Penwell SSP controller and configures it to
> be a SPI device (spibus 3). This bus supports a single device -
> the 3G SPI modem that can operate up
fic suspend
> > > and resume functions will be called if a driver does not provide
> > > dev_pm_ops
> > > allowing for transition to the new model.
> > >
> > > Signed-off-by: Mark Brown
> > It looks good to me.
> I'll take that as an ac
Allow SPI drivers to use runtime PM and other dev_pm_ops features by
implementing dev_pm_ops for the bus. The existing bus specific suspend
and resume functions will be called if a driver does not provide dev_pm_ops
allowing for transition to the new model.
Signed-off-by: Mark Brown
---
This
On Mon, Dec 20, 2010 at 09:00:29PM +1100, Marc Reilly wrote:
> On Monday, December 20, 2010 07:31:20 pm Uwe Kleine-K?nig wrote:
> > This list isn't complete, but see below.
> Do you mean the list above is incomplete? I should have said "Changes to the
> struct _include_".
> I'm ignorant of "pat
On Fri, Dec 10, 2010 at 04:19:48PM -0800, Kevin Hilman wrote:
> [PATCH v7 08/12] gpio: add ti-ssp gpio driver
> David Brownell? (MAINTAINERS isn't clear here)
It's mostly abandoned at the minute. Andrew Morton has been taking
patches. Grant Likely said he might take it over so sending stuff hi
On Tue, Dec 07, 2010 at 09:51:56AM -0500, Cyril Chemparathy wrote:
> +static int set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV)
> +{
Updates in the regulator tree mean that this will no longer build in
-next. Given the difficulty that this series seems to be having
perhaps it wo
On Wed, Nov 24, 2010 at 08:30:37AM -0700, Grant Likely wrote:
> It would be easy enough to defer cpufreq initialization based on some
> platform defined criteria. It's just an initcall. However, I don't
Though it'd be much better to fix the thing where cpufreq doesn't have a
device anyway.
> k
On Wed, Nov 24, 2010 at 03:09:25PM +0100, Sebastian Andrzej Siewior wrote:
> I've been pointed out to this commit but I don't understand _why_.
> The part I don't get is "so it can be used with cpufreq". Is it
> refered to a driver or the subsystem as it?
We need the regulators for the CPU rails
On Sun, Nov 21, 2010 at 02:31:38PM -0700, Grant Likely wrote:
> On Sun, Nov 21, 2010 at 1:02 PM, Ryan Mallon wrote:
> > Currently the code will allow you to install
> > several peripherals at once, which will lead to odd behaviour at
> > runtime. Maybe a better approach would be to have something
On Wed, Nov 17, 2010 at 09:11:30AM -0700, Grant Likely wrote:
> To start, I'm not a fan of matching by name. It's fragile because it
> makes assumptions about how devices will be names when they actually
> appear (ie. Sometimes .id is dynamically assigned). Ideally I'd
> prefer to have direct re
On Tue, Nov 16, 2010 at 07:17:18PM -0500, Cyril Chemparathy wrote:
> The ability to wait on multiple devices may come handy. In this
This is essential for any helpers, otherwise we can't cope easily with
mixes of GPIO and power or with regulators from multiple chips (like an
extra DCDC, for exam
On Tue, Nov 16, 2010 at 01:45:54PM -0700, Grant Likely wrote:
> On Tue, Nov 16, 2010 at 11:34:09AM +0000, Mark Brown wrote:
> > You did also say you were going to write helpers to make this easier - I
> > do fear that we're going to end up with far too much boiler plate
On Tue, Nov 16, 2010 at 12:47:04AM -0700, Grant Likely wrote:
> On Tue, Nov 16, 2010 at 12:22 AM, Grant Likely
> > Instead, it is now incumbent on the board support code to ensure that
> > any device that depends on another device (including i2c or spi
> > regulators) will defer registration until
On Mon, Oct 18, 2010 at 03:25:16PM -0400, Cyril Chemparathy wrote:
> TPS6524X provides three step-down converters and two general-purpose LDO
> voltage regulators. This device is interfaced using SPI.
>
> Signed-off-by: Cyril Chemparathy
Acked-by
On Thu, Oct 14, 2010 at 02:38:49PM -0400, Cyril Chemparathy wrote:
> TPS6524X provides three step-down converters and two general-purpose LDO
> voltage regulators. This device is interfaced using SPI.
>
> Signed-off-by: Cyril Chemparathy
My review comments from the previous posting do not appea
On Thu, Oct 14, 2010 at 02:38:49PM -0400, Cyril Chemparathy wrote:
> TPS6524X provides three step-down converters and two general-purpose LDO
> voltage regulators. This device is interfaced using SPI.
>
> Signed-off-by: Cyril Chemparathy
This looks mostly good but...
> +static int read(struct
On Thu, Oct 14, 2010 at 02:38:50PM -0400, Cyril Chemparathy wrote:
> + {
> + .num_consumer_supplies = ARRAY_SIZE(usb_consumers),
> + .consumer_supplies = usb_consumers,
> + .constraints= {
> + .name = "USB",
>
On Wed, Sep 08, 2010 at 10:44:32AM -0600, Grant Likely wrote:
> On Wed, Sep 08, 2010 at 05:22:51PM +0100, Mark Brown wrote:
> > Doing dependencies could get pretty complicated, especially once you
> > handle optional dependencies ("is this missing because it didn't prob
On Wed, Sep 08, 2010 at 10:12:45AM -0600, Grant Likely wrote:
[reflowed into 80 columns]
> ... but it seems to me that there is a systemic problem in the way the
> driver model is being used if SPI (and I2C) bus drivers need to be
> 'special' in this regard. What are the ordering requirements on
On Wed, Sep 08, 2010 at 01:55:39PM +0900, Jassi Brar wrote:
> On Tue, Sep 7, 2010 at 7:29 PM, Mark Brown
> wrote:
> > Allow the use of the S3C64xx SPI controller with things like PMICs by
> > moving the init up to subsys_initcall().
> Couldn't any user ever need to lo
On Wed, Sep 08, 2010 at 10:11:59AM +0900, Jassi Brar wrote:
> I have already submitted a patch a few days ago
> https://patchwork.kernel.org/patch/151941/
> (It's strange that Grant's id isn't there in the CC list, despite my writing
> it)
Ah, excellent. Now I see patchwork there look to be som
10ms.
Signed-off-by: Mark Brown
---
drivers/spi/spi_s3c64xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
index 03b28e4..4abb441 100644
--- a/drivers/spi/spi_s3c64xx.c
+++ b/drivers/spi/spi_s3c64xx.c
@@ -326,7
ister readback.
Also warn when we hit the timeout.
Signed-off-by: Mark Brown
---
drivers/spi/spi_s3c64xx.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
index 6e48ea9..03b28e4 100644
--- a/drivers/spi/spi_s3c6
Allow the use of the S3C64xx SPI controller with things like PMICs by
moving the init up to subsys_initcall().
Signed-off-by: Mark Brown
---
Incidentally I don't seem to see anything in the current SPI tree for
-next - should the tree being used be updated or something?
driver
When using PIO we have a timeout for the TX and RX FIFOs to ensure that
the data actually gets transferred. Warn if we hit that timeout - it
should never happen, but this makes sure we'll find out if it does.
Signed-off-by: Mark Brown
---
drivers/spi/spi_s3c64xx.c |6 ++
1 files ch
On Sun, Aug 22, 2010 at 12:37:25PM +0900, Jassi Brar wrote:
> An immediate kernel crash ? :)
> I mean if the developer didn't even run-check the board init code, he ought
> to face a kernel crash.
> On a more lenient note, probably a check like yours or !sci->num_cs
> could be added.
I'd personal
On Sat, Aug 21, 2010 at 10:58:36PM +0900, Jassi Brar wrote:
> On Sat, Aug 21, 2010 at 7:08 PM, Mark Brown
> > On Sat, Aug 21, 2010 at 10:45:56AM +0900, Jassi Brar wrote:
> >> The movement of sci assignment and check doesn't make any
> >> difference because
On Sat, Aug 21, 2010 at 10:45:56AM +0900, Jassi Brar wrote:
> On Sat, Aug 21, 2010 at 1:17 AM, Mark Brown
> wrote:
> > The S3C64xx SPI driver requires the machine to call s3c64xx_spi_set_info()
> > to select a few options, including the clock to use for the SPI controller.
>
Signed-off-by: Mark Brown
---
drivers/spi/spi_s3c64xx.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
index a0b63b7..7e627f7 100644
--- a/drivers/spi/spi_s3c64xx.c
+++ b/drivers/spi/spi_s3c64xx.c
@@ -447,8
configuration by validating that the clock name has been filled in in
the platform data that ets passed in.
Signed-off-by: Mark Brown
---
drivers/spi/spi_s3c64xx.c |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
101 - 187 of 187 matches
Mail list logo
