://www.spinics.net/lists/linux-samsung-soc/msg32282.html
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Doug Anderson
Cc: Tomasz Figa
---
This change is being reviewed @
http://www.mail-archive.com/devicetree@vger.kernel.org/msg
s SPI flash.
This patchset is needed by the changes
http://www.gossamer-threads.com/lists/linux/kernel/1951607
Tested-by on boards based on Exynos4, S5P, S3C series SoCs
would be appreciated.
Naveen Krishna Chatradhi (3):
spi: s3c64xx: move property "cs-gpio" from controller_data su
This patch validates the cs->line (Chip select gpio) and
struct s3c64xx_spi_csinfo *cs object for both DT and NON-DT
platforms before using in .setup().
Also, check gpio_is_valid(spi->cs_gpio) in cleanup() before
freeing up.
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Ca
3c64xx.c can use spi->cs_gpio
instead of parsing the property in the driver.
Update the dt-bindings ion spi/spi-samsung.txt
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Cc: Javier Martinez Canillas
Cc: Doug Anderson
Cc: Tomasz Figa
---
This patch is a rework of the chan
://www.spinics.net/lists/linux-samsung-soc/msg32282.html
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Doug Anderson
Cc: Tomasz Figa
---
Changes since v5:
None
Changes since v4:
1. Added reviewed by from Javier and Doug.
2. Maintai
d of "cs-gpio" defined in
slaves "controller-data"(child) node.
Also, fixes a compilation warning and corrects the DTS nodes for
Exynos4210 based SMDKv310, Exynos4412 based Trats2, Exynos5250 based
SMDK5250 boards.
Changes since v5:
1. Fixed the "making a GPIO chip select ma
Use controller_data structure only for the Non Device tree platforms.
For Device tree platforms, always derive the chipselect info from
DT node.
Signed-off-by: Naveen Krishna Chatradhi
Reviewed-by: Javier Martinez Canillas
Tested-by: Doug Anderson
---
Changes since v5:
None
Changes since v4
he breakage.
We are assuming it is safe to remove the "cs-gpio"(singular) usage
from device tree binding of spi-samsung.txt and makes appropriate
changes in the driver to use "cs-gpios"(plural) from
SPI device node.
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herrin
Use controller_data structure only for the Non Device tree platforms.
For Device tree platforms, always derive the chipselect info from
DT node.
Signed-off-by: Naveen Krishna Chatradhi
Reviewed-by: Javier Martinez Canillas
Tested-by: Doug Anderson
---
Changes since v4:
1. Added reviewed by
://www.spinics.net/lists/linux-samsung-soc/msg32282.html
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Doug Anderson
Cc: Tomasz Figa
---
Changes since v4:
1. Added reviewed by from Javier and Doug.
2. Maintained the "status"
he breakage.
We are assuming it is safe to remove the "cs-gpio"(singular) usage
from device tree binding of spi-samsung.txt and makes appropriate
changes in the driver to use "cs-gpios"(plural) from
SPI device node.
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
://www.spinics.net/lists/linux-samsung-soc/msg32282.html
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Cc: Javier Martinez Canillas
Cc: Doug Anderson
Cc: Tomasz Figa
---
arch/arm/boot/dts/exynos4210-smdkv310.dts |2 +-
arch/arm/boot/dts/exynos4412-trats2.dts |2 +-
arch/ar
Use controller_data structure only for the Non Device tree platforms.
For Device tree platforms, always derive the chipselect info from
DT node.
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Canillas
Cc: Doug Anderson
Cc: Tomasz Figa
---
drivers/spi/spi-s3c64xx.c | 11
he breakage.
We are assuming it is safe to remove the "cs-gpio"(singular) usage
from device tree binding of spi-samsung.txt and makes appropriate
changes in the driver to use "cs-gpios"(plural) from
SPI device node.
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herrin
d of "cs-gpio" defined in
slaves "controller-data"(child) node.
Also updates the Device tree Documentation.
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Cc: Javier Martinez Canillas
Cc: Doug Anderson
Cc: Tomasz Figa
---
Changes since v2:
1. updated the gp
This patch moves the "cs-gpio" field from "controller-data" child
node to under the spi device node.
Respective changes are preposed to spi-s3c64xx.c driver.
Signed-off-by: Naveen Krishna Chatradhi
Acked-by: Rob Herring
Cc: Javier Martinez Canillas
Cc: Doug Ander
d of "cs-gpio" defined in
slaves "controller-data"(child) node.
Also updates the Device tree Documentation.
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Canillas
Cc: Doug Anderson
---
Changes since v1:
1. fixed a compilation warning thus squashing the
This patch moves the "cs-gpio" field from "controller-data" child
node to under the spi device node.
Respective changes are preposed to spi-s3c64xx.c driver.
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Canillas
Cc: Doug Anderson
---
Changes since v1:
None
d of "cs-gpio" defined in
slaves "controller-data"(child) node.
Also, fixes a compilation warning and corrects the DTS nodes for
Exynos4210 based SMDKv310, Exynos4412 based Trats2, Exynos5250 based
SMDK5250 boards.
Naveen Krishna Chatradhi (2):
based on for-next branch of spi.git
This patch makes the changes in spi-s3c64xx.c driver to make use of
"cs-gpios" from SPI node(parent) instead of "cs-gpio" defined in
slaves "controller-data"(child) node.
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Canillas
Cc: Doug Anderson
d of "cs-gpio" defined in
slaves "controller-data"(child) node.
Also, fixes a compilation warning and corrects the DTS nodes for
Exynos4210 based SMDKv310, Exynos4412 based Trats2, Exynos5250 based
SMDK5250 boards.
Naveen Krishna Chatradhi (3):
based on for-next branch of spi
This patch moves the "cs-gpio" field from "controller-data" child
node to under the spi device node.
Respective changes are preposed to spi-s3c64xx.c driver.
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Canillas
Cc: Doug Anderson
---
arch/arm/boot/dts/exy
This patch returns an integer error value instead of the
pointer.
"warning: return makes integer from pointer without a cast"
Signed-off-by: Naveen Krishna Chatradhi
Cc: Javier Martinez Canillas
Cc: Doug Anderson
---
drivers/spi/spi-s3c64xx.c |2 +-
1 file changed, 1 inser
part of the driver
data. This fixes a SPI driver suspend crash.
Signed-off-by: Abhilash Kesavan
Signed-off-by: Naveen Krishna Chatradhi
---
This was tested on spi-next branch
http://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git
With S2R patches submitted on mailing list.
http
24 matches
Mail list logo