Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Nishanth Menon
I chips. > Here are some ancient documentation for the same (pre-device tree) world[1] bindings documentation is available: Documentation/devicetree/bindings/arm/omap/omap.txt [1] http://omapedia.org/wiki/HWMOD -- Regards, Nishanth Menon

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Nishanth Menon
On 15:40-20130709, Mark Brown wrote: > On Tue, Jul 09, 2013 at 07:50:55AM -0500, Nishanth Menon wrote: > > > with this input and looking closer, I think I see what you are saying now: > > dra7xxx_qspi_prepare_xfer -> does a pm_runtime_get_sync > > dra7xxx_qs

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Nishanth Menon
On 07/09/2013 01:51 AM, Felipe Balbi wrote: > On Mon, Jul 08, 2013 at 03:33:30PM -0500, Nishanth Menon wrote: >>> +static int dra7xxx_qspi_start_transfer_one(struct spi_master *master, >>> + struct spi_message *m) >>> +{ >>> + struct dra7xxx_qsp

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Nishanth Menon
s spinlocks and is fairly fast. But, I agree, when the client of regmap uses locks to protect operations of their own, regmap might be a bit of an overhead. that said, replicating regmap logic in the driver looks a bit weird and might allow the basis for other drivers to do the same as well as some

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-08 Thread Nishanth Menon
goto free_master; > + } > + > + qspi->fclk = devm_clk_get(&pdev->dev, "fck"); > + if (IS_ERR(qspi->fclk)) { > + ret = PTR_ERR(qspi->fclk); > + dev_err(&pdev->dev, "could not get clk: %d\n", ret); > +

Re: [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support

2013-01-10 Thread Nishanth Menon
On 15:49-20130110, Matt Porter wrote: > On Thu, Jan 10, 2013 at 01:46:53PM -0600, Nishanth Menon wrote: > > On 14:35-20130110, Matt Porter wrote: > > > On Sun, Oct 28, 2012 at 05:01:29PM +0530, Sekhar Nori wrote: > > > > On 10/18/2

Re: [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support

2013-01-10 Thread Nishanth Menon
in the cover letter. Anybody that needs context of > how/what worked and was tested can grab them there. Possibly dumb question: Cant we have pre-usable spi configurations? Like spi1_configuration1_pins, spi2_configuration1_pins, spi0_configuration1_pins? If documented with P9 pin names in the