Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

2012-06-24 Thread Olof Johansson
Hi, (Adding Linus Walleij and Mark Brown since they were the ones doing the queue changes). On Fri, Jun 22, 2012 at 4:53 PM, Bryan Freed wrote: > spi_pump_messages() calls into a controller driver with > unprepare_transfer_hardware() which is documented as "This may sleep". > As in the prepare_t

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Olof Johansson
On Sun, May 20, 2012 at 2:21 AM, Mark Brown wrote: > On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote: > >> -     s3c64xx_spi0_set_platdata(&s3c64xx_spi0_pdata, 0, 1); >> +     s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1); > > ... > >> +     pd.src_clk_nr = src_clk_nr; >> +  

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-30 Thread Olof Johansson
Hi, Some comments below. On Tue, May 8, 2012 at 3:04 PM, Thomas Abraham wrote: > Platform data is used to specify controller hardware specific information > such as the tx/rx fifo level mask and bit offset of rx fifo level. Such > information is not suitable to be supplied from device tree. Inst

[PATCH] spi/tegra: depend instead of select TEGRA_SYSTEM_DMA

2011-12-22 Thread Olof Johansson
It's unlikely that anyone ever wants to turn off SYSTEM_DMA, but just in case, it makes more sense to have the driver depend on it than select it. Signed-off-by: Olof Johansson --- drivers/spi/Kconfig |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/spi/Kc

Re: [PATCH 1/2] gpio/tegra: Move Tegra gpio driver to drivers/gpio

2011-06-15 Thread Olof Johansson
On Wed, Jun 15, 2011 at 12:37 PM, Grant Likely wrote: > As part of the gpio driver consolidation, this patch moves the Tegra driver > into drivers/gpio > > Signed-off-by: Grant Likely Acked-by: Olof Johansson Colin said he had plans to do it, or I would already have sent this out

Re: [PATCH 2/2] gpio/tegra: add devicetree support

2011-06-15 Thread Olof Johansson
On Wed, Jun 15, 2011 at 12:38 PM, Grant Likely wrote: > Add support for decoding gpios from the device tree > > Signed-off-by: Grant Likely Acked-by: Olof Johansson -- EditLive Enterprise is the wor