Re: [PATCH 1/3] spi/qspi: Add memory mapped read support.

2013-10-09 Thread Peter Korsgaard
here we could conceivable do something else useful while waiting on the spi controller. But if there's number to prove otherwise.. -- Bye, Peter Korsgaard -- October Webinars: Code for Performance Free Intel webina

Re: [PATCH v3] gpio: mcp23s08: convert driver to DT

2013-03-25 Thread Peter Korsgaard
any significant work on that driver since David.. -- Bye, Peter Korsgaard -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-12 Thread Peter Korsgaard
nterrupt-parent should be removed from the example as well to >> match am33xx.dtsi Matt> On second thought, I'm not sure we're going to get any direction Matt> on this one so let's just do what feels right and mak

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-06 Thread Peter Korsgaard
t; + Matt> +edma: edma@4900 { Matt> +reg = <0x4900 0x1>; Matt> +interrupt-parent = <&intc>; Matt> +interrupts = <12 13 14>; Probably interrupt-parent should be removed from the example as well to match am33xx.dtsi --

Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-03-03 Thread Peter Korsgaard
nted that way from day one. Grant> xfer_complete and xfer_complete_wq can be dropped, and Grant> child_mesg_complete, child_mesg_context and child_mesg_dev will move Grant> into struct spi_mux_gpio. Thanks. We weren't quite sure ab

Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-03-02 Thread Peter Korsgaard
>>>>> "MB" == Mark Brown writes: MB> On Sat, Mar 02, 2013 at 11:43:58AM +0100, Peter Korsgaard wrote: MB> This looks wrong without a vendor name in it but I'm not sure what we're MB> supposed to do for generic stuff like this. >> It's a

Re: [PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-03-02 Thread Peter Korsgaard
LE(of, spi_mux_gpio_of_match); MB> This looks wrong without a vendor name in it but I'm not sure what we're MB> supposed to do for generic stuff like this. It's atleast in line with what we do elsewhere (spi-gpio, i2c-gpio, i2c-mux-gpio, ..) -- Bye, Peter Korsgaard DI

[PATCH] spi: Driver for GPIO controlled SPI multiplexer

2013-02-27 Thread Peter Korsgaard
From: Dries Van Puymbroeck This patch contains a driver for a gpio controlled multiplexer on an SPI bus. This can be useful if a board requires more SPI devices, and thus more chip selects, than the SPI controller on the processor has available. The mux device is added in the device tree as a ch

Re: [PATCH] spi: omap2-mcspi: Fix the redifine warning

2012-11-19 Thread Peter Korsgaard
327:12: originally declared Shubhrajyoti> here Shubhrajyoti> So delete the u8 tx as it is assigned and not Shubhrajyoti> used(resigned afterwards). Shubhrajyoti> Signed-off-by: Shubhrajyoti D Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard -

Re: [PATCH resend] SPI: McSPI: fix D0/D1 direction confusion

2012-11-13 Thread Peter Korsgaard
ers, hence also breaking the Daniel> former default behaviour. Daniel> Fix this before that change is merged to mainline. Daniel> Signed-off-by: Daniel Mack Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard --

Re: [PATCH] SPI: McSPI: fix D0/D1 direction confusion

2012-11-13 Thread Peter Korsgaard
ers, hence also breaking the Daniel> former default behaviour. Daniel> Fix this before that change is merged to mainline. Daniel> Signed-off-by: Daniel Mack Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard --

Re: [PATCH 0/5] remove spi-s3c24xx-gpio driver

2011-06-29 Thread Peter Korsgaard
d by both the Grant> spi and samsung trees. Both is fine by me. Let me know if you want me to do something. -- Bye, Peter Korsgaard -- All of the data generated in your IT infrastructure is seriously valuable.

Re: [PATCH 0/5] remove spi-s3c24xx-gpio driver

2011-06-29 Thread Peter Korsgaard
er, however the Ben> series looks sane to me. Ben> Acked-by: Ben Dooks Great, will you handle the series or should it go through the spi tree? -- Bye, Peter Korsgaard -- All of the data generated in your IT infr

[PATCH 3/5] mach-gta2: remove unused spi-gpio.h include

2011-06-28 Thread Peter Korsgaard
Not needed, and the file is going away. Signed-off-by: Peter Korsgaard --- arch/arm/mach-s3c2440/mach-gta02.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c2440/mach-gta02.c b/arch/arm/mach-s3c2440/mach-gta02.c index 7166620..c10ddf4 100644 --- a

[PATCH 0/5] remove spi-s3c24xx-gpio driver

2011-06-28 Thread Peter Korsgaard
ch-gta02.c|1 - drivers/spi/Kconfig | 10 -- drivers/spi/Makefile |1 - drivers/spi/spi-s3c24xx-gpio.c| 200 - 7 files changed, 22 insertions(+), 293 deletions(-) -- Bye, Peter

[PATCH 2/5] mach-qt2410: convert to spi_gpio

2011-06-28 Thread Peter Korsgaard
Rather than the deprecated spi_s3c24xx_gpio driver. Only compile tested. Notice that the board support seems quite broken as the spi_s3c24xx_gpio platform device name was misspelled and there is no struct spi_board_info defined, but this atleast didn't make it any worse. Signed-off-by:

[PATCH 4/5] spi: remove obsolete spi-s3c24xx-gpio driver

2011-06-28 Thread Peter Korsgaard
It was equivalent to spi-gpio, and there's no longer any in-tree users of it, so get rid of it. Signed-off-by: Peter Korsgaard --- drivers/spi/Kconfig| 10 -- drivers/spi/Makefile |1 - drivers/spi/spi-s3c24xx-gpio.c | 200 --

[PATCH 5/5] mach-s3c2410: remove unused spi-gpio.h file

2011-06-28 Thread Peter Korsgaard
Not used anymore as the spi_s3c24xx_gpio driver is gone (replaced by the generic spi-gpio). Signed-off-by: Peter Korsgaard --- arch/arm/mach-s3c2410/include/mach/spi-gpio.h | 28 - 1 files changed, 0 insertions(+), 28 deletions(-) delete mode 100644 arch/arm/mach

[PATCH 1/5] mach-jive: convert to spi_gpio

2011-06-28 Thread Peter Korsgaard
Rather than the deprecated spi_s3c24xx_gpio driver. Compile tested only. Signed-off-by: Peter Korsgaard --- arch/arm/mach-s3c2412/mach-jive.c | 41 1 files changed, 14 insertions(+), 27 deletions(-) diff --git a/arch/arm/mach-s3c2412/mach-jive.c b/arch

Re: [PATCH v7] spi: New driver for Altera SPI

2011-02-06 Thread Peter Korsgaard
ntroller" Thomas> + default n 'n' is the default anyway, so no need for this line. -- Bye, Peter Korsgaard -- The modern datacenter depends on network connectivity to access resources an

Re: [spi-devel-general] [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-16 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Anyone? I've locally reverted the commit, but most likely I'm not the only one using the spi_mpc83xx driver without direct gpio controlled chip select handling. Anton> The advantages of this: Anton> - Don&#

Re: [spi-devel-general] [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-08 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov writes: Hi, Anton> The advantages of this: Anton> - Don't encourage legacy support; Anton> - Less external symbols, less code to compile-in for !MPC832x_RDB Anton> platforms. It's nice with your cleanups, but I wonder how to handle more complicated chip se

Re: [spi-devel-general] Performance of spi_mpc83xx.c sucks.

2008-12-02 Thread Peter Korsgaard
7;s more real work done. Joakim> Why use a kernel thread(mpc83xx_spi.0) to do the work? Would Joakim> it not be better if the polling was in process context? I guess that's needed for the async stuff. -- Bye, Peter Korsgaard

Re: [spi-devel-general] Performance of spi_mpc83xx.c sucks.

2008-10-21 Thread Peter Korsgaard
overhead (at 66MHz / 32bits we're talking over 2 million interrupts per second - E.G. only ~100 instructions between each!) Maybe it indeed makes more sense to use polling for high bitrates. -- Bye, Peter Korsgaard - This

Re: [spi-devel-general] [patch 2.6.27-rc6] spi_mpc83xx: reject invalid transfer sizes

2008-09-11 Thread Peter Korsgaard
nformation to be Andrew> able to decide whether this fix is needed in 2.6.27. Please Andrew> always provide this. Sorry, It's 2.6.27 material because of the crash. -- Bye, Peter Korsgaard - This SF.Net ema

[spi-devel-general] [PATCH] spi_mpc83xx: handle odd transfer sizes

2008-09-10 Thread Peter Korsgaard
Error out on transfer length != multiple of bytes per word with -EINVAL. Fixes a buffer overrun crash if length < bytes per word. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: Joakim Tjernlund <[EMAIL PROTECTED]> --- drivers/spi/spi_mpc83xx.c | 16 ++

[spi-devel-general] [PATCH] spi_mpc83xx: handle odd transfer sizes

2008-09-10 Thread Peter Korsgaard
Error out on transfer length != multiple of bytes per word with -EINVAL. Fixes a buffer overrun crash if length < bytes per word. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: Joakim Tjernlund <[EMAIL PROTECTED]> --- drivers/spi/spi_mpc83xx.c | 16 ++

Re: [spi-devel-general] [PATCH] spi_mpc83xx: handle odd transfer sizes

2008-09-10 Thread Peter Korsgaard
>>>>> "David" == David Brownell <[EMAIL PROTECTED]> writes: David> On Wednesday 10 September 2008, Peter Korsgaard wrote: >> +   /* invalid length? */ >> +   if (len & 1) >> +   return len;

[spi-devel-general] [PATCH] spi_mpc83xx: handle odd transfer sizes

2008-09-10 Thread Peter Korsgaard
Error out on transfer length != multiple of bytes per word. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/spi/spi_mpc83xx.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c index 0

Re: [spi-devel-general] [PATCH] spi_mpc83xx: handle odd transfer sizes

2008-09-10 Thread Peter Korsgaard
>>>>> "Joakim" == Joakim Tjernlund <[EMAIL PROTECTED]> writes: Hi, Joakim> On Wed, 2008-09-10 at 11:17 +0200, Peter Korsgaard wrote: >> Make spi_mpc83xx more robust against odd transfer sizes: >> - Error out on transfer length != multiple of b

[spi-devel-general] [PATCH] spi_mpc83xx: handle odd transfer sizes

2008-09-10 Thread Peter Korsgaard
Make spi_mpc83xx more robust against odd transfer sizes: - Error out on transfer length != multiple of bytes per word - Fix crash on transfer length = 0 (1 word was always sent and length decremented before check against 0). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drive

[spi-devel-general] [PATCH RESEND] spi_mpc83xx: fix clockrate calculation for low speed

2008-09-08 Thread Peter Korsgaard
Commit a61f5345 (spi_mpc83xx clockrate fixes) broke clockrate calculation for low speeds. SPMODE_DIV16 should be set if the divider is higher than 64, not only if the divider gets clipped to 1024. Furthermore, the clipping check was off by a factor 16 as well. Signed-off-by: Peter Korsgaard

[spi-devel-general] [PATCH] spi_mpc83xx: fix clockrate calculation for low speed

2008-09-04 Thread Peter Korsgaard
Commit a61f5345 (spi_mpc83xx clockrate fixes) broke clockrate calculation for low speeds. SPMODE_DIV16 should be set if the divider is higher than 64, not only if the divider gets clipped to 1024. Furthermore, the clipping check was off by a factor 16 as well. Signed-off-by: Peter Korsgaard

Re: [spi-devel-general] [PATCH 7/7] [POWERPC][SPI] spi_mpc83xx: allow use on MPC85xx

2007-09-25 Thread Peter Korsgaard
TAL Anton> + depends on SPI_MASTER && (PPC_83xx || PPC_85xx) && EXPERIMENTAL Anton> select SPI_BITBANG Anton> help Anton> This enables using the Freescale MPC83xx SPI controller in master Please also update the help text. -- Bye, Peter Korsgaar