Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set

2013-05-02 Thread Richard Genoud
2013/5/2 Yang, Wenyou : > Hi, Joachim, > >> -Original Message- >> From: Joachim Eastwood [mailto:manab...@gmail.com] >> Sent: 2013年3月7日 20:31 >> To: Yang, Wenyou >> Cc: linux-arm-ker...@lists.infradead.org; grant.lik...@secretlab.ca; Ferre, >> Nicolas; plagn...@jcrosoft.com; richard.gen...@

Re: [PATCH v8 3/8] spi/spi-atmel: add dmaengine support

2013-04-24 Thread Richard Genoud
2013/4/23 Mark Brown : > On Wed, Apr 03, 2013 at 12:23:35PM +0200, Richard GENOUD wrote: > > Richard, delete irrelevant context from your mails - it makes it much > easier to find the content you added. > >> On [mer., 03.04.2013 13:59:19], Wenyou Yang wrote: > >>

Re: [PATCH v8 8/8] ARM: dts: add pinctrl property for spi node for atmel SoC

2013-04-03 Thread Richard GENOUD
21 0x2 0x0 /* PA21 > periph B SPI1_MISO pin */ > + 0 22 0x2 0x0 /* PA22 > periph B SPI1_MOSI pin */ > + 0 23 0x2 0x0>; /* PA23 > periph B SPI1_SPCK pin */ > +

Re: [PATCH v8 3/8] spi/spi-atmel: add dmaengine support

2013-04-03 Thread Richard GENOUD
is patch is based on the original patch from Nicolas > - add dmaengine support > and squash the below patches from Richard Genoud > - update with dmaengine interface > - fix __init/__devinit sections mismatch > - fix spi-atmel driver to adapt to slave_conf

Re: [PATCH v8 2/8] spi/spi-atmel: add flag to controller data for lock operations

2013-04-03 Thread Richard GENOUD
atmel_spi_cleanup(struct spi_device *spi) > struct atmel_spi*as = spi_master_get_devdata(spi->master); > struct atmel_spi_device *asd = spi->controller_state; > unsignedgpio = (unsigned) spi->controller

Re: [PATCH v8 1/8] spi/spi-atmel: add physical base address

2013-04-03 Thread Richard GENOUD
*clk; > @@ -996,6 +997,7 @@ static int atmel_spi_probe(struct platform_device *pdev) > as->regs = ioremap(regs->start, resource_size(regs)); > if (!as->regs) > goto out_free_buffer; > + as->phybase = regs-

Re: [v4 PATCH 06/12] spi/atmel_spi: add dmaengine support

2013-01-23 Thread Richard Genoud
ou.y...@atmel.com: fix DMA: OOPS if buffer > 4096 bytes] > Signed-off-by: Wenyou Yang > Cc: grant.lik...@secretlab.ca > Cc: spi-devel-general@lists.sourceforge.net > Cc: richard.gen...@gmail.com > --- > This patch is based on the original patch from Nicolas >

[PATCH 08/23] spi/atmel: add DT support

2012-08-14 Thread Richard Genoud
From: Jean-Christophe PLAGNIOL-VILLARD The atmel_spi use only gpio for chip select. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: devicetree-disc...@lists.ozlabs.org Cc: spi-devel-general@lists.sourceforge.net --- .../devicetree/bindings/spi/spi_atmel.txt |6 + drivers/s

[PATCH 02/23] of_spi: add generic binding support to specify cs gpio

2012-08-14 Thread Richard Genoud
From: Jean-Christophe PLAGNIOL-VILLARD This will allow to use gpio for chip select with no modification in the driver binding When use the cs-gpios, the gpio number will be passed via the cs_gpio field and the number of chip select will automatically increased. Signed-off-by: Jean-Christophe PL

Re: [PATCH] spi_imx.c: correct the test on platform_get_irq() return value

2011-01-07 Thread Richard Genoud
2011/1/7 Grant Likely : > On Fri, Jan 7, 2011 at 7:26 AM, Richard Genoud > wrote: >> The test "if (spi_imx->irq <= 0)" is not testing the IRQ value, but the >> return value of platform_get_irq(). >> As platform_get_irq() can return an error (-ENXIO)

[PATCH] spi_imx.c: correct the test on platform_get_irq() return value

2011-01-07 Thread Richard Genoud
The test "if (spi_imx->irq <= 0)" is not testing the IRQ value, but the return value of platform_get_irq(). As platform_get_irq() can return an error (-ENXIO) or the IRQ value it found, the test should be "if (spi_imx->irq < 0)" Signed-off-by: Richard Genoud -

Re: [PATCH 1/2] spi_imx.c: CSPI3 irq is 0 on imx25

2011-01-06 Thread Richard Genoud
2010/12/23 Grant Likely : > On Thu, Dec 23, 2010 at 12:12:09PM +0100, Richard Genoud wrote: >> On imx25 soc, MX25_INT_CSPI3 is 0 >> (cf arch/arm/plat-mxc/include/mach/mx25.h). >> So, the test (spi_imx->irq <= 0) returned an error >> for this platform. >

Re: [PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7

2010-12-23 Thread Richard Genoud
2010/12/23 Uwe Kleine-König : > On Thu, Dec 23, 2010 at 12:12:10PM +0100, Richard Genoud wrote: >> The check on cpu_is_mx25 and cpu_is_mx35 was made twice. >> This is obviously wrong. > obviously wrong but no wrong behaviour.  Your patch only makes the code > consistent

[PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7

2010-12-23 Thread Richard Genoud
The check on cpu_is_mx25 and cpu_is_mx35 was made twice. This is obviously wrong. Anyway, this patch won't change the previous behaviour which is SPI_IMX_VER_0_7 for mx25 and mx35. Signed-off-by: Richard Genoud --- drivers/spi/spi_imx.c |2 +- 1 files changed, 1 insertions(+), 1 dele

[PATCH 1/2] spi_imx.c: CSPI3 irq is 0 on imx25

2010-12-23 Thread Richard Genoud
On imx25 soc, MX25_INT_CSPI3 is 0 (cf arch/arm/plat-mxc/include/mach/mx25.h). So, the test (spi_imx->irq <= 0) returned an error for this platform. This patch corrects this behaviour. Signed-off-by: Richard Genoud --- drivers/spi/spi_imx.c |2 +- 1 files changed, 1 insertions