Device tree conversion of spi device vs. controller_data

2012-04-08 Thread Roland Stigge
Hi, upon DT conversion of LPC32xx, I came across the at25 spi eeprom which needs .controller_data in struct spi_board_info for slave registration via spi_register_board_info() (non-DT-case). In the DT case, we need to eliminate this explicit registering call. Therefore, I need to somehow replace

Re: Device tree conversion of spi device vs. controller_data

2012-04-13 Thread Roland Stigge
On 04/13/2012 05:29 AM, Grant Likely wrote: >> upon DT conversion of LPC32xx, I came across the at25 spi eeprom which >> needs .controller_data in struct spi_board_info for slave registration >> via spi_register_board_info() (non-DT-case). >> >> In the DT case, we need to eliminate this explicit re

Re: Device tree conversion of spi device vs. controller_data

2012-04-28 Thread Roland Stigge
On 27/04/12 20:03, Grant Likely wrote: >>> Can you point me at specific code? >>> >>> .controller_data is owned by the spi_master driver. The eeprom driver >>> shouldn't be accessing it directly at all; but I'll need to look at >>> specific code to really understand what is going on. >> >> Please

[PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER

2012-06-18 Thread Roland Stigge
The patch to gpiolib-of.c providing -EPROBE_DEFER as a hint to defer of_get_named_gpio*() to a later probe() breaks spi-pl022.c. This patch adjusts to this change, using -EPROBE_DEFER as indication to defer. Signed-off-by: Roland Stigge --- Applies to 3.5-rc3 Should this patch be joined with

Re: [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER

2012-06-18 Thread Roland Stigge
On 06/18/2012 11:20 AM, Roland Stigge wrote: > The patch to gpiolib-of.c providing -EPROBE_DEFER as a hint to defer > of_get_named_gpio*() to a later probe() breaks spi-pl022.c. > > This patch adjusts to this change, using -EPROBE_DEFER as indication to defer. > > Signed-off

Re: [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER

2012-06-18 Thread Roland Stigge
On 06/18/2012 01:51 PM, Alexandre Pereira da Silva wrote: > On Mon, Jun 18, 2012 at 8:47 AM, Linus Walleij > wrote: >> On Mon, Jun 18, 2012 at 11:20 AM, Roland Stigge wrote: >> >>> The patch to gpiolib-of.c providing -EPROBE_DEFER as a hint to defer >>> o

Re: [PATCH RESEND v4] spi/pl022: add devicetree support

2012-08-20 Thread Roland Stigge
lect property from cs-gpios > > Populate master->dev.of_node, so the spi bus can find child spi > devices and register them > > At pl022 setup, fill chip_data structure from dt nodes, if not provided > by platform. > > Signed-off-by: Alexandre Pereira da Silva > Acke

Re: [PATCH RESEND v4] spi/pl022: add devicetree support

2012-08-20 Thread Roland Stigge
On 08/20/2012 04:22 PM, Rob Herring wrote: >> .../devicetree/bindings/spi/spi_pl022.txt | 15 +++ >> drivers/spi/spi-pl022.c| 114 >> >> 2 files changed, 110 insertions(+), 19 deletions(-) >> >> diff --git a/Documentation/devicetree/bin

[PATCH v5 1/2] spi/pl022: Add chip select handling via GPIO

2012-08-21 Thread Roland Stigge
This patch adds the ability for the driver to control the chip select directly. This enables independence from cs_control callbacks. Configurable via platform_data, to be extended as DT in the following patch. Based on the initial patch by Alexandre Pereira da Silva Signed-off-by: Roland

[PATCH v5 1/2] spi/pl022: Add chip select handling via GPIO

2012-08-21 Thread Roland Stigge
This patch adds the ability for the driver to control the chip select directly. This enables independence from cs_control callbacks. Configurable via platform_data, to be extended as DT in the following patch. Based on the initial patch by Alexandre Pereira da Silva Signed-off-by: Roland

[PATCH v5 2/2] spi/pl022: Add devicetree support

2012-08-21 Thread Roland Stigge
This patch adds device tree support to the spi-pl022 driver. Based on the initial patch by Alexandre Pereira da Silva Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/spi/spi_pl022.txt | 15 +++ drivers/spi/spi-pl022.c | 79

[PATCH v6 3/3] DT bindings documentation: "num-cs" property for SPI controllers

2012-08-22 Thread Roland Stigge
Several SPI controller drivers have defined differently named properties for the number of chip selects. Now adding "num-cs" as a reference name for new bindings. Signed-off-by: Roland Stigge --- Documentation/devicetree/bindings/spi/spi-bus.txt |3 +++ 1 file changed, 3

[PATCH v6 2/3] spi/pl022: Add devicetree support

2012-08-22 Thread Roland Stigge
This patch adds device tree support to the spi-pl022 driver. Based on the initial patch by Alexandre Pereira da Silva Signed-off-by: Roland Stigge Acked-by: Alexandre Pereira da Silva --- Documentation/devicetree/bindings/spi/spi_pl022.txt | 15 +++ drivers/spi/spi-pl022.c

[PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-08-22 Thread Roland Stigge
This patch adds the ability for the driver to control the chip select directly. This enables independence from cs_control callbacks. Configurable via platform_data, to be extended as DT in the following patch. Based on the initial patch by Alexandre Pereira da Silva Signed-off-by: Roland

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Roland Stigge
Hi Shiraz, On 01/09/12 13:14, shiraz hashim wrote: > On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge wrote: >> @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co >> pl022->master_info = platform_info; >> pl022->adev = adev; >>

[PATCH] spi/pl022: Fix chipselects pointer computation

2012-09-03 Thread Roland Stigge
ludgy pointer arithmetic with managed memory allocation for the chip selects. Signed-off-by: Roland Stigge --- drivers/spi/spi-pl022.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.orig/drivers/spi/spi-pl022.c +++ linux-2.6/drivers/spi/spi-pl022.c @@ -2053,8 +2

Re: [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree

2012-09-18 Thread Roland Stigge
Hi, On 09/18/2012 02:08 PM, Linus Walleij wrote: >> When we have sorted out this driver change (please check the new pl022 >> specific dt property names!), I will provide patches for arm-soc to >> actually use this new interface via dts files. > > OK cool I guess you will do this for the LPC32xx?

Re: [PATCH] spi/pl022: adopt pinctrl support

2012-09-19 Thread Roland Stigge
en properly > by the driver. New sleep states introduced by a separate patch to > ux500 but no regression, since the default state is sufficient. > > - U300: old hog deleted as part of this patch. > > - LPC32xx: does not appear to be using pinctrl. FWIW: Tested-by: Rolan