Re: [PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment

2014-06-10 Thread Sachin Kamat
Hi Naveen, On Tue, Jun 10, 2014 at 2:30 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch returns an integer error value instead of the pointer. warning: return makes integer from pointer without a cast Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc:

[PATCH 1/1] spi/pxa2xx: Convert to devm_ioremap_resource()

2013-04-08 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

Re: [PATCH 1/2] spi: spi-oc-tiny: Use of_match_ptr() macro

2013-03-26 Thread Sachin Kamat
On 15 March 2013 08:20, Thomas Chou tho...@wytron.com.tw wrote: Hi Sachin, On 03/14/2013 06:01 PM, Sachin Kamat wrote: This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Thomas Chou tho

[PATCH 2/2] spi: spi-sh-msiof: Use of_match_ptr() macro

2013-03-14 Thread Sachin Kamat
This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/spi/spi-sh-msiof.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c

[PATCH 1/2] spi: spi-oc-tiny: Use of_match_ptr() macro

2013-03-14 Thread Sachin Kamat
This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Thomas Chou tho...@wytron.com.tw --- drivers/spi/spi-oc-tiny.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-oc

[PATCH] spi: spi-tle62x0: Use module_spi_driver macro

2012-09-04 Thread Sachin Kamat
module_spi_driver eliminates module_init and module_exit calls and makes the code simpler. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/spi/spi-tle62x0.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/spi/spi-tle62x0.c b/drivers

[PATCH] spi/s3c64xx: Add missing static storage class specifiers

2012-08-02 Thread Sachin Kamat
. Should it be static? drivers/spi/spi-s3c64xx.c:1515:32: warning: symbol 'exynos4_spi_port_config' was not declared. Should it be static? Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/spi/spi-s3c64xx.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff