Re: [PATCHv2] drivers: spi: Add qspi flash controller

2013-07-02 Thread Sekhar Nori
On 7/2/2013 2:26 PM, Sourav Poddar wrote: > The patch add basic support for the quad spi controller. > > QSPI is a kind of spi module that allows single, > dual and quad read access to external spi devices. The module > has a memory mapped interface which provide direct interface > for accessing d

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-25 Thread Sekhar Nori
On 6/25/2013 12:24 PM, Tony Lindgren wrote: > * Benoit Cousson [130624 07:42]: >> Hi Tony, >> >> On 06/24/2013 12:19 PM, Tony Lindgren wrote: >>> Hi, >>> >>> For merging this series, I suggest the following sets: >>> >>> * Joel A Fernandes [130620 14:13]: Joel A Fernandes (3): ed

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/22/2013 8:23 AM, Joel A Fernandes wrote: config TI_EDMA tristate "TI EDMA support" default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 select DMA_ENGINE select DMA_VIRTUAL_CHANNELS >>> >>> >>> MMC depends on EDMA specially on AM33xx t

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-24 Thread Sekhar Nori
Sourav, On 6/24/2013 3:49 PM, Tony Lindgren wrote: > Hi, > > For merging this series, I suggest the following sets: > > * Joel A Fernandes [130620 14:13]: >> spi: omap2-mcspi: add generic DMA request support to the DT binding >> spi: omap2-mcspi: convert to dma_request_slave_channel_compat

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/24/2013 4:53 PM, Sekhar Nori wrote: > On 6/22/2013 3:23 AM, Joel A Fernandes wrote: >> Hi Arnd, >> >> On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >>> On Friday 21 June 2013, Joel A Fernandes wrote: >>>> I think we are talking a

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the defa

Re: [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX

2013-06-24 Thread Sekhar Nori
On 6/24/2013 3:47 PM, Tony Lindgren wrote: > * Sekhar Nori [130621 03:21]: >> On 6/21/2013 2:36 AM, Joel A Fernandes wrote: >>> From: Matt Porter >>> >>> Enable TI EDMA option on OMAP and TI_PRIV_EDMA >>> >>> Signed-off-by: Matt Porter >

Re: [PATCH v13] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-24 Thread Sekhar Nori
On 6/21/2013 3:23 PM, Sekhar Nori wrote: > From: Matt Porter > > Adds support for parsing the TI EDMA DT data into the required EDMA > private API platform data. Enables runtime PM support to initialize > the EDMA hwmod. Enables build on OMAP. > > Changes by Joel: > *

Re: [PATCH v12 09/11] spi: omap2-mcspi: convert to dma_request_slave_channel_compat()

2013-06-21 Thread Sekhar Nori
Fixing Mark's e-mail. Mark, On 6/21/2013 3:56 PM, Sourav Poddar wrote: > Hi Mark, > On Friday 21 June 2013 02:36 AM, Joel A Fernandes wrote: >> From: Matt Porter >> >> Convert dmaengine channel requests to use >> dma_request_slave_channel_compat(). This supports the DT case of >> platforms requi

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-21 Thread Sekhar Nori
Joel, On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > This series is remaining of Matt Porter's EDMA patches for AM33XX EDMA support > with changes for few pending review comments on v11 series. I have posted a branch with fixes for patches accepted by me in this seri

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS > > Signed-off-by: Joel A Fernandes You should sign-off with author e-mail address. > --- > arch/arm/Kconfig|1 + > arch/arm/mach-omap2/Kcon

Re: [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Matt Porter > > Enable TI EDMA option on OMAP and TI_PRIV_EDMA > > Signed-off-by: Matt Porter > Signed-off-by: Joel A Fernandes This will have to be taken by Tony. Thanks, Sekhar > --- > arch/arm/mach-omap2/Kconfig |1 + > drivers/d

[PATCH] ARM: edma: Add EDMA crossbar event mux support

2013-06-21 Thread Sekhar Nori
EDMA xbar support out of original EDMA DT parsing patch to keep it easier for review. * Rewrite shift and offset calculation. Suggested-by: Sekhar Nori Suggested by: Andy Shevchenko Signed-off-by: Joel A Fernandes Acked-by: Arnd Bergmann [nsek...@ti.com: fix checkpatch errors and a minor coding

Re: [PATCH v12 03/11] ARM: edma: Add EDMA crossbar event mux support

2013-06-21 Thread Sekhar Nori
t; * Rewrite shift and offset calculation. > > Suggested-by: Sekhar Nori > Suggested by: Andy Shevchenko > Signed-off-by: Joel A Fernandes > > Reference: > [1] https://patchwork.kernel.org/patch/2226991/ > --- > arch/arm/common/edma.c | 62 > +

[PATCH v13] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Sekhar Nori
] Signed-off-by: Joel A Fernandes Acked-by: Arnd Bergmann Signed-off-by: Sekhar Nori --- arch/arm/common/edma.c| 186 +++-- arch/arm/mach-davinci/devices-da8xx.c |8 +- arch/arm/mach-davinci/devices-tnetv107x.c |4 +- arch/arm/mach-davinci

Re: [PATCH v12 02/11] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-21 Thread Sekhar Nori
ed unused DT helper to convert to array > > [1] https://patchwork.kernel.org/patch/2226761/ > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori > Signed-off-by: Joel A Fernandes > --- > arch/arm/common/edma.c | 180 > +

Re: [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support

2013-06-19 Thread Sekhar Nori
On 6/20/2013 6:06 AM, Joel A Fernandes wrote: >>> + /* Clear the xbar mapped channels in unused list */ >>> + xbar_chans = info[j]->xbar_chans; >>> + if (xbar_chans) { >>> + for (i = 0; xbar_chans[i][1] != -1; i++) { >>> +

Re: [PATCH v11 3/8] ARM: edma: Add EDMA crossbar event mux support

2013-06-18 Thread Sekhar Nori
On 6/18/2013 12:08 PM, Joel A Fernandes wrote: > From: Matt Porter > > Changes by Joel: > * Split EDMA xbar support out of original EDMA DT parsing patch > to keep it easier for review. > * Rewrite shift and offset calculation. > > Suggested-by: Sekhar Nori > Su

Re: [PATCH v11 2/8] ARM: edma: Add DT and runtime PM support to the private EDMA API

2013-06-18 Thread Sekhar Nori
> * Setup default one-to-one mapping for queue_priority and queue_tc > mapping as discussed in [1]. > * Split out xbar stuff to separate patch. [1] > > [1] https://patchwork.kernel.org/patch/2226761/ > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori > Signed-of

Re: [PATCH v10 0/8] DMA Engine support for AM33XX

2013-06-17 Thread Sekhar Nori
Joel, When you respin this, please base on top of Prabhakar's clean-up titled: "ARM: edma: Convert to devm_* api". Or better still, include his patch in your series. Thanks, Sekhar -- This SF.net email is sponsored by W

Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

2013-06-17 Thread Sekhar Nori
On 6/17/2013 9:10 PM, Fernandes, Joel A wrote: > Hi Arnd, > >> -Original Message- >> From: Arnd Bergmann [mailto:a...@arndb.de] >> Sent: Monday, June 17, 2013 6:13 AM >> To: Fernandes, Joel A >> Cc: Tony Lindgren; Nori, Sekhar; Matt Porter; Grant Likely; Rob Herring; >> Vinod >> Koul; Ma

Re: [PATCH v10 5/8] dmaengine: edma: Add TI EDMA device tree binding

2013-06-17 Thread Sekhar Nori
Grant, Rob, Can one of you please take a look at this patch and see if you have any comments on the binding definition? Joel, Ideally the bindings are described before they are used or along with its usage. In that aspect, this patch is present too far back in the series. Can you please fix this

Re: [PATCH v9 1/9] ARM: davinci: move private EDMA API to arm/common

2013-06-06 Thread Sekhar Nori
+ Chris since the patch has some davinci_mmc.c changes. Chris, Mark, On 3/6/2013 9:45 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori Can you ple

Re: [PATCH v9 1/9] ARM: davinci: move private EDMA API to arm/common

2013-06-05 Thread Sekhar Nori
Hi Russell, On 3/6/2013 9:45 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori Can you please ack this movement of davinci private EDMA implementat

Re: [PATCH v5 0/5] Patch enables support for m25p64 SPI flash support on da850-EVM.

2013-04-16 Thread Sekhar Nori
On 4/16/2013 3:50 PM, Grant Likely wrote: > On Mon, 15 Apr 2013 17:18:59 +0530, Sekhar Nori wrote: >> On 4/9/2013 11:14 AM, Manjunathappa, Prakash wrote: >>> Hi Grant, >>> >>> On Wed, Apr 03, 2013 at 19:39:05, Manjunathappa, Prakash wrote: >>>>

Re: [PATCH v5 0/5] Patch enables support for m25p64 SPI flash support on da850-EVM.

2013-04-15 Thread Sekhar Nori
On 4/9/2013 11:14 AM, Manjunathappa, Prakash wrote: > Hi Grant, > > On Wed, Apr 03, 2013 at 19:39:05, Manjunathappa, Prakash wrote: >> Testing information: >> da850-evm comes with partitions specified in DT blob. >> Able to mount/umount and create/delete files on filesystem partition. >> > > Coul

Re: [PATCH v9 0/9] DMA Engine support for AM33XX

2013-04-03 Thread Sekhar Nori
Hi Matt, On 3/6/2013 9:45 PM, Matt Porter wrote: > This series adds DMA Engine support for AM33xx, which uses > an EDMA DMAC. The EDMA DMAC has been previously supported by only > a private API implementation (much like the situation with OMAP > DMA) found on the DaVinci family of SoCs. > Matt P

Re: [PATCH v4 0/5] Enable SPI flash support on da850-evm DT kernel

2013-04-02 Thread Sekhar Nori
On 3/20/2013 4:44 PM, Sekhar Nori wrote: > Grant, > > On 3/20/2013 4:16 PM, Manjunathappa, Prakash wrote: >> Patch enables support for m25p64 SPI flash support on >> da850-EVM. > > With your ack, I would like to merge this series through davinci tree > fo

Re: [PATCH v4 0/5] Enable SPI flash support on da850-evm DT kernel

2013-03-20 Thread Sekhar Nori
Grant, On 3/20/2013 4:16 PM, Manjunathappa, Prakash wrote: > Patch enables support for m25p64 SPI flash support on > da850-EVM. With your ack, I would like to merge this series through davinci tree for v3.10. This will help manage dependencies for DT files. Thanks, Sekhar --

Re: [PATCH v3 0/5] Enable SPI flash support on da850-evm DT kernel

2013-03-14 Thread Sekhar Nori
On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote: > Patch enables support for m25p64 SPI flash support on > da850-EVM. This patch set looks good to me except the comments I had on 2/5. I tested it using SPI flash on DA850 EVM and it worked fine on basic read/write tests. Grant, With your ack I

Re: [PATCH v3 2/5] spi/davinci: add DT binding documentation

2013-03-14 Thread Sekhar Nori
On 3/12/2013 1:40 PM, Manjunathappa, Prakash wrote: > From: Murali Karicheri > > Get back missed out binding documentation submitted along > with below patch: > "spi/davinci: add OF support for the spi controller" This is not really the correct description of this patch. Years later its mostly i

Re: [PATCH v9 5/9] dmaengine: edma: Add TI EDMA device tree binding

2013-03-11 Thread Sekhar Nori
On 3/6/2013 9:45 PM, Matt Porter wrote: > The binding definition is based on the generic DMA controller > binding. > > Signed-off-by: Matt Porter Okay the bindings the documented after they are used leading to some confusion. This patch should be moved up the series. As I noted in my other e-mai

Re: [PATCH v9 3/9] ARM: edma: add AM33XX support to the private EDMA API

2013-03-11 Thread Sekhar Nori
igned-off-by: Matt Porter > Acked-by: Sekhar Nori > --- > arch/arm/common/edma.c | 300 > ++-- > arch/arm/mach-omap2/Kconfig|1 + > include/linux/platform_data/edma.h |1 + > 3 files changed, 292 insertions(+), 10

Re: [PATCH v2 1/4] spi/davinci: add DT binding documentation

2013-03-05 Thread Sekhar Nori
On 3/5/2013 6:26 PM, Manjunathappa, Prakash wrote: > Hi Arnd, > > On Mon, Mar 04, 2013 at 21:59:16, Arnd Bergmann wrote: >> On Monday 04 March 2013 18:29:12 Manjunathappa, Prakash wrote: >>> diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt >>> b/Documentation/devicetree/bindin

Re: [PATCH 0/4] Enable SPI flash support on da850-evm DT kernel

2013-02-27 Thread Sekhar Nori
On 2/25/2013 4:14 PM, Manjunathappa, Prakash wrote: > Patch enables support for m25p80 SPI flash support on > da850-EVM. > > Testing information: > da850-evm comes with partitions specified in DT blob. > Able to mount/umount and create/delete files on filesystem partition. > > Depends on below pa

Re: [PATCH 1/4] spi/davinci: fix module build error

2013-02-27 Thread Sekhar Nori
drivers/spi/spi-davinci.c:774:1: error: '__mod_of_device_table' aliased > to undefined symbol 'davini_spi_of_match' > make[2]: *** [drivers/spi/spi-davinci.o] Error 1 > make[1]: *** [drivers/spi] Error 2 > make[1]: *** Waiting for unfinished jobs > make: *** [drivers] E

Re: [PATCH 4/4] ARM: davinci: da850-evm: add SPI flash support

2013-02-27 Thread Sekhar Nori
On 2/25/2013 4:14 PM, Manjunathappa, Prakash wrote: > Enable m25p80 SPI flash support on da850-EVM. Also > add partition information of SPI flash. > > Signed-off-by: Manjunathappa, Prakash > --- > arch/arm/boot/dts/da850-evm.dts | 40 > +++ > 1 files change

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-09 Thread Sekhar Nori
Hi Matt, This version introduces build/bisect issues. On 2/1/2013 11:52 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. > > Signed-off-by: Matt Porter > Acked-by: Sekhar Nori > diff --git a/arc

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-23 Thread Sekhar Nori
Matt, On 1/24/2013 3:07 AM, Matt Porter wrote: > On Wed, Jan 23, 2013 at 10:21:42AM +0800, Mark Brown wrote: >> On Tue, Jan 22, 2013 at 09:26:34PM +0530, Sekhar Nori wrote: >>> On 1/16/2013 2:02 AM, Matt Porter wrote: >> >>>> This series adds DMA Engine support

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-23 Thread Sekhar Nori
Hi Mark, On 1/23/2013 7:51 AM, Mark Brown wrote: > On Tue, Jan 22, 2013 at 09:26:34PM +0530, Sekhar Nori wrote: >> On 1/16/2013 2:02 AM, Matt Porter wrote: > >>> This series adds DMA Engine support for AM33xx, which uses >>> an EDMA DMAC. The EDMA DMAC has been prev

Re: [PATCH v5 00/14] DMA Engine support for AM33XX

2013-01-22 Thread Sekhar Nori
Hi Tony, On 1/16/2013 2:02 AM, Matt Porter wrote: > This series adds DMA Engine support for AM33xx, which uses > an EDMA DMAC. The EDMA DMAC has been previously supported by only > a private API implementation (much like the situation with OMAP > DMA) found on the DaVinci family of SoCs. Will yo

Re: [RFC PATCH v3 02/16] ARM: davinci: move private EDMA API to arm/common

2013-01-22 Thread Sekhar Nori
Matt, Sorry about the late reply. I noticed this mail only after I started to look at v5 of your series :( On 1/11/2013 5:21 AM, Matt Porter wrote: > On Sun, Oct 28, 2012 at 01:47:09PM +0530, Sekhar Nori wrote: >> On 10/18/2012 6:56 PM, Matt Porter wrote: >>> Move mach-davin

Re: [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-10-29 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > TODO: this will be replaced once the DMA Engine

Re: [RFC PATCH v3 16/16] ARM: dts: add AM33XX SPI support

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds AM33XX SPI support for am335x-bone and am335x-evm. > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am335x-bone.dts | 17 +++ > arch/arm/boot/dts/am335x-evm.dts |9 > arch/arm/boot/dts/am33xx.dtsi | 43 >

Re: [RFC PATCH v3 08/16] ARM: dts: add AM33XX EDMA support

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds AM33XX EDMA support to the am33xx.dtsi as documented in > Documentation/devicetree/bindings/dma/ti-edma.txt > > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am33xx.dtsi | 31 +++ > 1 file changed, 31 insertion

Re: [RFC PATCH v3 05/16] ARM: edma: add AM33XX crossbar event support

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds support for the per-EDMA channel event mux. This is required > for any peripherals using DMA crossbar mapped events. > > Signed-off-by: Matt Porter > --- > arch/arm/common/edma.c | 63 > +++- > includ

Re: [RFC PATCH v3 04/16] ARM: edma: add DT and runtime PM support for AM33XX

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Adds support for parsing the TI EDMA DT data into the required > EDMA private API platform data. > > Calls runtime PM API only in the DT case in order to unidle the > associated hwmods on AM33XX. Runtime PM is supported on DaVinci now, so if that was th

Re: [RFC PATCH v3 02/16] ARM: davinci: move private EDMA API to arm/common

2012-10-28 Thread Sekhar Nori
On 10/18/2012 6:56 PM, Matt Porter wrote: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. This just moves the > private EDMA API but does not support OMAP. > > Signed-off-by: Matt Porter > --- > diff --git a/arch/arm/mach-davinci/devices.c b/

Re: [PATCH 1/1] spi:clk: preparation for switch to common clock framework

2012-10-09 Thread Sekhar Nori
Karicheri > Reviewed-by: Mike Turquette This patch had to be applied manually and with some fuzz when I applied it to latest linus/master. There were no conflicts though and once I applied it, I was able to test SPI flash on DA850 EVM successfully using it. Acked-by: Sekhar Nori I am hoping t

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-31 Thread Sekhar Nori
On 8/31/2012 10:01 PM, Vinod Koul wrote: > On Fri, 2012-08-31 at 21:32 +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/30/2012 8:13 PM, Matt Porter wrote: >>> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >>>> Hi Matt, >>

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-31 Thread Sekhar Nori
Hi Matt, On 8/30/2012 8:13 PM, Matt Porter wrote: > On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/23/2012 6:39 AM, Matt Porter wrote: >>> Removes use of the DaVinci EDMA private DMA API and replaces >>> it with use of th

Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API

2012-08-30 Thread Sekhar Nori
Hi Matt, On 8/23/2012 6:39 AM, Matt Porter wrote: > Removes use of the DaVinci EDMA private DMA API and replaces > it with use of the DMA engine API. > > Signed-off-by: Matt Porter I tried testing this patch on my OMAP-L138 EVM, but SPI fails to initialize after applying the patch. root@arago

[PATCH 05/49] spi: davinci: remove unnecessary typecast

2010-11-17 Thread Sekhar Nori
The typecasting of SPI base address to davinci_spi_reg is unused. Remove it. Tested-By: Michael Williamson Tested-By: Brian Niebuhr Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/spi/davinci_spi.c b

[PATCH 00/49] spi: davinci: re-write existing driver

2010-11-17 Thread Sekhar Nori
or DMA spi: davinci: let DMA operation be specified on per-device basis spi: davinci: remove non-useful "clk_internal" platform data spi: davinci: enable and power-up SPI only when required spi: davinci: setup the driver owner spi: davinci: add additional comments spi: davinci: add EF J

[PATCH 23/49] spi: davinci: do not treat Tx interrupt being set as error

2010-11-17 Thread Sekhar Nori
: Michael Williamson Tested-By: Brian Niebuhr Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index ad814f2..a60a65c 100644 --- a/drivers/spi/davinci_spi.c +++ b

[PATCH 01/49] spi: davinci: fix checkpatch errors

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Fix the following checkpatch error: WARNING: unnecessary whitespace before a quoted newline + dev_info(&pdev->dev, "Controller at 0x%p \n", davinci_spi->base); Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar No

[PATCH 39/49] spi: davinci: handle DMA completion errors correctly

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Do not simply clean the DMA channel on a DMA completion error. Instead, use wcount and rcount members of davinci_spi to detecion non-completion of DMA and signal EIO to the application. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori

[PATCH 12/49] spi: davinci: make chip-slect specific parameters really chip-select specific

2010-11-17 Thread Sekhar Nori
using controller_data member of spi_device data structure on a per-device basis. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/dm355.c|3 - arch/arm/mach-davinci/dm365.c|3 - arch/arm/mach-davinci

[PATCH 35/49] spi: davinci: use edma_write_slot() to setup EDMA PaRAM slot

2010-11-17 Thread Sekhar Nori
Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 34 +++--- 1 files changed, 19 insertions(+), 15 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 705d006..67f1e46 100644 --- a/drivers/spi/davinci_spi.c

[PATCH 07/49] spi: davinci: enable both activation and deactivation of chip-selects

2010-11-17 Thread Sekhar Nori
|dma}(). Also, keeping chip select active control is removed as a platform data and simply controlled using information from spi_bitbang on whether chip slect should be activated or de-activated. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm

[PATCH 45/49] spi: davinci: add additional comments

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Add comments describing the platform data members and per-chip-select SPI configuration structure. Also, add some comments describing the what happens during the driver probe. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch

[PATCH 17/49] spi: davinci: eliminate the single member structure davinci_spi_slave

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr The struct davinci_spi_slave has a single member. Eliminate it and store the per-chipselect data in struct davinci_spi directly. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 14 +- 1

[PATCH 33/49] spi: davinci: do not use temporary buffer if no transmit data provided

2010-11-17 Thread Sekhar Nori
being transmitted. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 52 ++-- 1 files changed, 21 insertions(+), 31 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi

[PATCH 26/49] spi: davinci: simplify poll mode transfers

2010-11-17 Thread Sekhar Nori
Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 96 +++-- 1 files changed, 41 insertions(+), 55 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 198f062..cd37697 100644 --- a/drivers/spi/davinci_spi.c

[PATCH 28/49] spi: davinci: configure the invariable bits in spipc0 only once

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Configure the data-in, data-out and clock functionality pins in SPIPC0 register only once during probe. No need to set these bits for each transfer. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |8

[PATCH 42/49] spi: davinci: remove non-useful "clk_internal" platform data

2010-11-17 Thread Sekhar Nori
Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/dm355.c|1 - arch/arm/mach-davinci/dm365.c|1 - arch/arm/mach-davinci/include/mach/spi.h |1 - drivers/spi/davinci_spi.c|9 + 4 files changed, 1 insertions(+), 11 deletion

[PATCH 34/49] spi: davinci: always start receive DMA

2010-11-17 Thread Sekhar Nori
size should be same as transfer length to avoid hang-up when transfer length is smaller than temporary rx buffer size (rx buffer not provided)] Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 70

[PATCH 08/49] spi: davinci: remove unnecessary data transmit on CS disable

2010-11-17 Thread Sekhar Nori
laves cope-up with this, some cannot. This patch fixes this by doing a 16-bit write on the upper half of the SPIDAT1 register While at it, group the SPIGCR1 register related defines seperately from SPIDAT1 register defines. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: S

[PATCH 21/49] spi: davinci: remove unnecessary disable of SPI

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr In the davinci_spi_bufs_dma() function, SPI is briefly disabled before enabling it immediately back again. Remove this unnecessary disable. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |2 -- 1

[PATCH 48/49] spi: davinci: shorten variable names

2010-11-17 Thread Sekhar Nori
x|rx}_channel' since the structure containing them is already called 'davinci_spi_dma' * 'davinci_spi_dma' in 'davinci_spi' structure is being renamed 'dma' Tested-By: Brian Niebuhr Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |

[PATCH 14/49] spi: davinci: setup chip-select timers values only if timer enabled

2010-11-17 Thread Sekhar Nori
Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 34b28fe..d09b63c 100644 --- a/drivers/spi/davinci_spi.c +++ b/drivers/spi

[PATCH 24/49] spi: davinci: remove unnecessary completion variable initialization

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr The completion variable 'done' is unnecessarly initialized by the function davinci_spi_bufs_dma() where as it is not used for DMA transfers at all. Remove the unnecessary initialization. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: S

[PATCH 44/49] spi: davinci: setup the driver owner

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Setup the owner member of the platform driver to THIS_MODULE instead of leaving it NULL. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |5 - 1 files changed, 4 insertions(+), 1 deletions

[PATCH 16/49] spi: davinci: remove unused members of davinci_spi_slave

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Several members of struct davinci_spi_slave are unused in code. Remove such members. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff

[PATCH 32/49] spi: davinci: always start transmit DMA

2010-11-17 Thread Sekhar Nori
ned-off-by: Sekhar Nori --- arch/arm/mach-davinci/dm355.c|1 + arch/arm/mach-davinci/include/mach/spi.h |1 + drivers/spi/davinci_spi.c| 22 +- 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-davinci/dm355.c b/arc

[PATCH 47/49] spi: davinci: remove unnecessary private data member 'region_size'

2010-11-17 Thread Sekhar Nori
Remove unnecesary private data member 'region_size' being used to store the size of SPI memory region. Instead, get the memory resource size directly from the platform data. Tested-By: Brian Niebuhr Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 13 ++--- 1 fil

[PATCH 04/49] spi: davinci: removed unused #defines

2010-11-17 Thread Sekhar Nori
Remove unused defines from code which should help in easy reading of code. Also, use the opportuinity to keep the SPIGCR1 register defines together. Tested-By: Michael Williamson Tested-By: Brian Niebuhr Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 33

[PATCH 49/49] spi: davinci: kconfig: add manufacturer name to prompt string

2010-11-17 Thread Sekhar Nori
Signed-off-by: Sekhar Nori --- drivers/spi/Kconfig |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 78f9fd0..a32796e 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -111,11 +111,14 @@ config SPI_COLDFIRE_QSPI

[PATCH 03/49] spi: davinci: remove unused variable 'pdata'

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr The 'pdata' variable is unused in couple of routines. Remove such occurences. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |8 1 files changed, 0 insertions(+), 8 deletion

[PATCH 02/49] spi: davinci: whitespace cleanup

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Cleanup unnecessary white space from various parts of the file. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 22 ++ 1 files changed, 10 insertions(+), 12 deletions(-) diff

[PATCH 27/49] spi: davinci: add support for interrupt mode

2010-11-17 Thread Sekhar Nori
e the code between interrupt mode processing and polled mode processing. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/include/mach/spi.h |4 + drivers/spi/davinci_spi.c| 145 +++-

[PATCH 38/49] spi: davinci: fix EDMA CC errors at end of transfers

2010-11-17 Thread Sekhar Nori
EDMA CC error to be asserted. Without this provision, the EDMA CC error would be asserted because the channel PaRAM would be empty after the transfer and EDMA would not know what to make out of the extra sync event. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekha

[PATCH 31/49] spi: davinci: do not store DMA channel information per chip select

2010-11-17 Thread Sekhar Nori
: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 47 +--- 1 files changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 77109dc..4aa5221 100644 --- a/drivers/spi

[PATCH 43/49] spi: davinci: enable and power-up SPI only when required

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr Enable SPI only when active transfers are in progress. Keep it in local low power when not in use. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |8 ++-- 1 files changed, 6 insertions(+), 2

[PATCH 09/49] spi: davinci: enable GPIO lines to be used as chip selects

2010-11-17 Thread Sekhar Nori
as chip selects based on information provided in platform data. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/include/mach/spi.h |3 ++ drivers/spi/davinci_spi.c| 39 - 2 files

[PATCH 20/49] spi: davinci: check for NULL buffer pointer before using it

2010-11-17 Thread Sekhar Nori
: Sekhar Nori --- drivers/spi/davinci_spi.c | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index b0b338f..10b0a08 100644 --- a/drivers/spi/davinci_spi.c +++ b/drivers/spi

[PATCH 15/49] spi: davinci: add support for wait enable timeouts

2010-11-17 Thread Sekhar Nori
data finished). While at it, modify the T2C and C2T defines by prepending the register name as is the convention followed for other register field elsewhere in the driver. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/include/mach

[PATCH 11/49] spi: davinci: remove 'wait_enable' platform data member

2010-11-17 Thread Sekhar Nori
ating this capability. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/include/mach/spi.h |1 - drivers/spi/davinci_spi.c|2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/arm/ma

[PATCH 18/49] spi: davinci: eliminate unnecessary update of davinci_spi->count

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr The count member of davinci_spi is internal to the driver and is not shared with framework. Eliminate its unnecessary update. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |6 -- 1 files

[PATCH 37/49] spi: davinci: do not allocate DMA channels during SPI device setup

2010-11-17 Thread Sekhar Nori
l Williamson Tested-By: Brian Niebuhr Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/include/mach/spi.h |1 - drivers/spi/davinci_spi.c| 153 ++ 2 files changed, 51 insertions(+), 103 deletions(-) diff --git a/arch/arm/mach-davinci/includ

[PATCH 13/49] spi: davinci: consolidate setup of SPIFMTn in one function

2010-11-17 Thread Sekhar Nori
Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 154 ++-- 1 files changed, 49 insertions(+), 105 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index d4320f7..34b28fe 100644 --- a

[PATCH 10/49] spi: davinci: simplify prescalar calculation

2010-11-17 Thread Sekhar Nori
Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 53 ++-- 1 files changed, 31 insertions(+), 22 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index d5d7014..17269ad 100644 --- a/drivers/spi/davinci_spi.c

[PATCH 40/49] spi: davinci: remove usage of additional completion variables for DMA

2010-11-17 Thread Sekhar Nori
nd use the existing completion variable. [nsek...@ti.com: To make this process easy, eliminate the two different DMA completion callback functions for tx and rx and use a single callback function instead] Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- d

[PATCH 36/49] spi: davinci: fix DMA event generation stoppage

2010-11-17 Thread Sekhar Nori
stalled. Instead, disable event generation once after both the transmit and receive DMA completes. While at it, remove the largely under-used function to set or clear DMA event generation. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi

[PATCH 41/49] spi: davinci: let DMA operation be specified on per-device basis

2010-11-17 Thread Sekhar Nori
Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/include/mach/spi.h |1 + drivers/spi/davinci_spi.c| 342 ++ 2 files changed, 156 insertions(+), 187 deletions(-) diff --git a/arch/arm/mach-davinci/include/mach

[PATCH 29/49] spi: davinci: remove unnecessary function davinci_spi_bufs_prep()

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr The function davinci_spi_bufs_prep() is doing stuff that davinci_spi_setup() is doing. Eliminate it and move the work to davinci_spi_setup() Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 64

[PATCH 25/49] spi: davinci: remove non-useful interrupt mode support

2010-11-17 Thread Sekhar Nori
mode since users can anyway use poll mode with no functional difference. A usefully implemented interrupt mode support can be added later. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- arch/arm/mach-davinci/dm355.c|1 - arch/arm/mach

[PATCH 30/49] spi: davinci: remove unnecessary call to davinci_spi_setup_transfer()

2010-11-17 Thread Sekhar Nori
. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 05b6145..77109dc 100644 --- a

[PATCH 19/49] spi: davinci: simplify calculation of edma acount value

2010-11-17 Thread Sekhar Nori
-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c | 25 +++-- 1 files changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index f1c3502..b0b338f 100644 --- a/drivers/spi/davinci_spi.c

[PATCH 22/49] spi: davinci: remove unnecessary 'count' variable in driver private data

2010-11-17 Thread Sekhar Nori
From: Brian Niebuhr The variable count in DaVinci SPI driver's private data is largely unused and its minor use can easily be eliminated. Remove the variable. Signed-off-by: Brian Niebuhr Tested-By: Michael Williamson Signed-off-by: Sekhar Nori --- drivers/spi/davinci_spi.c |

  1   2   >