Re: [PATCH] spi: reorganize drivers

2011-06-06 Thread Stefan Richter
S but most of the commits there are actually done by DaveM.) PPS, besides association of source files with development trees, there is also the association with developer mailing lists and user mailing lists and web resources, e.g. wiki. How logical the directory layout is in this sense could be ap

Re: [PATCH] spi: reorganize drivers

2011-06-05 Thread Stefan Richter
gt; Plus, when dropping the prefix, spi_xilinx.ko and gpio-xilinx.ko > become the same... In drivers/firewire/Makefile for example, there is this: firewire-core-y += core-card.o core-cdev.o core-device.o \ core-iso.o core-topology.o core-transaction.o fir

Re: [spi-devel-general] [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-23 Thread Stefan Richter
mutex_lock(&class->mutex); > + list_for_each_entry(dev, &class->children, node) > + if (match(dev, data) && class_device_get(dev)) > + break; > + mutex_unlock(&class->mutex); > + > + return dev; > +} Here too? --

Re: [spi-devel-general] [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-23 Thread Stefan Richter
Greg KH wrote: > On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote: >> David Brownell wrote: >> > On Monday 07 January 2008, Greg KH wrote: >> >> Most of the non-driver core code should be converted to not use the >> >> lock in the class at

Re: [spi-devel-general] [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-23 Thread Stefan Richter
t iterations. But this would complicate the API because of the additional locking requirements, and hence would invariably result in buggy usages of the API. -- Stefan Richter -=-==--- ---= --=== http://arcgraph.de/sr/ - This

Re: [spi-devel-general] [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-23 Thread Stefan Richter
vitable. I agree. Sem2mutex conversion should not be mixed with API conversion, even if one or both seem trivial. -- Stefan Richter -=-==--- ---= --=== http://arcgraph.de/sr/ - This SF.net email is sponsored by: Microsoft D

Re: [spi-devel-general] [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-23 Thread Stefan Richter
t; You don't need the second line because it says the same as the first line. Either kill it, or replace it by an explanation _why_ the semaphore is to be replaced by mutex. (I guess you do it because they are lighter-weight, both in semantics and in implementation, and because there ar