Re: [PATCH v9] spi: New driver for Altera SPI

2011-02-14 Thread Thomas Chou
Dear Ryan, On 02/14/2011 10:20 AM, Ryan Mallon wrote: On 02/14/2011 03:10 PM, Thomas Chou wrote: This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Choutho...@wytron.com.tw --- +struct altera_spi

[PATCH v9] spi: New driver for Altera SPI

2011-02-13 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. v4 minor cleanup

[PATCH v8] spi: add OpenCores tiny SPI driver

2011-02-13 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. v3 rename driver to spi_oc_tiny as Grant suggested. set version to tiny-spi-rtlsvn2 as Jonas

[PATCH v8 resend] spi: add OpenCores tiny SPI driver

2011-02-13 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. v3 rename driver to spi_oc_tiny as Grant suggested. set version to tiny-spi-rtlsvn2 as Jonas

Re: [PATCH v7] spi: New driver for Altera SPI

2011-02-07 Thread Thomas Chou
On 02/07/2011 04:23 AM, Peter Korsgaard wrote: Thomas == Thomas Choutho...@wytron.com.tw writes: Hi, Thomas +++ b/drivers/spi/Kconfig Thomas @@ -53,6 +53,13 @@ if SPI_MASTER Thomas comment SPI Master Controller Drivers Thomas +config SPI_ALTERA Thomas + tristate Altera

[PATCH v8] spi: New driver for Altera SPI

2011-02-07 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. v4 minor cleanup

[PATCH v7] spi: add OpenCores tiny SPI driver

2011-02-07 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. v3 rename driver to spi_oc_tiny as Grant suggested. set version to tiny-spi-rtlsvn2 as Jonas

Re: [PATCH v6] spi: New driver for Altera SPI

2011-02-05 Thread Thomas Chou
On 02/04/2011 01:34 AM, Grant Likely wrote: Hi Thomas, comments below, but looking pretty close. Thanks a lot. +config SPI_ALTERA +tristate Altera SPI Controller +select SPI_BITBANG Will this compile on all architectures? Will it break allyesconfig on anything other than nios?

[PATCH v7] spi: New driver for Altera SPI

2011-02-05 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. v4 minor cleanup

[PATCH v6] spi: add OpenCores tiny SPI driver

2011-02-05 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. v3 rename driver to spi_oc_tiny as Grant suggested. set version to tiny-spi-rtlsvn2 as Jonas

[PATCH v6] spi: New driver for Altera SPI

2011-02-03 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. v4 minor cleanup

[PATCH v4] spi: add OpenCores tiny SPI driver

2011-02-03 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. v3 rename driver to spi_oc_tiny as Grant suggested. set version to tiny-spi-rtlsvn2 as Jonas

Re: [PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-24 Thread Thomas Chou
Hi Jonas, On 01/24/2011 06:59 PM, Jonas Bonn wrote: We've discussed this a bit internally now and decided that the best way to version OpenCores cores is to use the SVN commit ID of the rtl/ directory in the project's repository. So, for your tiny-spi project, the last SVN commit to update

[PATCH v3] spi: add OpenCores tiny SPI driver

2011-01-24 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. v3 rename driver to spi_oc_tiny as Grant suggested. set version to tiny-spi-rtlsvn2 as Jonas

Re: [PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-23 Thread Thomas Chou
Hi Jonas, On 01/21/2011 08:27 PM, Jonas Bonn wrote: It would be nice to use the same name for the OpenCores project and the device tree identifier, and since opencores is already in the name, the oc_ bit is superfluous anyway. I'd suggest opencores,tiny-spi in order to match your OpenCores

[PATCH v5] spi: New driver for Altera SPI

2011-01-23 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. v4 minor cleanup

Re: [PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-20 Thread Thomas Chou
Hi Grant, Thanks a lot for the review. On 01/21/2011 12:54 AM, Grant Likely wrote: drivers/spi/oc_tiny_spi.c | 422 +++ Rename files to spi_oc_tiny.c OK. +#ifndef CONFIG_TINY_SPI_IDLE_VAL +# define CONFIG_TINY_SPI_IDLE_VAL 0x00 +#endif Do

Re: [PATCH v3] spi: New driver for Altera SPI

2011-01-18 Thread Thomas Chou
On 01/17/2011 03:27 PM, Sinan Akman wrote: + if (hw-irq = 0) { + init_completion(hw-done); I think you init this twice, once in altera_spi_probe below as well. I will remove this one, too. Thank you again. - Thomas

[PATCH v2] spi: New driver for Altera SPI

2011-01-16 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support. drivers/spi/Kconfig|6 + drivers/spi/Makefile |1 + drivers/spi

Re: [PATCH v2] spi: New driver for Altera SPI

2011-01-16 Thread Thomas Chou
On 01/17/2011 01:59 PM, Stephen Rothwell wrote: +/* + * struct altera_spi_platform_data - platform data of the Altera SPI + * @interrupt: use intrrupt driven data transfer. + */ +struct altera_spi_platform_data { +int interrupt; +}; Is there some reason that this struct

[PATCH v3] spi: New driver for Altera SPI

2011-01-16 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. drivers/spi/Kconfig

[PATCH v4] spi: New driver for Altera SPI

2011-01-16 Thread Thomas Chou
This patch adds a new SPI driver to support the Altera SOPC Builder SPI component. It uses the bitbanging library. Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support v3 remove platform header, as Grant suggested. no irq resource means polling. v4 minor cleanup

[PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-16 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 minor cleanup, same as Grant suggest for spi_altera. drivers/spi/Kconfig |6 + drivers/spi/Makefile|1 + drivers

[PATCH v2] spi: add OpenCores tiny SPI driver

2011-01-11 Thread Thomas Chou
This patch adds support of OpenCores tiny SPI master driver. http://opencores.org/project,tiny_spi Signed-off-by: Thomas Chou tho...@wytron.com.tw --- v2 add devicetree support drivers/spi/Kconfig |6 + drivers/spi/Makefile|1 + drivers/spi/oc_tiny_spi.c