Hi Naveen,
Please see my comments inline.
On 15.07.2014 14:20, Naveen Krishna Chatradhi wrote:
> This patch validates the cs->line (Chip select gpio) and
> struct s3c64xx_spi_csinfo *cs object for both DT and NON-DT
> platforms before using in .setup().
>
> Also, check gpio_is_valid(spi->cs_gpio
by: Naveen Krishna Chatradhi
> Acked-by: Rob Herring
> Cc: Javier Martinez Canillas
> Cc: Doug Anderson
> Cc: Tomasz Figa
> ---
> This patch is a rework of the change @
> http://www.mail-archive.com/devicetree@vger.kernel.org/msg34500.html
>
> I'm not sure if i can ca
On 15.07.2014 19:21, Naveen Krishna Ch wrote:
> Hello Tomasz,
>
> On 15 July 2014 22:25, Tomasz Figa wrote:
>> Hi Naveen,
>>
>> On 14.07.2014 07:41, Naveen Krishna Chatradhi wrote:
>>> Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin)
>&g
uot;cs-gpio" property'/
s/'client/slave device of the SPI'/'SPI device'/
More things like this follow in rest of the text below.
Otherwise I believe the code after this patch does the right thing, so:
Reviewed-by: Tomasz Figa
Best regards,
Tomasz
-
On 11.06.2014 20:23, Naveen Krishna Ch wrote:
> Hello Tomasz,
>
> On 11 June 2014 23:20, Tomasz Figa wrote:
>> On 11.06.2014 19:27, Javier Martinez Canillas wrote:
>>> On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote:
>>>> On 11 June 2014 16:43, Javier Martin
On 11.06.2014 19:27, Javier Martinez Canillas wrote:
> On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote:
>> On 11 June 2014 16:43, Javier Martinez Canillas
>> wrote:
>>> On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote:
[snip]
>>>
return ERR_PTR(-EINVAL);
}
>>>
On 10.06.2014 21:58, Doug Anderson wrote:
> Tomasz,
>
> On Tue, Jun 10, 2014 at 12:49 PM, Tomasz Figa wrote:
>> This is wrong. The "cs-gpios" property is supposed to be an array,
>> indexed by chip select number of SPI devices (indicated by their "reg"
&
Hi Naveen,
On 10.06.2014 12:08, Naveen Krishna Chatradhi wrote:
> Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be
> defined under "controller-data" node under each slave node.
[snip]
> @@ -85,6 +83,7 @@ Example:
> #size-cells = <0>;
> pinctrl-names = "
On 10.06.2014 20:09, Doug Anderson wrote:
> Naveen / Sylwester,
>
> On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch
> wrote:
>>> Can we support both "cs-gpio" and "cs-gpios" for backward compatibility ?
>>> After your change all DTBs using the original pattern will not work with
>>> new kernel
On 10.06.2014 20:26, Doug Anderson wrote:
> Naveen,
>
> Not a full review, but a few quick things I happened to notice:
>
> On Tue, Jun 10, 2014 at 3:08 AM, Naveen Krishna Chatradhi
> wrote:
>> @@ -94,7 +93,6 @@ Example:
>> spi-max-frequency = <1>;
>>
>>
On Thursday 07 of February 2013 09:46:58 Girish KS wrote:
> On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa wrote:
> > Hi Girish,
> >
> > On Wednesday 06 of February 2013 12:12:29 Girish KS wrote:
> >> On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely
> >> >
&
writel(clr & ~clr, sdd->regs + S3C64XX_SPI_PENDING_CLR);
> >
> > Wait, what? clr & ~clr == 0 Always. What are you actually trying
> > to do here?
> The user manual says, wirting 1 to the pending clear register clears
> the interrupt (its not auto clear to
12 matches
Mail list logo
