Re: [PATCH v2 1/2] ARM: configs: Enable TI_EDMA in omap2plus_defconfig

2013-07-04 Thread Tony Lindgren
* Joel Fernandes [130626 20:48]: > Build EDMA in by default to avoid fewer people stepping on their toes > with broken DMA on drivers needing EDMA. Thanks applying this one into omap-for-v3.11/fixes. Tony -- This SF.net

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-24 Thread Tony Lindgren
* Benoit Cousson [130624 07:42]: > Hi Tony, > > On 06/24/2013 12:19 PM, Tony Lindgren wrote: > > Hi, > > > > For merging this series, I suggest the following sets: > > > > * Joel A Fernandes [130620 14:13]: > >> > >> Joel A Fernandes

Re: [PATCH v12 00/11] DMA Engine support for AM33XX

2013-06-24 Thread Tony Lindgren
Hi, For merging this series, I suggest the following sets: * Joel A Fernandes [130620 14:13]: > > Joel A Fernandes (3): > edma: config: Enable config options for EDMA > da8xx: config: Enable MMC and FS options > ARM: davinci: Fix compiler warnings in devices-da8xx > > Matt Porter (8): >

Re: [PATCH v12 04/11] dmaengine: edma: enable build for AM33XX

2013-06-24 Thread Tony Lindgren
to be taken by Tony. Sekhar, please go ahead and take this one. I'll reply to the header email of this series how it should be queued. For the mach-omap2/Kconfig change: Acked-by: Tony Lindgren > > --- > > arch/arm/mach-omap2/Kconfig |1 + > > drivers/dma/Kconfig

[PATCH] spi: omap2-mcspi: Fix transfers if DMADEVICES is not set

2013-04-12 Thread Tony Lindgren
: Tony Lindgren --- Does this look OK to get in for v3.10? There should not be any urgent need for this for v3.9-rc. --- a/drivers/spi/spi-omap2-mcspi.c +++ b/drivers/spi/spi-omap2-mcspi.c @@ -809,6 +809,10 @@ static int omap2_mcspi_setup_transfer(struct spi_device *spi, return 0

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Tony Lindgren
* Felipe Balbi [130204 07:46]: > > Current DMA abstraction is quite poor, for example there's no way to > compile support for multiple DMA engines. Code also makes certain, IMO > unnecessary, assumptions about the underlying DMA engine (abstraction is > poor, as said above but it we could follow

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Tony Lindgren
* Matt Porter [130202 11:51]: > On Sat, Feb 02, 2013 at 10:16:43AM -0800, Tony Lindgren wrote: > > * Matt Porter [130202 10:10]: > > > If it doesn't work, work with Vinod to fix the api. It's expected, > > > I'm working on dmaengine API changes right n

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Tony Lindgren
* Matt Porter [130202 10:10]: > If it doesn't work, work with Vinod to fix the api. It's expected, > I'm working on dmaengine API changes right now to deal with a > limitation of EDMA that needs to be abstracted. Regarding the DMA API limitations, I'm only aware of lack of capability to configure

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Tony Lindgren
* Matt Porter [130201 10:25]: > Move mach-davinci/dma.c to common/edma.c so it can be used > by OMAP (specifically AM33xx) as well. I think this should rather go to drivers/dma/? Tony -- Everyone hates slow websites. So

Re: [PATCH v4 09/14] mmc: omap_hsmmc: set max_segs based on dma engine limitations

2013-01-11 Thread Tony Lindgren
the nr_segs > capability is present, the value is used to configure mmc->max_segs > appropriately. Acked-by: Tony Lindgren > Signed-off-by: Matt Porter > --- > drivers/mmc/host/omap_hsmmc.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/m

Re: [PATCH v4 10/14] mmc: omap_hsmmc: add generic DMA request support to the DT binding

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > The binding definition is based on the generic DMA request binding. Acked-by: Tony Lindgren > Signed-off-by: Matt Porter > --- > .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 25 > +++- > 1 file changed, 24 inserti

Re: [PATCH v4 11/14] ARM: dts: add AM33XX MMC support

2013-01-11 Thread Tony Lindgren
* Matt Porter [130110 21:47]: > Adds AM33XX MMC support for am335x-bone, am335x-evm, and > am335x-evmsk.. This one should be queued separately by Benoit: Acked-by: Tony Lindgren > Signed-off-by: Matt Porter > --- > arch/arm/boot/dts/am335x-bone.dts |7 +++ >

Re: [PATCH v4 07/14] dmaengine: add dma_request_slave_channel_compat()

2013-01-11 Thread Tony Lindgren
made. > > This allows for a much cleaner migration of drivers to the > dmaengine DT API as platforms continue to be mixed between those > that boot using DT and those that do not. Cool, looks like the driver changes are quite minimal after this: Acked-by: Tony Lindgren > > Sugg

Re: [PATCH v4 08/14] mmc: omap_hsmmc: convert to dma_request_slave_channel_compat()

2013-01-11 Thread Tony Lindgren
menting EDMA so in the !DT case we can default to the OMAP DMA > filter. Acked-by: Tony Lindgren > Signed-off-by: Matt Porter > --- > drivers/mmc/host/omap_hsmmc.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/

Re: [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms

2012-09-21 Thread Tony Lindgren
* Arnd Bergmann [120921 02:19]: > On Thursday 20 September 2012, Tony Lindgren wrote: > > > /* use PIO for small transfers, avoiding DMA setup/teardown overhead and > > > @@ -798,14 +801,26 @@ static int omap2_mcspi_request_dma(struct > > > spi_device *spi)

Re: [RFC PATCH 07/13] mmc: omap_hsmmc: dma_request_slave_channel() support for DT platforms

2012-09-20 Thread Tony Lindgren
* Matt Porter [120920 07:43]: > For platforms with DT populated, use dma_request_slave_channel() > to acquire the DMA channel. For !DT platforms, we fall back to > explicitly passing the omap_dma_filter_fn() to dma_request_channel(). > Once all platforms boot from DT, the dma_request_channel() pat

Re: [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms

2012-09-20 Thread Tony Lindgren
* Matt Porter [120920 07:43]: > For platforms with DT populated, use dma_request_slave_channel() > to acquire the DMA channel. For !DT platforms, we fall back to > explicitly passing the omap_dma_filter_fn() to dma_request_channel(). > Once all platforms boot from DT, the dma_request_channel() pat

[PATCH 03/29] ARM: OMAP1: Make plat/mux.h omap1 only

2012-09-19 Thread Tony Lindgren
Cc: Tomi Valkeinen Cc: linux-...@vger.kernel.org Cc: linux-pcm...@lists.infradead.org Cc: spi-devel-general@lists.sourceforge.net Signed-off-by: Tony Lindgren --- arch/arm/mach-omap1/board-ams-delta.c |2 - arch/arm/mach-omap1/board-fsample.c |2 - arch/arm/mach-omap1

Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support

2012-09-18 Thread Tony Lindgren
* Shubhrajyoti [120918 05:09]: > On Tuesday 18 September 2012 05:31 PM, Matt Porter wrote: > > Adds pinctrl support to support OMAP platforms that boot from DT > > and rely on pinctrl support to set pinmuxes. > looks good > > Acked-by: Shubhrajyoti D

Re: [PATCH v2 2/2] ARM: OMAP2+: Enable pinctrl dummy states

2012-09-17 Thread Tony Lindgren
* Matt Porter [120917 10:21]: > Enable pinctrl dummy states for all OMAP platforms that don't > populate DT. This allows drivers to be converted to pinctrl > and not generate new warnings on platforms that do not provide > pinctrl data. These platforms already have pinmuxes configured > before the

Re: [PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support

2012-09-17 Thread Tony Lindgren
* Matt Porter [120917 10:21]: > Adds pinctrl support to support OMAP platforms that boot from DT > and rely on pinctrl support to set pinmuxes. > > Signed-off-by: Matt Porter Acked-by: Tony Lindgren > --- > drivers/spi/spi-omap2-mcspi.c |8 > 1 file

Re: [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states

2012-09-11 Thread Tony Lindgren
* Matt Porter [120911 12:05]: > On Tue, Sep 11, 2012 at 11:35:22AM -0700, Tony Lindgren wrote: > > Added Linus Walleij to Cc as well. Now I think I really managed to add Linus W to Cc, sent too fast earlier. ... > > But do you get an error then if the desired pins are not found

Re: [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states

2012-09-11 Thread Tony Lindgren
Added Linus Walleij to Cc as well. * Matt Porter [120911 11:24]: > On Tue, Sep 11, 2012 at 11:03:06AM -0700, Tony Lindgren wrote: > > * Matt Porter [120911 10:46]: > > > Enable pinctrl dummy states for all OMAP platforms. This allows > > > drivers to be converted to

Re: [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states

2012-09-11 Thread Tony Lindgren
* Matt Porter [120911 10:46]: > Enable pinctrl dummy states for all OMAP platforms. This allows > drivers to be converted to pinctrl while still running on > platforms that do not provide pinctrl data. > > Signed-off-by: Matt Porter > --- > arch/arm/mach-omap2/devices.c |4 > 1 file ch

Re: [PATCH 1/2] spi: omap2-mcspi: add pinctrl support

2012-09-11 Thread Tony Lindgren
* Matt Porter [120911 10:46]: > Adds pinctrl support to support OMAP platforms that boot from DT > and rely on pinctrl support to set pinmuxes. > > Signed-off-by: Matt Porter > --- > drivers/spi/spi-omap2-mcspi.c |9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/spi/

[PATCH 17/17] ARM: OMAP1: Move SoC specific headers from plat to mach for omap1

2012-09-10 Thread Tony Lindgren
Grant Likely Acked-by: Afzal Mohammed Signed-off-by: Tony Lindgren --- arch/arm/mach-omap1/board-htcherald.c |2 +- arch/arm/mach-omap1/devices.c |2 +- arch/arm/mach-omap1/include/mach/hardware.h |6 +++--- arch/arm/mach-omap1/include/mach/omap1510.h |3 +--

[PATCH 4/4] ARM: OMAP1: Move SoC specific headers from plat to mach for omap1

2012-08-31 Thread Tony Lindgren
Grant Likely Signed-off-by: Tony Lindgren --- arch/arm/mach-omap1/board-htcherald.c |4 ++-- arch/arm/mach-omap1/devices.c |2 +- arch/arm/mach-omap1/include/mach/hardware.h |6 +++--- arch/arm/mach-omap1/include/mach/omap1510.h |3 +-- arch/arm/mach-omap1/in

Re: [PATCH] spi: omap2-mcspi: In case of dma errors fall back to pio

2012-08-07 Thread Tony Lindgren
* Shubhrajyoti [120807 04:21]: > On Tuesday 07 August 2012 01:17 PM, Tony Lindgren wrote: > >> }; > > Don't you need to check separately for rx and tx dma? There's a slight > > chance that you get a channel for one but not for the other.. > In that case I tr

Re: [PATCH] spi: omap2-mcspi: In case of dma errors fall back to pio

2012-08-07 Thread Tony Lindgren
* Shubhrajyoti D [120724 23:26]: > In case there are dma errors currently the driver exits. > Make the spi driver fall back to pio mode in case of dma errors. > > If the DMA engine is not selected the driver > exits.This patch makes the spi fall back to pio in that case. > > Also adds a field dm

Re: mourning the loss of David Brownell

2011-04-06 Thread Tony Lindgren
* Jidong Xiao [110405 20:33]: > > > Me too. David and the other developers you mentioned here helped me a > lot. So sad, he is so young. Dave certainly contributed a lot and helped many people. He also helped a lot with omap development. Regards, Tony -

Re: [PATCH v6 0/6] OMAP: McSPI: Hwmod adaptation + runtime conversion

2011-02-09 Thread Tony Lindgren
* Kevin Hilman [110204 14:27]: > "Govindraj.R" writes: > > > Changes invloves: > > > > 1) Addition of hwmod data for omap2/3/4. > > 2) McSPI driver hwmod adaptation with cleanup of base address > >macros and using omap-device API's. > > 3) Runtime Conversion of McSPI driver.

Re: [PATCH] mcspi: Add support for GPIO chip select lines

2010-12-23 Thread Tony Lindgren
e. > > Each spi_board_info.controller_data should then be set > to point to the appropriate csinfo struct. This will cause the driver to > call the csinfo->set_level function instead of toggling the McSPI chip > select lines. > > Signed-off-by: Ben Gamari This one should go via th

Re: [PATCH] spi/omap2_mcspi: Verify TX reg is empty after TX only xfer with DMA

2010-10-20 Thread Tony Lindgren
the end of > the SPI transfer has been reached. > > Signed-off-by: Ilkka Koskinen > Tested-by: Tuomas Katila Grant, can you please queue this one? Acked-by: Tony Lindgren > --- > drivers/spi/omap2_mcspi.c | 39 ++- > 1 files c

[spi-devel-general] [PATCH 05/10] OMAP4: SPI: Fix Driver Kconfig

2010-05-14 Thread Tony Lindgren
From: Syed Rafiuddin Change dependency to ARCH_OMAP2PLUS to allow systems based on omap24xx, omap34xx or omap44xx Cc: spi-devel-general@lists.sourceforge.net Signed-off-by: Syed Rafiuddin Signed-off-by: Abraham Arce Signed-off-by: Tony Lindgren --- drivers/spi/Kconfig |6 +++--- 1 files

Re: [spi-devel-general] [PATCH v3 0/3] OMAP4 Ethernet Controller Support

2010-05-11 Thread Tony Lindgren
* Arce, Abraham [100510 18:36]: > > Enable network chip Micrel KS8851 for OMAP4430 SDP > > - Based on mainline version 2.6.34 rc7 > - Tested in OMAP4430 SDP > > Throughput measurements using nuttcp application: > 11.9375 MB / 10.06 sec =9.9519 Mbps 92 %TX 0 %RX 0 retrans 7.87 msRTT > >

Re: [spi-devel-general] [PATCH v2 1/3] OMAP4: SPI: Fix Driver Kconfig

2010-05-05 Thread Tony Lindgren
* Arce, Abraham [100505 00:05]: > From: Syed Rafiuddin > > Add OMAP4 data to allow McSPI driver built > > Signed-off-by: Syed Rafiuddin > Signed-off-by: Shubhro > Signed-off-by: Santosh Shilimkar > Signed-off-by: Abraham Arce > --- > drivers/spi/Kconfig |6 +++--- > 1 files changed, 3

Re: [spi-devel-general] [PATCH v1 2/3] OMAP4: Ethernet: KS8851 Board Support

2010-05-05 Thread Tony Lindgren
* Arce, Abraham [100505 01:06]: > Manjunath, > > > > + > > > +static void omap_ethernet_init(void) > > > +{ > > > + gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet"); > > > + gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1); > > > + gpio_request(ETHERNET_KS8851_QUART, "quart"); > > > +

Re: [spi-devel-general] [PATCH 2/4] OMAP4: SPI: Fix Driver Kconfig

2010-05-04 Thread Tony Lindgren
* Arce, Abraham [100422 07:39]: > From: Syed Rafiuddin > > Add OMAP4 data to allow McSPI driver built > > Signed-off-by: Syed Rafiuddin > Signed-off-by: Shubhro > Signed-off-by: Santosh Shilimkar > Signed-off-by: Abraham Arce > --- > drivers/spi/Kconfig |6 +++--- > 1 files changed, 3

Re: [spi-devel-general] [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config

2010-03-19 Thread Tony Lindgren
* Scott Ellis [100319 12:43]: > > Only 3430 and 3630 TRMs says 0xd, 0xe, 0xf = Division not supported. > > > I tested a 3503 with clock divider values of 0x0d, 0x0e and 0x0f. > It worked fine. > I collected data off the SPI bus successfully at the expected > frequencies of 5859 Hz, 2929 Hz and 14

Re: [spi-devel-general] [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config

2010-03-15 Thread Tony Lindgren
* Scott Ellis [100315 13:27]: > > Hmm now it looks like you're missing 3630 handling? > > > > If the max_clk_div is 0x0f for 2420 and 2430, then you > > can just check for cpu_is_omap24xx(). If it's only > > different for 2420, then you can check for cpu_is_omap2420(). > > > > That way it should

Re: [spi-devel-general] SPI troubles

2010-03-15 Thread Tony Lindgren
* Ben Gamari [100314 19:41]: > > P.P.S. Is it just me or does the omap_pinmux interface need some refinement. > Using it has been an exercise in frustration, between extremely sparse > documentation, quirky behavior (I still haven't figure out how to get gpio_130 > configured. omap_mux_init_gpio

Re: [spi-devel-general] [PATCH 2/6 Revised] SPI omap2_mcspi: Add max_clk_div field to mcspi platform config

2010-03-15 Thread Tony Lindgren
* Scott Ellis [100314 10:22]: > The McSPI_CHxCONF.CLKD register field has different limits for > the OMAP3 then the OMAP24xx. New max_clk_div field added to > mcspi platform config structure to keep track of this. > > Revised patch to not break multi-omap booting. > > Signed-off-by: Scott Ellis

Re: [spi-devel-general] PATCH[V2 1/3]: Update Platform files for SPI

2010-02-18 Thread Tony Lindgren
* Grant Likely [100218 08:26]: > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren wrote: > > * Hemanth V [100203 02:19]: > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 > >> From: Hemanth V > >> Date: Fri, 27 Nov 2009 14:22:3

Re: [spi-devel-general] PATCH[V2 1/3]: Update Platform files for SPI

2010-02-12 Thread Tony Lindgren
* Tony Lindgren [100209 15:03]: > * Grant Likely [100209 14:38]: > > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren wrote: > > > * Hemanth V [100203 02:19]: > > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 > > >> From: Hema

Re: [spi-devel-general] PATCH[V2 1/3]: Update Platform files for SPI

2010-02-09 Thread Tony Lindgren
* Grant Likely [100209 14:38]: > On Tue, Feb 9, 2010 at 3:25 PM, Tony Lindgren wrote: > > * Hemanth V [100203 02:19]: > >> From ee48142ddc43129a21676dbb56a83e3e7d8063de Mon Sep 17 00:00:00 2001 > >> From: Hemanth V > >> Date: Fri, 27 Nov 2009 14:22:3

Re: [spi-devel-general] PATCH[V2 1/3]: Update Platform files for SPI

2010-02-09 Thread Tony Lindgren
t; Signed-off-by: Hemanth V This should get merged via the spi-devel list with the other patches. Acked-by: Tony Lindgren > --- > arch/arm/mach-omap2/devices.c |5 + > arch/arm/plat-omap/include/plat/mcspi.h | 29 - > 2 > fi

Re: [spi-devel-general] [PATCH v2 2/3] [OMAP] Add spi100k configuration to OMAP1

2010-01-06 Thread Tony Lindgren
spi_100k.c. This patch add the related clocks and pin muxing entries to make the driver work on omap7xx platforms. Signed-off-by: Cory Maccarrone Signed-off-by: Tony Lindgren diff --git a/arch/arm/mach-omap1/clock_data.c b/arch/arm/mach-omap1/clock_data.c index 31fba07..2ac5796 100644

Re: [spi-devel-general] [PATCH 2/3] [OMAP] Add spi100k configuration to OMAP1

2009-12-07 Thread Tony Lindgren
* Cory Maccarrone [091206 20:48]: > This change implements the clocks, platform driver, and register > information necessary to use the spi100k bus with OMAP 7xx systems. > > The clocks added are dummy clocks because, although we're pretty > sure there are clocks used for SPI, all current booting

Re: [spi-devel-general] [PATCH 1/3] [SPI] [OMAP] Add OMAP spi100k driver

2009-12-07 Thread Tony Lindgren
Hi, * Cory Maccarrone [091206 20:48]: > This change adds the OMAP SPI 100k driver created by > Fabrice Crohas . This SPI bus is found on > OMAP7xx-series smartphones, and for many, the touchscreen is > attached to this bus. > > The lion's share of the work was done by Fabrice on this driver --

Re: [spi-devel-general] [RESEND][PATCH 0/2] McSPI Slave and DMA , FIFO support

2009-08-28 Thread Tony Lindgren
* Hemanth V [090828 05:05]: > Original Message - From: "David Brownell" > > >> On Sunday 05 July 2009, Hemanth V wrote: >>> Do you see any major changes required to support >>> slave mode in the SPI core driver. >> >> There *is* no such thing as a "SPI core driver"... >> > I was referrin

Re: [spi-devel-general] [RESEND][PATCH 2/2] McSPI Slave and DMA, FIFO support

2009-08-05 Thread Tony Lindgren
* David Brownell [090703 03:22]: > On Tuesday 23 June 2009, Hemanth V wrote: > > This patch adds support for McSPI slave and FIFO. DMA and FIFO > > could be enabled together for better throughput. > > > > This has a dependency on patch > > [RESEND][PATCH 1/2] McSPI Slave and DMA,FIFO support > >

Re: [spi-devel-general] [PATCH]OMAP4: McSPI Support for OMAP_4430

2009-08-05 Thread Tony Lindgren
base addresses > > > are changed between OMAP1/2/3 and OMAP4.The fields of the > > resource structures > > > are filled at runtime to have McSPI support on OMAP4. > > > > > > Signed-off-by: Syed Rafiuddin > > > Acked-by: Kevin H

Re: [spi-devel-general] [PATCH] OMAP: McSPI: Fix RX DMA transfer path

2009-06-15 Thread Tony Lindgren
* Kalle Valo [090613 09:45]: > Aaro Koskinen writes: > > > From: Eero Nurkkala > > > > When data is read through DMA, the last element must be read separately > > through the RX register. It cannot be transferred by the DMA. For further > > details see e.g. OMAP3430 TRM. > > > > Without the fix