Re: [PATCH 01/11] spi-dw: expose platform data stucture.

On 06/22/2011 10:06 PM, glik...@secretlab.ca wrote: > > > Dirk Brandewie wrote: > >> On 06/22/2011 09:03 PM, glik...@secretlab.ca wrote: >>> >>> >>> Dirk Brandewie wrote: >>> >>>> On 06/22/2011 08:47 PM, Grant Likely wrote:

Re: [PATCH 01/11] spi-dw: expose platform data stucture.

On 06/22/2011 09:03 PM, glik...@secretlab.ca wrote: > > > Dirk Brandewie wrote: > >> On 06/22/2011 08:47 PM, Grant Likely wrote: >>> On Wed, Jun 22, 2011 at 8:00 PM, wrote: >>>> From: Dirk Brandewie >>>> >>>> Expose the platform d

Re: [PATCH 08/11] spi-dw: Ensure fifo lenght is set.

On 06/22/2011 08:55 PM, Grant Likely wrote: > On Wed, Jun 22, 2011 at 8:00 PM, wrote: >> From: Dirk Brandewie >> >> Bug on fifo_len not being set. The fifo sizing routine does not work >> since the txfltr register can not be written while the controller is >> ena

Re: [PATCH 06/11] spi-dw: Force error on out of range chip select.

On 06/22/2011 08:51 PM, Grant Likely wrote: > On Wed, Jun 22, 2011 at 8:00 PM, wrote: >> From: Dirk Brandewie >> >> BUG_ON() if the selected chip select is out of range. >> >> Signed-off-by: Dirk Brandewie >> --- >> drivers/spi/spi-dw.h |3

Re: [PATCH 01/11] spi-dw: expose platform data stucture.

On 06/22/2011 08:47 PM, Grant Likely wrote: > On Wed, Jun 22, 2011 at 8:00 PM, wrote: >> From: Dirk Brandewie >> >> Expose the platform data structure for use by client drivers. ATM >> there are not any in-tree drivers using the driver (that I can >> find). Thi

Re: [PATCH 09/11] spi-dw: Fix condition in spi_dw_{writer/reader}

This patch should have been: spi-dw: Fix condition in spi_dw_{writer/reader} From: Dirk Brandewie Fix the condition based on whether the current transfer has a tx/rx buffer. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.c | 10 +- 1 files changed, 5 insertions(+), 5

Re: [PATCH 11/11] spi-dw: remove noop else clause

On 06/22/2011 07:47 PM, Feng Tang wrote: > On Thu, 23 Jun 2011 10:00:13 +0800 > "dirk.brande...@gmail.com" wrote: > >> From: Dirk Brandewie >> >> The value of spi->bits_per_word is checked on function entry to be 8 >> or 16. The else claus

Re: [PATCH 09/11] spi-dw: Fix condition in spi_dw_{writer/reader}

On 06/22/2011 07:45 PM, Feng Tang wrote: > On Thu, 23 Jun 2011 10:00:11 +0800 > "dirk.brande...@gmail.com" wrote: > >> From: Dirk Brandewie >> >> Fix the condition based on whether the current transfer has a tx/rx >> buffer. >> >> Signed-

Re: [PATCH 08/11] spi-dw: Ensure fifo lenght is set.

On 06/22/2011 07:41 PM, Feng Tang wrote: > > > On Thu, 23 Jun 2011 10:00:10 +0800 > "dirk.brande...@gmail.com" wrote: > >> From: Dirk Brandewie >> >> Bug on fifo_len not being set. The fifo sizing routine does not work >> since the txfltr re

[PATCH 02/11] spi-dw: update function naming convention to match file naming

From: Dirk Brandewie The file naming convention for drivers in the SPI subsystem is now being enforced update internal naming convention to match file naming. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw-mid.c | 26 +++--- drivers/spi/spi-dw-mmio.c | 38 +- drivers/spi

[PATCH 09/11] spi-dw: Fix condition in spi_dw_{writer/reader}

From: Dirk Brandewie Fix the condition based on whether the current transfer has a tx/rx buffer. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index cc38aa0

[PATCH 03/11] spi-dw: change MRST prefix to generic prefix

From: Dirk Brandewie The designware SPI core is now used in multiple SOC's. Make the prefix more generic and match other naming changes. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.c | 10 +- drivers/spi/spi-dw.h |3 +-- include/linux/spi/spi-dw.h |

[PATCH 05/11] spi-dw: split spi_dw_enable_chip() into spi_dw_enable()/spi_dw_disable()

From: Dirk Brandewie Split spi_dw_enable_chip() into two inline functions for readabilty. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw-mid.c |4 ++-- drivers/spi/spi-dw.c | 16 drivers/spi/spi-dw.h |9 +++-- 3 files changed, 17 insertions(+), 12

[PATCH 06/11] spi-dw: Force error on out of range chip select.

From: Dirk Brandewie BUG_ON() if the selected chip select is out of range. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index 860bc34..3fa4c13 100644 --- a/drivers

[PATCH 07/11] spi-dw: Set number of available chip selects correctly

From: Dirk Brandewie Only four chip selects are available directly off the pins of the master. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw-mid.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-dw-mid.c b/drivers/spi/spi-dw-mid.c index

[PATCH 08/11] spi-dw: Ensure fifo lenght is set.

From: Dirk Brandewie Bug on fifo_len not being set. The fifo sizing routine does not work since the txfltr register can not be written while the controller is enabled. The max value of txfltr can be larger than the fifo. The register allows values upto 0x3f (63) the fifo depth on the Intel

[PATCH 00/11] RFC spi-dw updates

From: Dirk Brandewie This patch set contains a number of changes were buried inside of one large patch in my last patch set. The rework of the message/transfer handling changes are not part of this patch set. This patch set applies after commit ca632f5 on spi/next Dirk Brandewie (11): spi

[PATCH 11/11] spi-dw: remove noop else clause

From: Dirk Brandewie The value of spi->bits_per_word is checked on function entry to be 8 or 16. The else clause has no meaning since it can never be reached. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --

[PATCH 04/11] spi-dw: remove unused definition

From: Dirk Brandewie Remove unused #define Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h index 0148356..6a1ee63 100644 --- a/drivers/spi/spi-dw.h +++ b/drivers/spi

[PATCH 10/11] spi-dw: Move checking of max_speed_hz value to be a prerequisite in spi_dw_setup

From: Dirk Brandewie Move the check of spi->max_speed_hz to be a prerequisite of spi_dw_setup(). Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index 35b9

[PATCH 01/11] spi-dw: expose platform data stucture.

From: Dirk Brandewie Expose the platform data structure for use by client drivers. ATM there are not any in-tree drivers using the driver (that I can find). This patch exposes the platform data needed for client drivers. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw.c |3

Re: [PATCH 3/5] dw_spi: rework message processing

On 06/16/2011 10:38 AM, Grant Likely wrote: > On Thu, Jun 16, 2011 at 11:28 AM, Dirk Brandewie > wrote: >> On 06/16/2011 07:00 AM, Feng Tang wrote: >>> >>> 4. I saw you enable both TX/RX interrupt when doing interrupt transfer, >>> spi >>> dev

Re: [PATCH 3/5] dw_spi: rework message processing

On 06/16/2011 07:00 AM, Feng Tang wrote: > Hi Dirk, > > IMHO, the patch is too big, it contains too many changes to the original > drivers, and we can't see clearly what you've changed to each logical > code part or section, If possible, could you separate this patch to > several small ones in a lo

[PATCH 3/5] dw_spi: rework message processing

From: Dirk Brandewie NOTE: patch created git format-patch --break-rewrites=/50% This patch reworks the message pump worker thread function to run until all messages queued to the driver have been handled. The function to handle individual spi_transfers is now a synchronus function the tasklet

[PATCH 4/5] spi/spi-dw: update function naming convention

From: Dirk Brandewie Update internal maning to match new file names now that the naming convention for driver files is being enforced. Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw-mid.c |8 ++-- drivers/spi/spi-dw-mmio.c | 34 ++-- drivers/spi/spi-dw-pci.c | 10

[PATCH 5/5] spi_dw_pci: Add runtime power management

From: Dirk Brandewie This patch adds runtime power management to the PCI variant of the designware SPI host controller driver. Signed-off-by: Kristen Carlson Accardi Signed-off-by: Dirk Brandewie --- drivers/spi/spi-dw-pci.c | 59 +- drivers/spi

[PATCH 1/5] spi/makefile: Fix typo from reorganize drivers patch.

From: Dirk Brandewie Fix Makefile to build designware driver. Signed-off-by: Dirk Brandewie --- drivers/spi/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile index f6d5018..b60b04b 100644 --- a/drivers/spi/Makefile

[PATCH 2/5] spi/dw_spi: expose dw_spi platform data stucture.

From: Dirk Brandewie This patch move the definition of the dw_spi_chip structure to a header file available to the client drivers. Signed-off-by: Dirk Brandewie Signed-off-by: Alan Cox --- drivers/spi/spi-dw.h | 20 +--- include/linux/spi/spi-dw.h | 20

[PATCH 0/5] Designware SPI driver update

From: Dirk Brandewie This patch set reworks the Designware SPI driver. This patch set is based on commit f8f82d4 on spi/next Patch 1: Fixes trivial typo from commit f8f82d4 in spi/next Patch 2: exports the platform data structure for client driver use. Patch 3: Reworks the

Re: [PATCH v2] spi: reorganize drivers

pcliff_pch.c uses KBUILD_MODNAME with a few funcs, but perhaps >> those are only for /proc/ status tracking ? worth double checking ... > > I just talked with Dirk Brandewie, who has a major rewrite to the > topcliff spi driver. I'll let him comment on whether or not changing >

Re: [PATCH v4] spi: add OpenCores tiny SPI driver

On 02/03/2011 02:37 AM, Thomas Chou wrote: > This patch adds support of OpenCores tiny SPI driver. > > http://opencores.org/project,tiny_spi > > +static int tiny_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) > +{ > + struct tiny_spi *hw = tiny_spi_to_hw(spi); > + const u8 *