Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-09-20 Thread Jarkko Nikula
On Fri, 3 Aug 2012 12:45:53 +0300 Aaro Koskinen wrote: > So an altenative hack to fix this is to modify the board file > (board-rx51-peripherals.c): > >/* list all spi devices here */ >enum { > RX51_SPI_WL1251, > - RX51_SPI_MIPID, /* LCD panel */

Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-08-03 Thread Aaro Koskinen
Hi, On Fri, Aug 03, 2012 at 05:20:48PM +0530, Shubhrajyoti wrote: > On Friday 03 August 2012 03:28 PM, Felipe Balbi wrote: > >> [1.496124] spi spi1.0: setup mode 0, 8 bits/w, 600 Hz max --> 0 > >> > [1.503265] omap2_mcspi omap2_mcspi.1: registered child spi1.0 > >> > > >> > If I modif

Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-08-03 Thread Shubhrajyoti
On Friday 03 August 2012 03:28 PM, Felipe Balbi wrote: >> [1.496124] spi spi1.0: setup mode 0, 8 bits/w, 600 Hz max --> 0 >> > [1.503265] omap2_mcspi omap2_mcspi.1: registered child spi1.0 >> > >> > If I modify the board file so that child spi1.0 is registered before >> > spi1.2, then

Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-08-03 Thread Aaro Koskinen
Hi, On Fri, Aug 03, 2012 at 11:05:27AM +0300, Tomi Valkeinen wrote: > On Thu, 2012-08-02 at 17:54 -0600, Grant Likely wrote: > > On Thu, Aug 2, 2012 at 5:08 PM, Aaro Koskinen wrote: > > > This reverts commit 9fdca9dfe093c76fe1ac1a09888ba9679d46996a. > > > > > > Changing omap2_mcspi_init() from su

Re: [PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-08-02 Thread Grant Likely
On Thu, Aug 2, 2012 at 5:08 PM, Aaro Koskinen wrote: > This reverts commit 9fdca9dfe093c76fe1ac1a09888ba9679d46996a. > > Changing omap2_mcspi_init() from subsys_initcall to device_initcall broke > the display initialization on N900 when all the drivers are compiled > built-in. Display subsystem dr

[PATCH] Revert "spi: omap2-mcspi: convert to module_platform_driver"

2012-08-02 Thread Aaro Koskinen
This reverts commit 9fdca9dfe093c76fe1ac1a09888ba9679d46996a. Changing omap2_mcspi_init() from subsys_initcall to device_initcall broke the display initialization on N900 when all the drivers are compiled built-in. Display subsystem drivers need a certain initialization order and having all of the