Re: [PATCH] spi: erase pointer to drvdata on removal

2013-01-14 Thread Vivien Didelot
Hi Mark, Grant, > On Mon, 14 Jan 2013 02:51:45 +, Mark Brown > wrote: > > On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote: > > > As for i2c-core, let the SPI core handle the removal of the > > > device's > > > drvdata, after a remove() or a probe() failure. > > > > Any driver

Re: [PATCH] spi: erase pointer to drvdata on removal

2013-01-14 Thread Grant Likely
On Mon, 14 Jan 2013 02:51:45 +, Mark Brown wrote: > On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote: > > As for i2c-core, let the SPI core handle the removal of the device's > > drvdata, after a remove() or a probe() failure. > > Any driver that notices this change is buggy, t

Re: [PATCH] spi: erase pointer to drvdata on removal

2013-01-13 Thread Mark Brown
On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote: > As for i2c-core, let the SPI core handle the removal of the device's > drvdata, after a remove() or a probe() failure. Any driver that notices this change is buggy, the driver shouldn't use a drvdata value that it didn't set. I had

[PATCH] spi: erase pointer to drvdata on removal

2012-11-01 Thread Vivien Didelot
As for i2c-core, let the SPI core handle the removal of the device's drvdata, after a remove() or a probe() failure. Signed-off-by: Vivien Didelot --- drivers/spi/spi.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index