Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-27 Thread Uwe Kleine-König
Hello Fabio, On Mon, Mar 26, 2012 at 11:19:42PM -0300, Fabio Estevam wrote: On 3/26/2012 5:59 PM, Uwe Kleine-König wrote: In my version of drivers/spi/spi-imx.c struct spi_imx_data is only defined once. I guess you wanted to say forward declaration. Yes, correct. ... Does this

[PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
Structure struct spi_imx_data is defined twice. Remove one of its definition. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/spi/spi-imx.c | 20 +--- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/spi/spi-imx.c

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Shubhrajyoti Datta
Hi Fabio, On Mon, Mar 26, 2012 at 11:43 PM, Fabio Estevam fabio.este...@freescale.com wrote: Structure struct spi_imx_data is defined twice. Remove one of its definition. Signed-off-by: Fabio Estevam fabio.este...@freescale.com ---  drivers/spi/spi-imx.c |   20 +---  1

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
Shubhrajyoti Datta wrote: Hi Fabio, On Mon, Mar 26, 2012 at 11:43 PM, Fabio Estevam fabio.este...@freescale.com wrote: Structure struct spi_imx_data is defined twice. Remove one of its definition. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/spi/spi-imx.c |

Re: [PATCH] spi-imx: Remove duplicate spi_imx_data definition

2012-03-26 Thread Fabio Estevam
On 3/26/2012 5:59 PM, Uwe Kleine-König wrote: In my version of drivers/spi/spi-imx.c struct spi_imx_data is only defined once. I guess you wanted to say forward declaration. Yes, correct. ... Does this really work? struct spi_imx_data has a member Yes, tested it on a mx31pdk board.