Re: [PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends.

2012-01-19 Thread Uwe Kleine-König
Hello Marc, I'm glad you respin the series. Some comments below. On Thu, Jan 19, 2012 at 12:01:32PM +1100, Marc Reilly wrote: > This patch abstracts the bus specific operations from the driver core. > Read and write handlers are introduced and generic initialization is > consolidated into mc13xxx

Re: [PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends.

2012-01-18 Thread Shawn Guo
Forgot to mention in my last reply that I recently added device tree probe support for mc13xxx-core which has hit the mainline, so you may need to rebase this series, or you will be asked by Samuel to anyway, I guess :) One nit on the subject of this patch: you may want to have prefix "mfd: mc13xx

[PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends.

2012-01-18 Thread Marc Reilly
This patch abstracts the bus specific operations from the driver core. Read and write handlers are introduced and generic initialization is consolidated into mc13xxx_comon_init. The irq member is removed because it is unused. Signed-off-by: Marc Reilly --- drivers/mfd/mc13xxx-core.c | 162