Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-12-07 Thread Linus Walleij
On Wed, Dec 7, 2011 at 9:22 PM, Wolfram Sang wrote: >> But I'll take it out when I add you Reviewed-by... > > Does that imply you will send out a V3 of this series somewhen and I > don't need to add this right now to the for-grant branch I am currently > preparing? No I just added them to my bra

Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Linus Walleij
On Tue, Nov 22, 2011 at 9:28 AM, Viresh Kumar wrote: > On 11/22/2011 1:55 PM, Linus WALLEIJ wrote: >>       if (list_empty(&pl022->queue) || !pl022->running) { >> +             if (pl022->busy) { >> +                     pm_runtime_put(&pl022->adev->dev); >> +             } > > We used to get warn

Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Viresh Kumar
On 11/22/2011 1:55 PM, Linus WALLEIJ wrote: > if (list_empty(&pl022->queue) || !pl022->running) { > + if (pl022->busy) { > + pm_runtime_put(&pl022->adev->dev); > + } We used to get warnings from checkpatch, for single line code inside {}. Don't we

[PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Linus Walleij
From: Chris Blair Moves the disabling of the device and clocks to the same thread in which the device and clocks are enabled. This avoids SMP issues where the device can be enabled for a transfer by one thread and then disabled by the completion of the previous transfer in another thread. Signed