Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-19 Thread Sourav Poddar
Hi Mark, On Thursday 18 July 2013 04:12 PM, Mark Brown wrote: > On Thu, Jul 18, 2013 at 03:31:26PM +0530, Sourav Poddar wrote: > >> QSPI is a kind of spi module that allows single, >> dual and quad read access to external spi devices. The module >> has a memory mapped interface which provide direct

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-19 Thread Sourav Poddar
Hi Felipe, On Thursday 18 July 2013 04:54 PM, Felipe Balbi wrote: > On Thu, Jul 18, 2013 at 04:48:41PM +0530, Sourav Poddar wrote: +static void qspi_write_msg(struct ti_qspi *qspi, struct spi_transfer *t) +{ + const u8 *txbuf; + int wlen, count; + + count = t->len;

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Sourav Poddar
On Friday 19 July 2013 12:38 AM, Trent Piepho wrote: > On Thu, Jul 18, 2013 at 3:01 AM, Sourav Poddar wrote: >> +Required properties: >> +- compatible : should be "ti,dra7xxx-qspi". >> +- reg: Should contain QSPI registers location and length. >> +- #address-cells, #size-cells : Must be present if

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Nishanth Menon
On 07/18/2013 03:39 PM, Mark Brown wrote: > On Thu, Jul 18, 2013 at 12:08:30PM -0700, Trent Piepho wrote: >> On Thu, Jul 18, 2013 at 3:01 AM, Sourav Poddar wrote: > >>> +- ti,hwmods: Name of the hwmod associated to the QSPI > >> What is ti,hwmods? It's not clear from the description. It also >>

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Trent Piepho
On Thu, Jul 18, 2013 at 3:01 AM, Sourav Poddar wrote: > +Required properties: > +- compatible : should be "ti,dra7xxx-qspi". > +- reg: Should contain QSPI registers location and length. > +- #address-cells, #size-cells : Must be present if the device has sub-nodes > +- ti,hwmods: Name of the hwmod

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Sourav Poddar
Hi Mark, On Thursday 18 July 2013 08:12 PM, Mark Brown wrote: > On Thu, Jul 18, 2013 at 04:31:58PM +0300, Felipe Balbi wrote: >> On Thu, Jul 18, 2013 at 02:18:22PM +0100, Mark Brown wrote: >>> So why do we report that we handled the interrupt then? Shouldn't we at >>> least warn if we're getting s

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Sourav Poddar
On Thursday 18 July 2013 04:54 PM, Felipe Balbi wrote: > On Thu, Jul 18, 2013 at 04:48:41PM +0530, Sourav Poddar wrote: +static void qspi_write_msg(struct ti_qspi *qspi, struct spi_transfer *t) +{ + const u8 *txbuf; + int wlen, count; + + count = t->len; + txb

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Sourav Poddar
On Thursday 18 July 2013 04:12 PM, Mark Brown wrote: > On Thu, Jul 18, 2013 at 03:31:26PM +0530, Sourav Poddar wrote: > >> QSPI is a kind of spi module that allows single, >> dual and quad read access to external spi devices. The module >> has a memory mapped interface which provide direct interfac

Re: [PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Sourav Poddar
Hi Felipe, On Thursday 18 July 2013 03:54 PM, Felipe Balbi wrote: > Hi, > > it might be just me, but ... > > On Thu, Jul 18, 2013 at 03:31:26PM +0530, Sourav Poddar wrote: >> +static inline unsigned long ti_qspi_readl_data(struct ti_qspi *qspi, >> +unsigned long reg, int wlen) >> +{ >>

[PATCHv4 2/3] drivers: spi: Add qspi flash controller

2013-07-18 Thread Sourav Poddar
The patch add basic support for the quad spi controller. QSPI is a kind of spi module that allows single, dual and quad read access to external spi devices. The module has a memory mapped interface which provide direct interface for accessing data form external spi devices. The patch will configu